Re: [PATCH] gnu: Add perceptualdiff.

2016-07-25 Thread Leo Famulari
On Mon, Jul 25, 2016 at 12:49:56PM +0200, Vincent Legoll wrote: > Hello, > > > Maybe you're right. Unlike the gnu-build-sytem, the cmake-build-system > > seems to create a 'build/' directory adjacent to the unpacked source > > code. > > Yes, I think in cmake's land, the recommended way is to buil

Re: [PATCH] gnu: Add perceptualdiff.

2016-07-25 Thread Vincent Legoll
Hello, > Maybe you're right. Unlike the gnu-build-sytem, the cmake-build-system > seems to create a 'build/' directory adjacent to the unpacked source > code. Yes, I think in cmake's land, the recommended way is to build in a directory outside of the source code , generally at the same level than

Re: [PATCH] gnu: Add perceptualdiff.

2016-07-24 Thread Leo Famulari
On Sun, Jul 24, 2016 at 11:56:05PM +0200, Tobias Geerinckx-Rice wrote: > Leo! > > On 2016-07-24 23:44, Leo Famulari wrote: > > > +;; cmake-build-system uses a build/ directory > > > outside > > > +;; of the source tree, one level higher than > > > expected >

Re: [PATCH] gnu: Add perceptualdiff.

2016-07-24 Thread Tobias Geerinckx-Rice
Leo! On 2016-07-24 23:44, Leo Famulari wrote: +;; cmake-build-system uses a build/ directory outside +;; of the source tree, one level higher than expected Do you think this is a bug that should be reported? Oh, I don't know. I assumed it was an artef

Re: [PATCH] gnu: Add perceptualdiff.

2016-07-24 Thread Leo Famulari
On Sun, Jul 24, 2016 at 05:43:25AM +0200, Tobias Geerinckx-Rice wrote: > * gnu/packages/image.scm (perceptualdiff): New variable. LGTM > +(arguments > + '(#:phases (modify-phases %standard-phases > + (add-after 'unpack 'fix-tests > +;; cmake-build-syst

Re: [PATCH] gnu: Add perceptualdiff.

2016-07-24 Thread Ludovic Courtès
Tobias Geerinckx-Rice skribis: > * gnu/packages/image.scm (perceptualdiff): New variable. LGTM, thanks! Ludo'.

[PATCH] gnu: Add perceptualdiff.

2016-07-23 Thread Tobias Geerinckx-Rice
* gnu/packages/image.scm (perceptualdiff): New variable. --- gnu/packages/image.scm | 32 1 file changed, 32 insertions(+) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 188d142..7d72492 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/im