Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-26 Thread Ludovic Courtès
Pjotr Prins skribis: > On Sun, Oct 26, 2014 at 03:00:48PM +0100, Ludovic Courtès wrote: >> Similar to what we do for Bash, the version field should be >> 1.8.7.374, which would preserve ordering. > > The filename contains 1.8.7-p374. So, can I use that for the version? I have a preference for 1.

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-26 Thread Pjotr Prins
On Sun, Oct 26, 2014 at 03:00:48PM +0100, Ludovic Courtès wrote: > Similar to what we do for Bash, the version field should be > 1.8.7.374, which would preserve ordering. The filename contains 1.8.7-p374. So, can I use that for the version? Pj.

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-26 Thread Mark H Weaver
Pjotr Prins writes: > We have package-name and package-version. Why not package-patch-level? > I don't think it should be part of version. I agree with Ludovic. The patch-level is conceptually part of the version. We have a fair bit of program logic, APIs, and user interface elements that assum

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-26 Thread Ludovic Courtès
Similar to what we do for Bash, the ‘version’ field should be “1.8.7.374”, which would preserve ordering. Ludo’.

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-25 Thread Pjotr Prins
On Sun, Oct 26, 2014 at 12:34:49AM -0400, Mark H Weaver wrote: > Mark H Weaver wrote: > > What's that "-p374" in the file name? If it's a patch level, then I > > think it should be part of the version string. > > Pjotr Prins wrote: > > Good point. How do we use patch levels anyway? > > I'm sorr

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-25 Thread Mark H Weaver
Mark H Weaver wrote: > What's that "-p374" in the file name? If it's a patch level, then I > think it should be part of the version string. Pjotr Prins wrote: > Good point. How do we use patch levels anyway? I'm sorry, I don't understand your question. What does it mean to "use" a patch level?

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-25 Thread Pjotr Prins
Good point. How do we use patch levels anyway? On Sat, Oct 25, 2014 at 08:17:58PM -0400, Mark H Weaver wrote: > What's that "-p374" in the file name? If it's a patch level, then I > think it should be part of the version string. > > Mark >

Re: [PATCH] gnu: Add older ruby 1.8.7

2014-10-25 Thread Mark H Weaver
Pjotr Prins writes: > * gnu/packages/ruby.scm: Added older Ruby 1.8.7 > --- > gnu/packages/ruby.scm | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index ac751f5..0b10b87 100644 > --- a/gnu/packages/ruby.

[PATCH] gnu: Add older ruby 1.8.7

2014-10-25 Thread Pjotr Prins
* gnu/packages/ruby.scm: Added older Ruby 1.8.7 --- gnu/packages/ruby.scm | 27 +++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index ac751f5..0b10b87 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -8