Re: [PATCH] gnu: Add mongodb.

2017-08-23 Thread Christopher Baines
On Thu, 17 Mar 2016 16:08:24 +0100 Roel Janssen wrote: > Dear Guix, > > This is a patch to add MongoDB (server and client) tools. I used a > three-line patch to fix the build process's reliance on Git and the > .git/ directory. Hey, I've now created bug #28198 with a slightly modified version

Re: [PATCH] gnu: Add mongodb.

2016-04-29 Thread Roel Janssen
Hello Ludo’, Ludovic Courtès writes: > Hi! > > Roel Janssen skribis: > >> My reasoning for keeping the third-party libraries in the tarball was >> simply because upstream made that choice. Unbundling can and probably >> will introduce differences in the behavior of the output with other >> dis

Re: [PATCH] gnu: Add mongodb.

2016-04-29 Thread Ludovic Courtès
Hi! Roel Janssen skribis: > My reasoning for keeping the third-party libraries in the tarball was > simply because upstream made that choice. Unbundling can and probably > will introduce differences in the behavior of the output with other > distributions and their official binaries. When unbu

Re: [PATCH] gnu: Add mongodb.

2016-03-19 Thread Thompson, David
Hi Roel, 2016-03-17 11:08 GMT-04:00 Roel Janssen : > Dear Guix, > > This is a patch to add MongoDB (server and client) tools. I used a > three-line patch to fix the build process's reliance on Git and the > .git/ directory. Sorry to be the bearer of bad news, but I became suspicious about this p

Re: [PATCH] gnu: Add mongodb.

2016-03-19 Thread Ludovic Courtès
"Thompson, David" skribis: > This is a really bad practice from a security and maintenance > perspective, so in Guix we do our best to unbundle as many things as > possible. I recommend deleting everything above besides the "shim_*" > files using a snippet in the origin record (search for "snipp

Re: [PATCH] gnu: Add mongodb.

2016-03-19 Thread Leo Famulari
On Thu, Mar 17, 2016 at 04:08:24PM +0100, Roel Janssen wrote: > Subject: [PATCH] gnu: Add mongodb. Thanks for this patch! > * gnu/packages/databases.scm (mongodb): New variable. > * gnu/packages/patches/mongodb-add-version-file.patch: New file. > * gnu-system.am (dist_patch_DATA): Ad

[PATCH] gnu: Add mongodb.

2016-03-19 Thread Roel Janssen
>From 47d5ad30c1e1e2a24b950236590e10bbf72c277e Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Thu, 17 Mar 2016 16:06:40 +0100 Subject: [PATCH] gnu: Add mongodb. * gnu/packages/databases.scm (mongodb): New variable. * gnu/packages/patches/mongodb-add-version-file.patch: New file. *

Re: [PATCH] gnu: Add mongodb.

2016-03-19 Thread Roel Janssen
Hello David, Thanks for your feedback, and sorry for my incomplete patch. My reasoning for keeping the third-party libraries in the tarball was simply because upstream made that choice. Unbundling can and probably will introduce differences in the behavior of the output with other distributions