Re: [PATCH] gnu: Add ghc-flac.

2017-01-16 Thread Ludovic Courtès
Hi Danny, To complement Marius’ review… Danny Milosavljevic skribis: > +(description "Complete high-level binding to libFLAC for Haskell.") Please make it a complete sentence, and sort-of hint at what libFLAC along these lines: This package provides a Haskell interface to libFLAC, the F

Re: [PATCH] gnu: Add ghc-flac.

2017-01-15 Thread Marius Bakke
Danny Milosavljevic writes: > * gnu/packages/haskell.scm (ghc-flac): New variable. Cool! [...] > +(native-inputs > + `(("ghc-hspec" ,ghc-hspec) > + ("hspec-discover" ,hspec-discover))) Are these referenced by the built product? If so, they should be in [inputs]. You can check re

[PATCH] gnu: Add ghc-flac.

2017-01-15 Thread Danny Milosavljevic
* gnu/packages/haskell.scm (ghc-flac): New variable. --- gnu/packages/haskell.scm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm index b26234d40..b2ee11b2a 100644 --- a/gnu/packages/haskell.scm +++ b/gnu/p