Re: [PATCH] gnu: Add clojure.

2016-08-16 Thread Pjotr Prins
On Tue, Aug 16, 2016 at 08:45:17PM +0200, Ricardo Wurmus wrote: > > Alex Vong writes: > > > Thanks for the review too. The changes looks good to me, excepts that it > > seems 'find-files' will find all files with name matching the regex > > recursively, but `scandir' will only list the files on

Re: [PATCH] gnu: Add clojure.

2016-08-16 Thread Ricardo Wurmus
Alex Vong writes: > Thanks for the review too. The changes looks good to me, excepts that it > seems 'find-files' will find all files with name matching the regex > recursively, but `scandir' will only list the files on the 1st > level. Ah, I didn’t notice that this is what you were trying to d

Re: [PATCH] gnu: Add clojure.

2016-08-16 Thread Alex Vong
l.clj is licensed under CPL1.0 ;; ;; See readme.html or readme.txt for details. (license (list license:epl1.0 Here is the whole patch: >From 8c0bdc35a168d6c1102ba81a6f26c847bb47c47e Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Tue, 5 J

Re: [PATCH] gnu: Add clojure.

2016-08-15 Thread Ricardo Wurmus
dwjz45p5ymhy0")) - (modules '((guix build utils))) - (snippet remove-archives + ,(submodule "tools.namespace/archive/tools.namespace-" + "0.2.11" + "10baak8v0hnwz2hr33bavshm7y49mmn9zsy

Re: [PATCH] gnu: Add clojure.

2016-07-26 Thread Alex Vong
> Thanks again for your work. Please send the missing patch some time :) > > ~~ Ricardo Cheers, Alex >From 420ca3add28cb493f69bff44f461b870f6546b51 Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Tue, 5 Jul 2016 16:24:20 +0800 Subject: [PATCH] gnu: Add clojure. * gnu/packages/java.

Re: [PATCH] gnu: Add clojure.

2016-07-26 Thread Ricardo Wurmus
Hi Alex, > Thanks for the review again, the package definition is now simplier. You only attached the patch to the Clojure sources. Could you please also attach the latest patch to add the clojure package? > Yes, the ASM library is included as source (not jar) and is one majar > version behind

Re: [PATCH] gnu: Add clojure.

2016-07-26 Thread Alex Vong
Hi Ricardo, Thanks for the review again, the package definition is now simplier. Ricardo Wurmus writes: > Hi Alex, > > Usually, we will split bundled libraries. For bundled “jar” archives > this is necessary in any case as a “jar” file is a binary. > > If the libraries are bundled in source fo

Re: [PATCH] gnu: Add clojure.

2016-07-24 Thread Ricardo Wurmus
Hi Alex, > I see. So the general policy here is to be lazy and packaged by need :) > This time only version 1.8 is added. Does this apply to splitting > bundled libraries as well? I see clojure has some java libraries bundled > such as ASM. Currently, I suppose no other packages depend on it. Us

Re: [PATCH] gnu: Add clojure.

2016-07-14 Thread Alex Vong
; Now only version 1.8 is added, the problem has gone temporarily. But it is interesting to know how the gcc package solves this problem. > Again, thanks a lot for the effort! I really hope we can add Clojure to > Guix soon. > > ~~ Ricardo Thanks, Alex >From 69cb51c65014083a583823

Re: [PATCH] gnu: Add clojure.

2016-07-13 Thread Ricardo Wurmus
Hi Alex, > This patch adds clojure 1.6 to 1.8. Wow. Thanks! > Changes made since last email (comments appreciated): > > Include clojure from 1.6 to 1.8 instead of just 1.8 because I think we > should provide all stable versions and allowed them to be > co-installed. From https://clojure.github

[PATCH] gnu: Add clojure.

2016-07-06 Thread Alex Vong
But this looks a bit ugly to me. Thanks. Alex >From 5b275a8ac0209316b89a3c35f6c76740b0ba245f Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Tue, 5 Jul 2016 16:24:20 +0800 Subject: [PATCH] gnu: Add clojure. * gnu/packages/java.scm (remove-archives, clojure-1.6, clojure-1.7, clojure-

Re: [PATCH] gnu: Add clojure.

2016-02-27 Thread Ricardo Wurmus
Alex Vong writes: > Federico Beffa writes: > >> Alex Vong writes: >> >>> + #:phases >>> + (modify-phases %standard-phases >>> + (delete 'configure) >>> + (replace 'unpack >>> + (lambda _ >>> + (and (mkdir "clojure/") >>> + (zer

Re: [PATCH] gnu: Add clojure.

2016-02-27 Thread Federico Beffa
Alex Vong writes: > + (every (lambda (src) > +(begin (unpack src) > + (copy src))) > + '("data-generators-src" "java-classpath-src" > +"test-check-src" "test-generative-src" > +

Re: [PATCH] gnu: Add clojure.

2016-02-26 Thread Alex Vong
(copy src))) >> + '("data-generators-src" "java-classpath-src" >> +"test-check-src" "test-generative-src" >> + "tools-namespace-src

[PATCH] gnu: Add clojure.

2016-02-24 Thread Federico Beffa
Alex Vong writes: > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'unpack > + (lambda _ > + (and (mkdir "clojure/") > + (zero? (system* "unzip" > + "-d" "cloju

Re: [PATCH] gnu: Add clojure.

2016-02-24 Thread Alex Vong
Ricardo Wurmus writes: > Alex Vong writes: > >> Hi everyone, >> >> This patch adds clojure to guix. I have been interested in clojure's >> syntax for vector [] and hash-map {} for a while, after watching the >> introduction of clojure to lisper video. So, I decide to package it for >> guix! Note

Re: [PATCH] gnu: Add clojure.

2016-02-24 Thread Ricardo Wurmus
Alex Vong writes: > Hi everyone, > > This patch adds clojure to guix. I have been interested in clojure's > syntax for vector [] and hash-map {} for a while, after watching the > introduction of clojure to lisper video. So, I decide to package it for > guix! Note that I follow the example in ldc

[PATCH] gnu: Add clojure.

2016-02-23 Thread Alex Vong
jure-gcj package? Cheers, Alex >From 4afe3af6cbc36956a6c9c16d76b52499ffc4a8c2 Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Wed, 24 Feb 2016 12:43:36 +0800 Subject: [PATCH] gnu: Add clojure. * gnu/packages/java.scm (clojure): New variable. ---