Ricardo Wurmus writes:
> Roel Janssen writes:
>
>
+ (replace
+ 'install
>>>
>>> Please put “'install” on the same line as “(replace”.
>>
>> Should I do this for other (replace ...) as well? If I want to replace
>> the build phase, should I put it on the same line as w
Roel Janssen writes:
>>> + (replace
>>> + 'install
>>
>> Please put “'install” on the same line as “(replace”.
>
> Should I do this for other (replace ...) as well? If I want to replace
> the build phase, should I put it on the same line as well?
Yes, the phase name(s) should
On Fri, Mar 11, 2016 at 12:00:11AM +0100, Roel Janssen wrote:
> Thank you for reviewing this patch. I hope it is fine now.
Thanks for the revised patch!
Pushed as a0a71439fa3, adding a copyright line for you.
> > The git repo includes a manpage 'awk.1'. Can you send an updated patch
> > that in
>From ec580c06e33de844f6f6cb7c4fc3b44691e141fd Mon Sep 17 00:00:00 2001
From: Roel Janssen
Date: Thu, 10 Mar 2016 23:54:31 +0100
Subject: [PATCH] gnu: Add bioawk.
* gnu/packages/bioinformatics.scm (bioawk): New variable.
---
gnu/packages/bioinformatics.scm |
Roel Janssen writes:
> Please let me know when something is wrong with the patch.
In addition to Leo’s comments here are mine:
> +(arguments
> + `(#:parallel-build? #f
Why is parallel-build disabled? Could you add a comment?
> + #:phases
> + (modify-phases %standard-phas
On Tue, Mar 08, 2016 at 09:10:14PM +0100, Roel Janssen wrote:
> From 990eda92a62dc25d0f5792437a82e119c5e3579f Mon Sep 17 00:00:00 2001
> From: Roel Janssen
> Date: Tue, 8 Mar 2016 21:06:53 +0100
> Subject: [PATCH] gnu: Add bioawk.
>
> * gnu/packages/bioinformatics.scm (bio
>From 990eda92a62dc25d0f5792437a82e119c5e3579f Mon Sep 17 00:00:00 2001
From: Roel Janssen
Date: Tue, 8 Mar 2016 21:06:53 +0100
Subject: [PATCH] gnu: Add bioawk.
* gnu/packages/bioinformatics.scm (bioawk): New variable.
---
gnu/packages/bioinformatics.scm |