Re: [PATCH] gnu: Add bash-tap.

2016-05-07 Thread Roel Janssen
e what comments you are exactly refering to, I think this new patch should be better :) Once again, thanks for your time! Here is the patch: >From f3d6252be65844c22716f388895fc0d82e96e123 Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Sat, 7 May 2016 19:09:40 +0200 Subject: [PATCH] gnu: Ad

Re: [PATCH] gnu: Add bash-tap.

2016-05-06 Thread Leo Famulari
Tue, 3 May 2016 12:44:57 +0200 Subject: [PATCH] gnu: Add bash-tap. Leo Famulari writes: > On Fri, Mar 18, 2016 at 07:53:39PM +0100, Andreas Enge wrote: >> On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote: >> > Can someone with more experience take a look and apply the pa

Re: [PATCH] gnu: Add bash-tap.

2016-05-03 Thread Roel Janssen
t; I think using gnu-build-system is the way to go. Here's a patch using the gnu build system: >From 7daef2ee0fdb1aef7344da6ff0afe31efcf41cac Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Tue, 3 May 2016 12:43:00 +0200 Subject: [PATCH] gnu: Add bash-tap. * gnu/packages/bash.scm (bash-tap): New variable. --- gn

[PATCH] gnu: Add bash-tap.

2016-03-19 Thread Roel Janssen
>From f50ae55cfd2edc513de33b2736f9c3a13cd43532 Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Thu, 17 Mar 2016 17:03:34 +0100 Subject: [PATCH] gnu: Add bash-tap. * gnu/packages/bash.scm (bash-tap): New variable. --- gnu/packages/bash.scm | 46 ++

Re: [PATCH] gnu: Add bash-tap.

2016-03-19 Thread Andreas Enge
On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote: > Can someone with more experience take a look and apply the patch if it's > okay? I had a look (without having much experience with the trivial build system), and it looks mostly clean. However, the package installs three bash scripts

Re: [PATCH] gnu: Add bash-tap.

2016-03-19 Thread Leo Famulari
On Fri, Mar 18, 2016 at 07:53:39PM +0100, Andreas Enge wrote: > On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote: > > Can someone with more experience take a look and apply the patch if it's > > okay? > > I had a look (without having much experience with the trivial build system), > an

Re: [PATCH] gnu: Add bash-tap.

2016-03-19 Thread Ludovic Courtès
Andreas Enge skribis: > I had a look (without having much experience with the trivial build system), > and it looks mostly clean. However, the package installs three bash scripts > that start with "#!/bin/bash". This will not work on GuixSD, where only > /bin/sh exists. It should be patched by ad

Re: [PATCH] gnu: Add bash-tap.

2016-03-18 Thread Leo Famulari
On Thu, Mar 17, 2016 at 05:08:11PM +0100, Roel Janssen wrote: > From f50ae55cfd2edc513de33b2736f9c3a13cd43532 Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Thu, 17 Mar 2016 17:03:34 +0100 > Subject: [PATCH] gnu: Add bash-tap. > > * gnu/packages/bash.scm (bash-tap): New