Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-13 Thread Ludovic Courtès
s edit)? > > Attached patch includes my name. > > Troy > > From 6381b62a3774001f630d868fa7e58acc28b0cc4f Mon Sep 17 00:00:00 2001 > From: Troy Sankey > Date: Sun, 10 Jul 2016 17:45:55 -0400 > Subject: [PATCH] doc: clarification for hashing git checkouts > > When hashing git

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread Troy Sankey
. Troy From 6381b62a3774001f630d868fa7e58acc28b0cc4f Mon Sep 17 00:00:00 2001 From: Troy Sankey Date: Sun, 10 Jul 2016 17:45:55 -0400 Subject: [PATCH] doc: clarification for hashing git checkouts When hashing git checkouts of packages, packagers must first remove the .git directory. This commit adds this c

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread ng0
patch below reads okay to me, could you add your name or nickname in the section of guix.texi where document author names are included, if applicable (ie if your name is missing before this edit)? > From 42b26d3601a6318bcefa4dfe4018daddc521e27a Mon Sep 17 00:00:00 2001 > From: Troy Sankey > Date: Sun, 10 Jul 2

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread Leo Famulari
On Mon, Jul 11, 2016 at 01:33:40AM -0400, Troy Sankey wrote: > Hashing sources is becoming quite compilated! I can't wait until 'guix > download' supports git, then this could be automated. In that case, `guix download` would need to take a Git hash as an argument. In general, I think it's a goo

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread Pjotr Prins
Yes, that is how I understand it previously did not work for me. Thanks :) On Mon, Jul 11, 2016 at 01:33:40AM -0400, Troy Sankey wrote: > Quoting Pjotr Prins (2016-07-10 20:13:26) > > And only now I am understanding a problem ages ago. Would this also be > > the reason for git sub-modules not to w

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Troy Sankey
Quoting Pjotr Prins (2016-07-10 20:13:26) > And only now I am understanding a problem ages ago. Would this also be > the reason for git sub-modules not to work? Pjotr, If I'm understanding correctly, you failed to generate the hash of a git repository containing submodules? In that case, you may

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Troy Sankey
oncerned about the specifics of using 'guix hash' before they learn the name of the tool. Troy From 42b26d3601a6318bcefa4dfe4018daddc521e27a Mon Sep 17 00:00:00 2001 From: Troy Sankey Date: Sun, 10 Jul 2016 17:45:55 -0400 Subject: [PATCH] doc: clarification for hashing git checkouts When hashing git che

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Pjotr Prins
On Sun, Jul 10, 2016 at 07:16:30PM -0400, Leo Famulari wrote: > On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: > > When hashing git checkouts of packages, packagers must first remove the .git > > directory. This commit adds this clarification to the "Invoking guix hash" > > page in t

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Leo Famulari
On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: > When hashing git checkouts of packages, packagers must first remove the .git > directory. This commit adds this clarification to the "Invoking guix hash" > page in the documentation. Yes! This is one that *everybody* has to ask. I th

[PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Troy Sankey
When hashing git checkouts of packages, packagers must first remove the .git directory. This commit adds this clarification to the "Invoking guix hash" page in the documentation. --- doc/guix.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index c9d9bd8..