Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Liliana Marie Prikler
Am Dienstag, dem 09.08.2022 um 22:30 +0200 schrieb Maxime Devos: > > On 09-08-2022 21:08, Liliana Marie Prikler wrote: > > [I]t doesn't take multiple lines to embed a store path, the change > > usually happens on a single line > I was thinking of files that contain multiple instances of "foo" > (u

Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Maxime Devos
On 09-08-2022 21:08, Liliana Marie Prikler wrote: To be clear, do you mean you:  * think it's not better, maybe even worse  * think it's not_much_ better (but still_slightly_ better)  * are undecided  * or something else ? Also, "guix build -S" returns the source code (after snippet / patc

Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Maxime Devos
On 09-08-2022 21:08, Liliana Marie Prikler wrote: On 06-08-2022 08:55, Liliana Marie Prikler wrote: +If your package has a bug that takes multiple lines to fix, I don't think this is true for replacing all instances of "foo" by "/gnu/store/.../bin/foo" in a file. Should it? I don't think s

Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Liliana Marie Prikler
Am Dienstag, dem 09.08.2022 um 20:19 +0200 schrieb Maxime Devos: > > Am Dienstag, dem 09.08.2022 um 18:45 +0200 schrieb Maxime Devos: > > > > > On 06-08-2022 08:55, Liliana Marie Prikler wrote: > > > > > > > > > > +If your package has a bug that takes multiple lines to fix, > > > I don't think t

Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Maxime Devos
Am Dienstag, dem 09.08.2022 um 18:45 +0200 schrieb Maxime Devos: On 06-08-2022 08:55, Liliana Marie Prikler wrote: +If your package has a bug that takes multiple lines to fix, I don't think this is true for replacing all instances of "foo" by "/gnu/store/.../bin/foo" in a file. Should it? I d

Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Liliana Marie Prikler
Am Dienstag, dem 09.08.2022 um 18:45 +0200 schrieb Maxime Devos: > On 06-08-2022 08:55, Liliana Marie Prikler wrote: > > > +If your package has a bug that takes multiple lines to fix, > I don't think this is true for replacing all instances of "foo" by > "/gnu/store/.../bin/foo" in a file. Should

Re: [PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-09 Thread Maxime Devos
On 06-08-2022 08:55, Liliana Marie Prikler wrote: +If your package has a bug that takes multiple lines to fix, I don't think this is true for replacing all instances of "foo" by "/gnu/store/.../bin/foo" in a file. or a fix +has already been accepted upstream, patches are the preferred way of

[PATCH] doc: Update contribution guidelines on patches, etc.

2022-08-06 Thread Liliana Marie Prikler
* doc/contributing.texi ("Snippets versus Phases"): Replaced with... ("Modifying Sources"): ... this. List more use cases and some principles. --- doc/contributing.texi | 85 --- 1 file changed, 72 insertions(+), 13 deletions(-) diff --git a/doc/contributi