Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-18 Thread Thompson, David
On Tue, Aug 18, 2015 at 11:52 AM, Ludovic Courtès wrote: > "Thompson, David" skribis: > >> +(define (regular-file? file-name) >> + "Return #t if FILE-NAME is a regular file." >> + (eq? (stat:type (stat file-name)) 'regular)) > > I see you moved this procedure to (gnu build file-systems), which

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-18 Thread Ludovic Courtès
"Thompson, David" skribis: > +(define (regular-file? file-name) > + "Return #t if FILE-NAME is a regular file." > + (eq? (stat:type (stat file-name)) 'regular)) I see you moved this procedure to (gnu build file-systems), which is reasonable. I wonder if it should use ‘lstat’ instead of ‘stat’

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-08 Thread Thompson, David
On Sat, Aug 1, 2015 at 3:17 PM, David Thompson wrote: > As I was working on my container implementation I noticed that > 'mount-file-system' doesn't support bind mounting regular files because > it assumes that all mount points are directories. This patch fixes > that. I pushed this. - Dave

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-07 Thread Alex Kost
Thompson, David (2015-08-06 15:22 +0300) wrote: > On Mon, Aug 3, 2015 at 8:47 AM, Alex Kost wrote: >> Thompson, David (2015-08-02 15:51 +0300) wrote: >> >>> Ah, of course, I forgot about something: This patch triggers a >>> rebuild of *everything* now! I guess it should be applied to >>> core-u

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-06 Thread Thompson, David
On Mon, Aug 3, 2015 at 8:47 AM, Alex Kost wrote: > Thompson, David (2015-08-02 15:51 +0300) wrote: > >> Ah, of course, I forgot about something: This patch triggers a >> rebuild of *everything* now! I guess it should be applied to >> core-updates. Or, the first patch I submitted can be applied

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-03 Thread Alex Kost
Thompson, David (2015-08-02 15:51 +0300) wrote: > On Sun, Aug 2, 2015 at 8:43 AM, Thompson, David > wrote: >> On Sun, Aug 2, 2015 at 8:10 AM, Alex Kost wrote: >>> David Thompson (2015-08-01 22:17 +0300) wrote: >>> diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm ind

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-02 Thread Andreas Enge
On Sun, Aug 02, 2015 at 08:51:46AM -0400, Thompson, David wrote: > Ah, of course, I forgot about something: This patch triggers a > rebuild of *everything* now! I guess it should be applied to > core-updates. I think it would be better to wait until hydra is done building the security updates Ma

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-02 Thread Thompson, David
On Sun, Aug 2, 2015 at 8:43 AM, Thompson, David wrote: > On Sun, Aug 2, 2015 at 8:10 AM, Alex Kost wrote: >> David Thompson (2015-08-01 22:17 +0300) wrote: >> >>> diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm >>> index c58d23c..f0d6f70 100644 >>> --- a/gnu/build/file-system

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-02 Thread Thompson, David
b2413bd06b1e769edfbe4d170de41398015a67d Mon Sep 17 00:00:00 2001 From: David Thompson Date: Sat, 1 Aug 2015 13:43:33 -0400 Subject: [PATCH] build: file-systems: Allow for bind mounting regular files. * guix/build/utils.scm (regular-file?): New procedure. * gnu/build/file-systems.scm (mount-file-system

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-02 Thread Alex Kost
David Thompson (2015-08-01 22:17 +0300) wrote: > diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm > index c58d23c..f0d6f70 100644 > --- a/gnu/build/file-systems.scm > +++ b/gnu/build/file-systems.scm > @@ -305,6 +305,10 @@ the following: > fsck code device) >

[PATCH] build: file-systems: Allow for bind mounting regular files.

2015-08-01 Thread David Thompson
0 2001 From: David Thompson Date: Sat, 1 Aug 2015 13:43:33 -0400 Subject: [PATCH] build: file-systems: Allow for bind mounting regular files. * gnu/build/file-systems.scm (regular-file?): New procedure. (mount-file-system): Create a regular file instead of a directory when bind mounting a regu