Re: [PATCH] add go@1.5

2016-07-13 Thread Ludovic Courtès
Leo Famulari skribis: > On Sun, Jul 10, 2016 at 07:52:08PM -0400, Matthew Jordan wrote: >> * gnu/packages/golang.scm (go-1.5): New variable. > > I don't have the knowledge to comment on the Go specific stuff in this > package, but I have some more general comments. > > The tests 'runtime' and 'cm

Re: [PATCH] add go@1.5

2016-07-12 Thread Matthew Jordan
Hey Alex, In that case, I'll send the go@1.6 patch instead. No point fussing over go@1.5 then. Regards, --- Matthew Jordan

Re: [PATCH] add go@1.5

2016-07-12 Thread Alex Griffin
Matthew, I don't think we should consider minimum requirements, because Go's backward compatibility is really good. I have yet to come across a package that builds with an older compiler (post-1.0) but not a newer one. Instead I think we should consider which releases we actually need and which ar

Re: [PATCH] add go@1.5

2016-07-12 Thread Matthew Jordan
Good Day Alex, > Can I ask why even package go 1.5? Upstream has committed to making sure > all future compiler versions can bootstrap from go 1.4.x, so my thinking > is that we only need to package two versions, go 1.4 and the latest > version (1.6.2 at the moment). Or am I missing something? So

Re: [PATCH] add go@1.5

2016-07-11 Thread Alex Griffin
Can I ask why even package go 1.5? Upstream has committed to making sure all future compiler versions can bootstrap from go 1.4.x, so my thinking is that we only need to package two versions, go 1.4 and the latest version (1.6.2 at the moment). Or am I missing something? -- Alex Griffin On Sun,

Re: [PATCH] add go@1.5

2016-07-11 Thread Leo Famulari
On Sun, Jul 10, 2016 at 07:52:08PM -0400, Matthew Jordan wrote: > * gnu/packages/golang.scm (go-1.5): New variable. I don't have the knowledge to comment on the Go specific stuff in this package, but I have some more general comments. The tests 'runtime' and 'cmd/go' failed due to the default 3 m

Re: [PATCH] add go@1.5

2016-07-11 Thread Matthew Jordan
> I just used this build Syncthing — awesome! Thanks much appreciated, I actually started work on docker and peco packages myself. Keeping my eyes open for how go@1.5 changes will go. --- Matthew Jordan

Re: [PATCH] add go@1.5

2016-07-10 Thread Leo Famulari
On Sun, Jul 10, 2016 at 07:52:08PM -0400, Matthew Jordan wrote: > Good Day, > > Attached a patch to add go@1.5. I updated this one in a similar manner > to what was asked for go@1.4. However, let me know if any other changes > are required, or if I missed something. > > From 523d4ea6a97072831b9

[PATCH] add go@1.5

2016-07-10 Thread Matthew Jordan
Good Day, Attached a patch to add go@1.5. I updated this one in a similar manner to what was asked for go@1.4. However, let me know if any other changes are required, or if I missed something. >From 523d4ea6a97072831b91b7b7e7e3eb69a0b0ebca Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Thu