Re: [PATCH] WIP patches for the rust importer

2019-12-04 Thread Martin Becze
On 2019-12-04 02:40, Ivan Petkov wrote: > Hi Martin, > >> On Dec 2, 2019, at 3:10 PM, Martin Becze wrote: >> >> When you say source import of the transitive dependencies, do you >> mean >> that all the rust libs should just be source only or do you mean the >> top >> level package should have to

Re: [PATCH] WIP patches for the rust importer

2019-12-03 Thread Ivan Petkov
Hi Martin, > On Dec 2, 2019, at 3:10 PM, Martin Becze wrote: > > When you say source import of the transitive dependencies, do you mean > that all the rust libs should just be source only or do you mean the top > level package should have to declare all the transitive dependencies? All rust lib

Re: [PATCH] WIP patches for the rust importer

2019-12-02 Thread Martin Becze
On 2019-12-02 04:01, Ivan Petkov wrote: > Hi Martin! > >> On Dec 1, 2019, at 7:17 PM, Martin Becze wrote: >> >> oh to be more clear. Even with "#:skip-build? #t" on all the rust >> libs, >> things fail if I omit one optional dependency from somewhere. I'm >> just >> testing on hello-cli but hell

Re: [PATCH] WIP patches for the rust importer

2019-12-01 Thread Ivan Petkov
Hi Martin! > On Dec 1, 2019, at 7:17 PM, Martin Becze wrote: > > oh to be more clear. Even with "#:skip-build? #t" on all the rust libs, > things fail if I omit one optional dependency from somewhere. I'm just > testing on hello-cli but hello-cli inculdes clap which has alot of > optional deps.

Re: [PATCH] WIP patches for the rust importer

2019-12-01 Thread Martin Becze
On 2019-12-01 08:59, Efraim Flashner wrote: > On Fri, Nov 29, 2019 at 07:59:35AM -0800, Martin Becze wrote: >> On 2019-11-28 12:22, Efraim Flashner wrote: >> > On Wed, Nov 27, 2019 at 04:36:20PM -0800, mjbe...@riseup.net wrote: >> >> >> >> > I'd love to see what you have so far if you want to share

Re: [PATCH] WIP patches for the rust importer

2019-12-01 Thread Martin Becze
On 2019-12-01 08:54, Efraim Flashner wrote: > Also, we don't want Guix to think 1.2.3 can only be upgraded to 1.2.3.4 > and not to 1.2.4. I'm kinda lost on this one. Why would guix think 1.2.3 can only be upgraded to 1.2.3.4?

Re: [PATCH] WIP patches for the rust importer

2019-12-01 Thread Efraim Flashner
On Fri, Nov 29, 2019 at 07:59:35AM -0800, Martin Becze wrote: > On 2019-11-28 12:22, Efraim Flashner wrote: > > On Wed, Nov 27, 2019 at 04:36:20PM -0800, mjbe...@riseup.net wrote: > >> > >> > I'd love to see what you have so far if you want to share > >> > >> Okie Dokie, I posted it and cc'd ya. >

Re: [PATCH] WIP patches for the rust importer

2019-12-01 Thread Efraim Flashner
On Fri, Nov 29, 2019 at 04:59:31AM -0800, Martin Becze wrote: > On 2019-11-28 12:22, Efraim Flashner wrote: > > I'll take a look at it in a minute. I figured with the versioned > > requirements we would always want to be specific in version numbers for > > crate dependents so I figured it made sens

Re: [PATCH] WIP patches for the rust importer

2019-11-29 Thread Martin Becze
On 2019-11-28 12:22, Efraim Flashner wrote: > I'll take a look at it in a minute. I figured with the versioned > requirements we would always want to be specific in version numbers for > crate dependents so I figured it made sense. Also, if we did want to > provide an unversioned '-latest' version

Re: [PATCH] WIP patches for the rust importer

2019-11-28 Thread Efraim Flashner
On Wed, Nov 27, 2019 at 04:36:20PM -0800, mjbe...@riseup.net wrote: > > > I'd love to see what you have so far if you want to share > > Okie Dokie, I posted it and cc'd ya. > > Also I took a look at your patches. > 0001-import-crate-Don-t-include-optional-dependencies.patch should work > just fi

Re: [PATCH] WIP patches for the rust importer

2019-11-27 Thread mjbecze
> I'd love to see what you have so far if you want to share Okie Dokie, I posted it and cc'd ya. Also I took a look at your patches. 0001-import-crate-Don-t-include-optional-dependencies.patch should work just fine with my patch. But 0003-import-crate-Honor-versioned-dependencies-when-impor.pat

Re: [PATCH] WIP patches for the rust importer

2019-11-27 Thread Efraim Flashner
On November 27, 2019 8:06:43 PM UTC, mjbe...@riseup.net wrote: >Hi Efraim, > >> Unfortunately, this also breaks the recursive crate importer. I'm >going >> to continue working on it, but I could use some help getting the >> recursive aspect of it working. > >I recently rewrote the recusive crate

Re: [PATCH] WIP patches for the rust importer

2019-11-27 Thread mjbecze
Hi Efraim, > Unfortunately, this also breaks the recursive crate importer. I'm going > to continue working on it, but I could use some help getting the > recursive aspect of it working. I recently rewrote the recusive crate importer to use semantic versioning. I'll get a patch in later today. I'l

[PATCH] WIP patches for the rust importer

2019-11-26 Thread Efraim Flashner
Attached are two patches. The first one searches through the listed dependencies and removes the ones that are marked as optional. This (potentially) decreases the size of each crate and the number of dependencies. Before: (package (name "rust-serde") (version "1.0.103") (source (origin