On 2015-08-18 13:51, l...@gnu.org wrote:
Daniel Pimentel skribis:
From 96bed3aa54bc87ff9434b3c0d2f15572bb62fe80 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel
Date: Thu, 6 Aug 2015 11:12:54 -0300
Subject: [PATCH] gnu: Add Rage player.
* gnu/packages/enlightenment.scm: Add Rage.
Applied. I
Daniel Pimentel skribis:
> From 96bed3aa54bc87ff9434b3c0d2f15572bb62fe80 Mon Sep 17 00:00:00 2001
> From: Daniel Pimentel
> Date: Thu, 6 Aug 2015 11:12:54 -0300
> Subject: [PATCH] gnu: Add Rage player.
>
> * gnu/packages/enlightenment.scm: Add Rage.
Applied. I changed the URL to ‘https’ (this
On 2015-08-06 11:24, Ricardo Wurmus wrote:
Thanks for the updated patch!
* gnu/packages/enlightenment.scm: Add Rage.
This should really be:
* gnu/packages/enlightenment.scm (rage): New variable.
Other than that I have no important objections. I think this looks
ugly
and could be impr
Thanks for the updated patch!
> * gnu/packages/enlightenment.scm: Add Rage.
This should really be:
* gnu/packages/enlightenment.scm (rage): New variable.
Other than that I have no important objections. I think this looks ugly
and could be improved, but I don’t think it’s very important:
>
On 2015-08-05 11:35, Daniel Pimentel wrote:
On 2015-08-05 11:31, Ricardo Wurmus wrote:
Thanks Ricardo,
I did the corrections using emacs editor and I did commit based on
logs
(see git log). It's right now?
The new patch you just sent is only the latest commit. Could you
please
squash your
On 2015-08-05 11:31, Ricardo Wurmus wrote:
Thanks Ricardo,
I did the corrections using emacs editor and I did commit based on
logs
(see git log). It's right now?
The new patch you just sent is only the latest commit. Could you
please
squash your commits so that we get *one* patch only ins
> Thanks Ricardo,
>
> I did the corrections using emacs editor and I did commit based on logs
> (see git log). It's right now?
The new patch you just sent is only the latest commit. Could you please
squash your commits so that we get *one* patch only instead of multiple
patches that are to be ap
On 2015-08-05 11:11, Ricardo Wurmus wrote:
Hi Daniel,
unfortunately, the commit message is still not correct. It’s all on
one
line and “gnu: enlightenment:” should be “gnu:” instead. If you use
“git commit” without “-m” you can edit the message in your default
editor (configurable by setting
Hi Daniel,
unfortunately, the commit message is still not correct. It’s all on one
line and “gnu: enlightenment:” should be “gnu:” instead. If you use
“git commit” without “-m” you can edit the message in your default
editor (configurable by setting the EDITOR variable).
> +(define-public rage
On 2015-08-05 10:59, Thompson, David wrote:
On Wed, Aug 5, 2015 at 9:38 AM, Daniel Pimentel
wrote:
Patch that Add Rage player to enlightenment.scm.
This is the third thread about this. In the future, could you keep
the discussion in a single thread?
Thanks for your contribution!
- Dave
I'
On Wed, Aug 5, 2015 at 9:38 AM, Daniel Pimentel wrote:
> Patch that Add Rage player to enlightenment.scm.
This is the third thread about this. In the future, could you keep
the discussion in a single thread?
Thanks for your contribution!
- Dave
Patch that Add Rage player to enlightenment.scm.
Thanks,
--
Daniel Pimentel (d4n1 3:)From 6219eee540bc2015f2a8eb8d397488dfef76a3c4 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel
Date: Wed, 5 Aug 2015 10:35:11 -0300
Subject: [PATCH 3/3] gnu: enlightenment: Add Rage player *
gnu/packages/enlight
12 matches
Mail list logo
