Re: [PATCH] Create INDEX.LIST; Was: Fix references in jar manifests

2018-05-06 Thread Danny Milosavljevic
Hi Chris, On Mon, 02 Apr 2018 00:12:42 +0200 Chris Marusich wrote: > Thank you for writing a patch! It looks good to me. We will need to > apply this to the core-updates branch, right? I think that changes to > the ant-build-system will cause all packages that use it to be rebuilt. I've push

Re: [PATCH] Create INDEX.LIST; Was: Fix references in jar manifests

2018-04-18 Thread Danny Milosavljevic
Hi Chris, On Mon, 02 Apr 2018 00:12:42 +0200 Chris Marusich wrote: > Is that the only reason? My understanding is that we want to generate > the JAR indices not only (1) to ensure that grafting will work properly, > but also (2) to ensure that the reference scanner will find all the > store pat

Re: [PATCH] Create INDEX.LIST; Was: Fix references in jar manifests

2018-04-01 Thread Chris Marusich
Hi Danny, Thank you for writing a patch! It looks good to me. We will need to apply this to the core-updates branch, right? I think that changes to the ant-build-system will cause all packages that use it to be rebuilt. Danny Milosavljevic writes: > +(define* (generate-jar-indices #:key outp

[PATCH] Create INDEX.LIST; Was: Fix references in jar manifests

2018-03-25 Thread Danny Milosavljevic
diff --git a/guix/build/ant-build-system.scm b/guix/build/ant-build-system.scm index 6ce813a00..d09062625 100644 --- a/guix/build/ant-build-system.scm +++ b/guix/build/ant-build-system.scm @@ -172,6 +172,18 @@ to the default GNU unpack strategy." #:allow-other-keys) (zero? (appl