Re: [PATCH] Add thinkfan.

2016-05-11 Thread Ludovic Courtès
Nicolas Goaziou skribis: > From f6e8845b46cd469a2e9a8540879436671944c87e Mon Sep 17 00:00:00 2001 > From: Nicolas Goaziou > Date: Tue, 10 May 2016 21:20:49 +0200 > Subject: [PATCH] gnu: thinkfan: Fix daemon path in init scripts. > > * gnu/packages/linux.scm (thinkfan): Fix daemon path in init sc

Re: [PATCH] Add thinkfan.

2016-05-10 Thread Nicolas Goaziou
Hello, l...@gnu.org (Ludovic Courtès) writes: > Nicolas Goaziou skribis: >> I realize there are hard-coded paths in init scripts. Would it make >> sense to patch them so as to refer to `thinkfan' in store instead of >> "/usr/sbin/thinkfan"? > > Yes, I think so. Here's the patch, then. Regards

Re: [PATCH] Add thinkfan.

2016-05-09 Thread Ludovic Courtès
Hi! Nicolas Goaziou skribis: > Leo Famulari writes: > >> On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote: >>> Hello, >>> >>> Leo Famulari writes: >>> >>> > Looks good! But I noticed they *just* released a new version. Can you >>> > take a look and submit a patch with that ver

Re: [PATCH] Add thinkfan.

2016-05-07 Thread Nicolas Goaziou
Hello, Leo Famulari writes: > On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote: >> Hello, >> >> Leo Famulari writes: >> >> > Looks good! But I noticed they *just* released a new version. Can you >> > take a look and submit a patch with that version if it works for you? >> >> H

Re: [PATCH] Add thinkfan.

2016-05-06 Thread Leo Famulari
On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote: > Hello, > > Leo Famulari writes: > > > Looks good! But I noticed they *just* released a new version. Can you > > take a look and submit a patch with that version if it works for you? > > Here it is. > * gnu/packages/linux.scm (t

Re: [PATCH] Add thinkfan.

2016-05-06 Thread Nicolas Goaziou
Hello, Leo Famulari writes: > Looks good! But I noticed they *just* released a new version. Can you > take a look and submit a patch with that version if it works for you? Here it is. Regards, -- Nicolas Goaziou0x80A93738 >From 9c82df26841b28

Re: [PATCH] Add thinkfan.

2016-05-06 Thread Leo Famulari
On Wed, May 04, 2016 at 12:12:48AM +0200, Nicolas Goaziou wrote: > Leo Famulari writes: > > Also, can you add a phase that installs the "rcscripts"? They will be > > useful for Guix users on foreign distros. > > Done. > > > I'm not sure where to install them. Since they will probably have to be

Re: [PATCH] Add thinkfan.

2016-05-03 Thread Nicolas Goaziou
Hello, Leo Famulari writes: > Can you add a brief comment explaining this flag? Done. > Also, can you add a phase that installs the "rcscripts"? They will be > useful for Guix users on foreign distros. Done. > I'm not sure where to install them. Since they will probably have to be > copied o

Re: [PATCH] Add thinkfan.

2016-05-01 Thread Kei Yamashita
On Sun, 1 May 2016 17:14:18 -0400 Leo Famulari wrote: > On Sun, May 01, 2016 at 01:05:59AM +0200, Nicolas Goaziou wrote: > > * gnu/packages/linux.scm (thinkfan): New variable. > > Thanks! > > > +(arguments > > + `(#:tests? #f ;no test target > > + #:configur

Re: [PATCH] Add thinkfan.

2016-05-01 Thread Leo Famulari
On Sun, May 01, 2016 at 01:05:59AM +0200, Nicolas Goaziou wrote: > * gnu/packages/linux.scm (thinkfan): New variable. Thanks! > +(arguments > + `(#:tests? #f ;no test target > + #:configure-flags > + `("-DUSE_ATASMART:BOOL=ON"))) Can you add a brief comme

[PATCH] Add thinkfan.

2016-04-30 Thread Nicolas Goaziou
Hello, I'd like to submit the following patch for inclusion. There are a few caveats 1. It has to be run as root. 2. There is no default configuration since it is hardware-dependant, and it will not run without one. 3. It requires to load a kernel module with a specific option, namely: