Re: [PATCH] Add msgpack

2016-06-25 Thread Lukas Gradl
Leo Famulari writes: > On Fri, Jun 17, 2016 at 10:13:28AM -0500, Lukas Gradl wrote: >> Also, is it OK to do things like that in a snippet as in the attached >> patch? > >> * gnu/packages/serialization.scm (msgpack): New variable. > > I think it's fine and I pushed as d1ef573de. If we need to chan

Re: [PATCH] Add msgpack

2016-06-25 Thread Leo Famulari
On Fri, Jun 17, 2016 at 10:13:28AM -0500, Lukas Gradl wrote: > Also, is it OK to do things like that in a snippet as in the attached > patch? > * gnu/packages/serialization.scm (msgpack): New variable. I think it's fine and I pushed as d1ef573de. If we need to change it for libring, we'll do that

Re: [PATCH] Add msgpack

2016-06-21 Thread Lukas Gradl
Thank you for looking at this! Efraim Flashner writes: > On Tue, Jun 21, 2016 at 10:59:06AM -0500, Lukas Gradl wrote: >> Leo Famulari writes: >> >> > I'm curious — how close are you to a Ring package definition? >> >> There are some more dependencies that might be needed, that I noticed >>

Re: [PATCH] Add msgpack

2016-06-21 Thread Lukas Gradl
Lukas Gradl writes: > As I said I will post two patches later (pjproject & libring). Any help > on those or some of the missing inputs is of course greatly appreciated! Here they are! pjproject still fails to build one of its components (pjmedia) because of a missing include (resamplesubs.h).

Re: [PATCH] Add msgpack

2016-06-21 Thread Efraim Flashner
On Tue, Jun 21, 2016 at 10:59:06AM -0500, Lukas Gradl wrote: > Leo Famulari writes: > > > I'm curious — how close are you to a Ring package definition? > > > According to > https://tuleap.ring.cx/plugins/mediawiki/wiki/ring/index.php/Build_Instructions, > Ring is divided into three Layers: > *

Re: [PATCH] Add msgpack

2016-06-21 Thread Leo Famulari
On Tue, Jun 21, 2016 at 08:55:45AM -0500, Lukas Gradl wrote: > Leo Famulari writes: > > I'm curious — how close are you to a Ring package definition? > > Yes, packaging Ring is taking longer than I expected (on my side that > is). I will send a detailed update within the next two hours. I didn'

Re: [PATCH] Add msgpack

2016-06-21 Thread Lukas Gradl
Leo Famulari writes: > I'm curious — how close are you to a Ring package definition? According to https://tuleap.ring.cx/plugins/mediawiki/wiki/ring/index.php/Build_Instructions, Ring is divided into three Layers: * Libring (or ring-daemon) * LibringClient * Clints I have a work-in-progress

Re: [PATCH] Add msgpack

2016-06-21 Thread Lukas Gradl
Hi, l...@gnu.org (Ludovic Courtès) writes: > Hello! > > Sorry for the late reply, but… > > Lukas Gradl skribis: > >> All the files that do get installed in the output path of >> msgpack in the store do not contain the hash part of the store-path of >> zlib. They only refer to zlib by name. > >

Re: [PATCH] Add msgpack

2016-06-21 Thread Ludovic Courtès
Hello! Lukas Gradl skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> Hello! >> >> Sorry for the late reply, but… >> >> Lukas Gradl skribis: >> >>> All the files that do get installed in the output path of >>> msgpack in the store do not contain the hash part of the store-path of >>> zlib.

Re: [PATCH] Add msgpack

2016-06-21 Thread Lukas Gradl
Leo Famulari writes: > On Sat, Jun 18, 2016 at 10:44:16PM -0500, Lukas Gradl wrote: >> Lukas Gradl writes: >> >> > So the flags -I, -L, -l for zlib are all there for both dynamic and >> > static linking. But still no store reference. >> >> I think the reason why there is no reference is that

Re: [PATCH] Add msgpack

2016-06-21 Thread Ludovic Courtès
Hello! Sorry for the late reply, but… Lukas Gradl skribis: > All the files that do get installed in the output path of > msgpack in the store do not contain the hash part of the store-path of > zlib. They only refer to zlib by name. What kind of files are these, and how do they refer to zlib

Re: [PATCH] Add msgpack

2016-06-20 Thread Leo Famulari
On Sat, Jun 18, 2016 at 10:44:16PM -0500, Lukas Gradl wrote: > Lukas Gradl writes: > > > So the flags -I, -L, -l for zlib are all there for both dynamic and > > static linking. But still no store reference. > > I think the reason why there is no reference is that msgpack uses > zbuffer only for

Re: [PATCH] Add msgpack

2016-06-18 Thread Lukas Gradl
Lukas Gradl writes: > So the flags -I, -L, -l for zlib are all there for both dynamic and > static linking. But still no store reference. I think the reason why there is no reference is that msgpack uses zbuffer only for tests. Before compilation, the file only references the name "zlib" and d

Re: [PATCH] Add msgpack

2016-06-17 Thread Lukas Gradl
Hi, Leo Famulari writes: > On Mon, Jun 13, 2016 at 12:58:52PM -0400, Leo Famulari wrote: >> On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote: >> > Oh, that is true. I searched around, but I could not find anything >> > about zbuffer.h[pp]. I am not sure what it is used for. FWIW,

Re: [PATCH] Add msgpack

2016-06-13 Thread Leo Famulari
On Mon, Jun 13, 2016 at 12:58:52PM -0400, Leo Famulari wrote: > On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote: > > Oh, that is true. I searched around, but I could not find anything > > about zbuffer.h[pp]. I am not sure what it is used for. FWIW, it is > > only referenced in src/M

Re: [PATCH] Add msgpack

2016-06-13 Thread Leo Famulari
On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote: > Oh, that is true. I searched around, but I could not find anything > about zbuffer.h[pp]. I am not sure what it is used for. FWIW, it is > only referenced in src/Makefile, src/Makefile.in, src/Makefile.am > CMakeLists.txt and in the

Re: [PATCH] Add msgpack

2016-06-11 Thread Lukas Gradl
Leo Famulari writes: > On Sat, Jun 11, 2016 at 06:56:38PM -0500, Lukas Gradl wrote: >> It seems that zlib is only required for tests. In README and README.md >> zlib is never mentioned among the dependencies, which also supports >> that it is only needed for tests. I was not aware of that befo

Re: [PATCH] Add msgpack

2016-06-11 Thread Leo Famulari
On Sat, Jun 11, 2016 at 06:56:38PM -0500, Lukas Gradl wrote: > It seems that zlib is only required for tests. In README and README.md > zlib is never mentioned among the dependencies, which also supports > that it is only needed for tests. I was not aware of that before (Shame > on me). Is zlib

Re: [PATCH] Add msgpack

2016-06-11 Thread Lukas Gradl
Hi, I am sorry for the long silence, this week was busy and I did not find a lot of time to look into this. My apologies for that! Leo Famulari writes: > On Mon, Jun 06, 2016 at 10:07:37AM -0400, Leo Famulari wrote: >> On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote: >> > * gnu/pa

Re: [PATCH] Add msgpack

2016-06-10 Thread Leo Famulari
On Mon, Jun 06, 2016 at 10:07:37AM -0400, Leo Famulari wrote: > On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote: > > * gnu/packages/serialization.scm (msgpack): New variable. > > > +(inputs > > + `(("zlib" ,zlib))) > > I noticed that the output does not refer to zlib: > > $ g

Re: [PATCH] Add msgpack

2016-06-06 Thread Leo Famulari
On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote: > * gnu/packages/serialization.scm (msgpack): New variable. > +(inputs > + `(("zlib" ,zlib))) I noticed that the output does not refer to zlib: $ guix gc --references $(./pre-inst-env guix build msgpack) /gnu/store/8m00x5x8ykma

Re: [PATCH] Add msgpack

2016-06-02 Thread Lukas Gradl
Hi, Thank you for your review! Efraim Flashner writes: > On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote: >> >> Hello Guix, >> >> Attached is a patch for the c/c++ version of msgpack. This is a >> dependency of the Ring. >> >> Thank you! >> > >> From 25eef52146bc84e83d90e429a0

Re: [PATCH] Add msgpack

2016-05-31 Thread Efraim Flashner
On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote: > > Hello Guix, > > Attached is a patch for the c/c++ version of msgpack. This is a > dependency of the Ring. > > Thank you! > > From 25eef52146bc84e83d90e429a0a2a5ca607280bc Mon Sep 17 00:00:00 2001 > From: Lukas Gradl > Date: Mon

Re: [PATCH] Add msgpack

2016-05-31 Thread Leo Famulari
On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote: > * gnu/packages/serialization.scm (msgpack): New variable. LGTM. Waiting on a response to some questions about the 'googletest' dependency.

[PATCH] Add msgpack

2016-05-30 Thread Lukas Gradl
Hello Guix, Attached is a patch for the c/c++ version of msgpack. This is a dependency of the Ring. Thank you! >From 25eef52146bc84e83d90e429a0a2a5ca607280bc Mon Sep 17 00:00:00 2001 From: Lukas Gradl Date: Mon, 30 May 2016 15:46:29 -0500 Subject: [PATCH] gnu: serialization: Add msgpack. * g