Re: [PATCH]: gnu: Add HISAT.

2015-02-12 Thread Ludovic Courtès
Ricardo Wurmus skribis: > This may not even be necessary; the developer replied with a hint and > attached is a patch that should fix the build on non-x86_64 > architectures. It builds fine locally with > > ./pre-inst-env guix build --system=i686-linux hisat > > Does this look okay? [...]

Re: [PATCH]: gnu: Add HISAT.

2015-02-12 Thread Andreas Enge
On Thu, Feb 12, 2015 at 12:04:22PM +0100, Ricardo Wurmus wrote: > This may not even be necessary; the developer replied with a hint and > attached is a patch that should fix the build on non-x86_64 > architectures. It builds fine locally with > ./pre-inst-env guix build --system=i686-linux his

Re: [PATCH]: gnu: Add HISAT.

2015-02-12 Thread Ricardo Wurmus
Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> I wrote the author an email to ask whether this can be fixed upstream >> for other architectures than x86_64. Until then should I just declare >> x86_64 as the only supported architecture? > > Probably yes, with a comment pointing to this d

Re: [PATCH]: gnu: Add HISAT.

2015-02-11 Thread Ludovic Courtès
Ricardo Wurmus skribis: > I wrote the author an email to ask whether this can be fixed upstream > for other architectures than x86_64. Until then should I just declare > x86_64 as the only supported architecture? Probably yes, with a comment pointing to this discussion and possibly the one with

Re: [PATCH]: gnu: Add HISAT.

2015-02-11 Thread Andreas Enge
On Wed, Feb 11, 2015 at 05:14:13PM +0100, Ricardo Wurmus wrote: > A recurring error is apparently related to embedded assembly > instructions: > I wrote the author an email to ask whether this can be fixed upstream > for other architectures than x86_64. Until then should I just declare > x86_64 as

Re: [PATCH]: gnu: Add HISAT.

2015-02-11 Thread Ricardo Wurmus
Andreas Enge writes: > the package fails to build on i686: >http://hydra.gnu.org/build/247325 > Could you maybe have a look? Thanks for notifying me. A recurring error is apparently related to embedded assembly instructions: ~ ... bt2_idx.h: Assembler messages: bt2_idx.h:489: Error: in

Re: [PATCH]: gnu: Add HISAT.

2015-02-11 Thread Andreas Enge
Hello, the package fails to build on i686: http://hydra.gnu.org/build/247325 Could you maybe have a look? Andreas

Re: [PATCH]: gnu: Add HISAT.

2015-02-10 Thread Ludovic Courtès
Ricardo Wurmus skribis: > From 5696a8227d98d60d38f0ff19b40a21ccb13e53f1 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Mon, 9 Feb 2015 12:13:26 +0100 > Subject: [PATCH] gnu: Add HISAT. > > * gnu/packages/bioinformatics.scm (hisat): New variable. LGTM, thanks! Ludo’.

Re: [PATCH]: gnu: Add HISAT.

2015-02-10 Thread Ricardo Wurmus
referable to the long list. >> +(license license:gpl3))) > > GPLv3-only? You were right: it's GPLv3+. My apologies. >From 5696a8227d98d60d38f0ff19b40a21ccb13e53f1 Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Mon, 9 Feb 2015 12:13:26 +0100 Subject: [PA

Re: [PATCH]: gnu: Add HISAT.

2015-02-10 Thread Ricardo Wurmus
Ludovic Courtès writes: > If it’s possible to avoid the whole list using ‘find-files’ or > ‘scandir’, that would be nicer IMO. If it’s not, that’s fine. > >> +(license license:gpl3))) > > GPLv3-only? > > Thanks! > > Ludo’.

Re: [PATCH]: gnu: Add HISAT.

2015-02-09 Thread Ludovic Courtès
Ricardo Wurmus skribis: > From 305768bfef9bf4bc8d57828e27b8439dedd574bd Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Mon, 9 Feb 2015 12:13:26 +0100 > Subject: [PATCH] gnu: Add HISAT. > > * gnu/packages/bioinformatics.scm (hisat): New variable. Overall looks good t

[PATCH]: gnu: Add HISAT.

2015-02-09 Thread Ricardo Wurmus
rom 305768bfef9bf4bc8d57828e27b8439dedd574bd Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Mon, 9 Feb 2015 12:13:26 +0100 Subject: [PATCH] gnu: Add HISAT. * gnu/packages/bioinformatics.scm (hisat): New variable. --- gnu/packages/bioinformatics.scm | 77 - 1 file changed,