pelzflorian (Florian Pelz) wrote:
Could you send this diff to guix-patc...@gnu.org?
Here it is: https://issues.guix.gnu.org/72867
Regards,
Nigko
Hello Florian,
pelzflorian (Florian Pelz) wrote:
Still, when would your diff break someone else’s code?
Instead of answering this tough question I decided to make another
patch (see attachment) which is guaranteed not to break another's code:
- The patch adds 'follow-symlinks?' argument to 'c
rent-source-directory' is unrelated to symlinks and
'if' condition in 'absolute-dirname'. All Guile load paths I have seen before
are
absolute paths, and the second branch of 'if' is not executed for them.
Maybe we should leave 'absolute-dirname' alone, as well as
'current-source-directory',
and consider 'local-file' more closely.
Regards,
Nigko
ook? Isn't it a
separate
topic?
because current-source-directory is weird and inconsistent
It isn't. It simply does not follow symlinks by design.
Why does current-source-directory use syntax-source?
What can it use instead? Related syntaxes such as
'current-source-location' and 'current-filename' are all using
'syntax-source' under the hood.
Regards,
Nigko
Nigko Yerden wrote:
(dirname
(canonicalize-path
(string-append (current-source-directory) (current-filename
Sorry, this expression for source directory is wrong. The correct one:
(dirname
(canonicalize-path
(string-append (current-source-directory) "/"
#:recursive? #t
#:select? vcs-file?))
What do you think?
Regards,
Nigko
[1] https://guix.gnu.org/en/manual/devel/en/html_node/Creating-a-Channel.html
[2]
https://gitlab.com/anigko/test-channel/-/blob/ef07ce6904c16533f0fc21fda74216ce0a38bafd/.guix/modules/test-r
_PATH, maybe first we need
to send a patch to Guile and then correct the cookbook accordingly?
Regards,
Nigko
rivation-outputs' and
'derivation->output-paths' procedures) supposes that 'drv' is a list of
derivation objects or .drv files, which leads to an error.
Regards,
Nigko
(guix gexp)
(guix store))
(define src (package-source test-repo))
(run-with-store (open-connection) (lower-object src))
So, perhaps this problem is not so thorough.
Regards,
Nigko
Hello Florian!
Here is my version of your diff in attachment. With this patch
'guix build test-repo' works for the main branch of test-repo-channel,
i.e. it seems to solve one problem (I'm sure that 'guix build guile@3.0.99-git'
works as well for the guile channel, but didn't check this explicitl
le?))
It seems to work even without macro wrapper.
Regards,
Nigko
[1] https://gitlab.com/anigko/test-channel.git
oad path, works like a charm.
Thus, this repository behaves exactly as does the main branch of [2].
Perhaps many systems (e.g. Guix on foreign distributions) indeed does not
have [1] in Guile load path, and thus recipe from the Cookbook works for them.
Regards,
Nigko
[1] ~/.config/guix/curr
.
I guess it needs no changes, or should we add a hint not to ..?
I think it needs some changes, a warning at least. Also I think that
keeping the package definition in additional nested directory like
'.guix/modules/guile/package.scm' is not so bad and can replace
a '.guix/modules/guile-package.scm' variant.
Regards,
Nigko
ect is not necessary a good thing. What I meant is that recipe
from cookbook does not work for Guix with GUILE_LOAD_PATH configured
as in freshly installed Guix System, nothing more.
Regards,
Nigko
pelzflorian (Florian Pelz) wrote:
Hello Nigko. Do I understand correctly: Your grievance is the
file from 'main' branch, the
'package.scm'
file contains three modifications:
1.
(define-module (test-repo package)
2.
(define vcs-file?
;; Return true if the given file is under version control.
(or (git-predicate (dirname (dirname (dirname (current-source-directory)
(const #t)))
3.
(source (local-file "../../.." "test-repo-checkout"
#:recursive? #t
#:select? vcs-file?))
Thus defined repository ensures that 'test-repo' package is built without
errors on
systems with and without properly configured GUILE_LOAD_PATH.
Regards,
Nigko
[1] https://gitlab.com/anigko/test-channel.git
[2]
https://guix.gnu.org/en/cookbook/en/html_node/The-Repository-as-a-Channel.html
processing occurred?
Regards,
Nigko
s #t,
like in https://issues.guix.gnu.org/70341#2 ?
Best Regards,
Nigko Yerden
Hello Guix!
Almost three months ago I sent a patch https://issues.guix.gnu.org/64345
introducing a package reduce-csl, a computer algebra system Reduce
similar to Maxima. It was successfully built on major architectures and
acquired a 'green' status, waiting for a review. But then some dramati
Hello Guix!
The ALPS project* (Algorithms and Libraries for Physics Simulations)
https://web.archive.org/web/20210508050408/https://alps.comp-phys.org/mediawiki/index.php/Main_Page
is an open source effort aiming at providing simulation codes for
strongly correlated quantum mechanical systems
19 matches
Mail list logo