Hi Leo,
Leo Prikler skribis:
> From fae10039a5c875e48ca2ae8087bab702b69ac0b0 Mon Sep 17 00:00:00 2001
> From: Leo Prikler
> Date: Sat, 23 Nov 2019 19:51:15 +0100
> Subject: [PATCH 1/2] services: Add polkit-wheel-service.
>
> * gnu/services/desktop.scm: (polkit-wheel): New variable.
> (polkit-wh
On Wed, 27 Nov 2019 12:43:19 +0100
zimoun wrote:
> Hi Jan,
Hello,
> If you use Emacs, you can open Debbugs with: C-u M-x debbugs-gnu then
> RET guix-patches n y
> Then M-x debbugs-gnu-bugs RET 38211 RET
> So far so good.
> Select the patch set.
> Then M-x shell-command-on-region RET cd /path/to/y
Christopher Baines writes:
> diff --git a/src/schema.sql b/src/schema.sql
> index a9e4a6a..b84b231 100644
> --- a/src/schema.sql
> +++ b/src/schema.sql
> @@ -64,6 +64,18 @@ CREATE TABLE Builds (
>FOREIGN KEY (evaluation) REFERENCES Evaluations (id)
> );
>
> +CREATE TABLE Events (
> + id
Christopher Baines writes:
> * src/cuirass/base.scm (process-specs): Record the creation of new
> evaluations as events.
> * src/cuirass/database.scm (db-set-evaluation-done): Record when evaluations
> finish as an event.
> * src/cuirass/http.scm (url-handler): Add a new /api/evaluation-events pa
Hi Christopher,
This is a small review :)
Christopher Baines writes:
> Add a table to store events, which have a type and a JSON blob. These can be
> used to record changes, this commit inserts events when new builds are
> created, and when the status of builds change.
Why is it a JSON blob?
We don't have a wiki.
For something short, maybe we can add it to the manual instead of a
dedicated cookbook chapter.
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature
Christopher Baines writes:
> Following up on this again, I've now sent a couple of updated
> patches. Not much about the code has changed, I fixed a typo, added
> better error handling to sending events, and added changelog entries to
> the commit messages.
Hi Christopher,
Thank you for this wo