[PATCH 07/12] gnu: ncurses: support mingw.

2016-08-17 Thread Jan Nieuwenhuizen
From: Mark H Weaver * gnu/packages/patches/ncurses-mingw.patch: New file. * gnu-system.am (dist_patch_DATA): Add it. * gnu/packages/ncurses.scm (ncurses): Support MinGW. Co-Authored-By: Jan Nieuwenhuizen --- gnu/packages/ncurses.scm | 234 ++- 1 file

[PATCH 01/12] gnu: Add gcc-cross-x86_64 packages for testing.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/cross-base.scm: (xgcc-sans-libc-x86_64-linux-gnu, xgcc-x86_64-linux-gnu): New variables. --- gnu/packages/cross-base.scm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index 3bd30fd..cb53668 100644 --- a/gnu

[PATCH 10/12] gnu: ncurses: build mingw with libtool.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/ncurses.scm (ncurses)[MINGW]: Build with libtool, as recommended; enables dlopen'ing. --- gnu/packages/ncurses.scm | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/gnu/packages/ncurses.scm b/gnu/packages/ncurses.scm index 4d26fde

[PATCH 12/12] gnu: guile-2.0: support mingw.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/guile.scm (guile-2.0): Support MinGW. --- gnu/packages/guile.scm | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index f26cc22..ee84c05 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm

[PATCH 03/12] gnu: cross-build: i686-w64-mingw32: new cross target.

2016-08-17 Thread Jan Nieuwenhuizen
* guix/utils.scm (mingw-target?): New function. * gnu/packages/cross-base.scm (cross-gcc-snippet): New function for MinGW. (cross-gcc): Use it. (cross-gcc-arguments, cross-gcc-patches, cross-gcc): Support MinGW. (native-libc, cross-newlib?): New functions. (cross-libc): Use cross-newlib? to support

[PATCH 09/12] gnu: libtool: support cross-libtool mingw.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/patches/libtool-mingw.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/autotools.scm (libtool): Support cross-libtool for MinGW. --- gnu/packages/autotools.scm | 3 ++- gnu/packages/patches/libtool-mingw.patch | 28

[PATCH 08/12] gnu: cross-base: Add cross-libtool.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/cross-base.scm (cross-libtool): New function. --- gnu/packages/cross-base.scm | 48 + 1 file changed, 48 insertions(+) diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index 996e392..f11e8c1 100644 --- a/gnu/packages

[PATCH 11/12] gnu: readline: support mingw.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/patches/readline-6.3-mingw.patch: New file. * gnu-system.am (dist_patch_DATA): Add it. * gnu/packages/readline.scm (readline): Support MinGW. --- gnu/packages/readline.scm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gnu/packages/readline.scm b/

[PATCH 06/12] gnu: gmp: build shared library for mingw.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/multiprecision.scm (gmp)[MINGW]: Use --enable-shared. --- gnu/packages/multiprecision.scm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/multiprecision.scm b/gnu/packages/multiprecision.scm index 46540be..0084ca1 100644 --- a/gnu/packages/mu

[PATCH 02/12] gnu: Add mingw-w64.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/patches/gcc-4.9.3-mingw-gthr-default.patch, gnu/packages/patches/mingw-w64-5.0rc2-gcc-4.9.3.patch, gnu/packages/mingw.scm: New files. * gnu/local.mk (dist_patch_DATA): Add them. --- gnu/local.mk | 3 + gnu/packages/mingw.scm

[PATCH 05/12] gnu: libunistring: support mingw: propagate libiconv if needed.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/libunistring (libunistring): propagated-inputs: add libiconv-if-needed. Fixes unicode translation in MinGW. --- gnu/packages/libunistring.scm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/libunistring.scm b/gnu/packages/libunistring.scm inde

[PATCH 04/12] gnu: Add function libiconv-if-needed.

2016-08-17 Thread Jan Nieuwenhuizen
* gnu/packages/base.scm (libiconv-if-needed): New function. --- gnu/packages/base.scm | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index a476837..fe11a87 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.sc

MinGW guile.exe cross build patch series v10

2016-08-17 Thread Jan Nieuwenhuizen
Hi! Recap how to use these patches $ ./pre-inst-env guix build --target=i686-w64-mingw32 hello $ guix environment --ad-hoc wine -- wine /gnu/store/9sx5hhdlyk7b3xdv7120yn5742l9xj2p-hello-2.10/bin/hello.exe Hello, world! This series addresses the comments from Alex Kost and features s

Re: [PATCH 07/24] gnu: compression: Add snappy.

2016-08-17 Thread Leo Famulari
On Wed, Aug 17, 2016 at 09:20:42PM +0200, David Craven wrote: > Oh, that's embarrassing. I must have forgotten to change the hash and > guix cached the tarball. Is that possible? If the hash is matched in the store, the URL is not used, so you won't see an incorrect URL fail to match the hash. Th

Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.

2016-08-17 Thread David Craven
I'll withhold this patch pending further investigation. Thank you!

Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer.

2016-08-17 Thread David Craven
I'll withhold this patch for now pending further investigation... Thank you!

Re: [PATCH] gnu: gnome-maps: Update to 3.18.3.

2016-08-17 Thread ng0
Alex Griffin writes: > This patch updates GNOME Maps to 3.18.3, which changes the map tile > provider to Mapbox after Mapquest revoked GNOME's access. > > I tried updating straight to 3.20.2 (the latest), but there were some > issues I wasn't willing to investigate. https://mail.gnome.org/archiv

Re: [PATCH] gnu: libpsl: Update to 0.14.0.

2016-08-17 Thread Tobias Geerinckx-Rice
Andreas, On 04/08/16 10:09, Andreas Enge wrote: > I think you can push such trivial changes without asking on the list Oh, I absolutely agree, but then HACKING reads: Non-trivial patches should always be posted to guix-devel@gnu.org (trivial patches include fixing typos, etc.) Choosing typo

[PATCH] gnu: gnome-maps: Update to 3.18.3.

2016-08-17 Thread Alex Griffin
This patch updates GNOME Maps to 3.18.3, which changes the map tile provider to Mapbox after Mapquest revoked GNOME's access. I tried updating straight to 3.20.2 (the latest), but there were some issues I wasn't willing to investigate. -- Alex Griffin From 14ce2c74c39c4ec26353e28b1dcf2e89b74905ca

Re: [PATCH] gnu: Add interrobang.

2016-08-17 Thread ng0
ng0 writes: > ng0 writes: > >> This patch adds interrobang. It should function, but I don't have zsh >> configured here in GuixSD, so my old config does not work here, and the >> system default is up to testing by other people. > > To explain this noisy comment: > I have a special interrobang-zs

Re: [PATCH] gnu: Add interrobang.

2016-08-17 Thread ng0
ng0 writes: > This patch adds interrobang. It should function, but I don't have zsh > configured here in GuixSD, so my old config does not work here, and the > system default is up to testing by other people. To explain this noisy comment: I have a special interrobang-zsh-completion script which

Re: Hardening

2016-08-17 Thread ng0
Alex Vong writes: > Hi, > > Wow, this was long time ago. I've forgot this completely. > > Ricardo Wurmus writes: > >> Leo Famulari writes: >> >>> On Wed, Dec 30, 2015 at 05:06:30PM +0100, Ludovic Courtès wrote: Alex Vong skribis: > Yes, I grep for `fstack-protector-strong' in the gui

[PATCH] gnu: Add interrobang.

2016-08-17 Thread ng0
This patch adds interrobang. It should function, but I don't have zsh configured here in GuixSD, so my old config does not work here, and the system default is up to testing by other people. >From 91cc74e39a7ca001d24610f595fe6ce2cf38af0b Mon Sep 17 00:00:00 2001 From: ng0 Date: Wed, 17 Aug 2016 2

Re: [PATCH 07/24] gnu: compression: Add snappy.

2016-08-17 Thread David Craven
>> I don't believe you :-) > > Oh, that's embarrassing. I must have forgotten to change the hash and > guix cached the tarball. Is that possible? Sorry about that. I make many stupid mistakes, but I'm not a liar... ;-)

Re: [PATCH 07/24] gnu: compression: Add snappy.

2016-08-17 Thread David Craven
> I don't believe you :-) Oh, that's embarrassing. I must have forgotten to change the hash and guix cached the tarball. Is that possible?

Re: [PATCH 07/24] gnu: compression: Add snappy.

2016-08-17 Thread Alex Kost
David Craven (2016-08-17 11:30 +0300) wrote: >> Also there is a real release that shouldn't require autoreconf phase: >> >> Did you try using it? > > Just did, and requires running autoreconf too... I don't believe you

Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.

2016-08-17 Thread Alex Kost
Leo Famulari (2016-08-17 00:41 +0300) wrote: > On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote: >> gnu: Add python-lirc, python2-lirc. >> >> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables. > > Thanks, applied as 231313f76! Ahem, you both are fast: I was co

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

2016-08-17 Thread David Craven
> Is it possible to avoid propagating? Quoting the manual on the section on propagated-inputs: > For example this is necessary when a C/C++ library needs headers of another > library to compile, ... So the fact that the headers of networkmanager-qt include headers from network-manager, means th

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

2016-08-17 Thread Alex Kost
David Craven (2016-08-17 12:34 +0300) wrote: >> Also there should be a reason for propagating (probably written as a >> comment). Ideally it should be avoided. > > I added comments: > > (propagated-inputs > ; Headers contain #include and > ;#include >

Re: [PATCH 08/24] gnu: xorg: Add lndir.

2016-08-17 Thread Alex Kost
David Craven (2016-08-17 11:35 +0300) wrote: >> The patch looks good to me, except the indentation of this >> >> (string-append ...). I usually write 'source' fields like this: >> >>(source (origin >> (method url-fetch) >> (uri (string-append "mirror://xorg/individua

Re: [PATCH 1/1] Go: Update to 1.7

2016-08-17 Thread Petter
Hi Alex, Great, thank you! On 2016-08-17 17:54, Alex Griffin wrote: On Wed, Aug 17, 2016, at 04:34 AM, Petter wrote: Hi, Made an attempt to update my first package. Hope it's good! Hi Petter, Thanks for contributing! Your changes work for me, but it looks like your mail client mangled th

[PATCH] gnu: Add python-odfpy.

2016-08-17 Thread Marius Bakke
>From aa54aaee18b096780220f85a02b7e036458858a2 Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Wed, 17 Aug 2016 17:45:24 +0100 Subject: [PATCH] gnu: Add python-odfpy. * gnu/packages/python.scm (python-odfpy, python2-odfpy): New variables. --- gnu/packages/python.scm | 32 ++

[PATCH] gnu: bs1770gain: Update to 0.4.11.

2016-08-17 Thread Alex Griffin
This patch just updates bs1770gain to 0.4.11, which includes a number of bug fixes. -- Alex Griffin From c08d5616bdb579780d910429bd81ec7ec36491f3 Mon Sep 17 00:00:00 2001 From: Alex Griffin Date: Tue, 16 Aug 2016 13:58:07 -0500 Subject: [PATCH 1/2] gnu: bs1770gain: Update to 0.4.11. * gnu/packag

Re: [PATCH 00/13] KDE Frameworks Tier 2 packages and phonon/gpgmepp.

2016-08-17 Thread David Craven
Nope, tier 3 packages have quite a few inter-dependencies. There is currently only one tier 4 package. Quoting the website: "Tier 4 frameworks can be mostly ignored by application programmers; this tier consists of plugins acting behind the scenes to provide additional functionality or platform in

Re: [PATCH 00/13] KDE Frameworks Tier 2 packages and phonon/gpgmepp.

2016-08-17 Thread Andreas Enge
On Sat, Aug 13, 2016 at 02:19:18PM +0200, David Craven wrote: > kactivities-stats is also listed as a tier 2 package on the KDE Frameworks > website, but since kactivities (a tier 3 package) is a dependency, I'm putting > it with the tier 3 packages. Well, it would be a tier 4 package then, no? A

Re: [PATCH 1/1] Go: Update to 1.7

2016-08-17 Thread Alex Griffin
On Wed, Aug 17, 2016, at 04:34 AM, Petter wrote: > Hi, > > Made an attempt to update my first package. > > Hope it's good! Hi Petter, Thanks for contributing! Your changes work for me, but it looks like your mail client mangled the formatting of your patch. So I produced a good patch with your

Re: [PATCH] gnu: libftdi: Propagate the libusb input.

2016-08-17 Thread Andreas Enge
Hello, On Tue, Aug 16, 2016 at 08:09:52PM +0200, Danny Milosavljevic wrote: > gnu: libftdi: Propagate the libusb input. > * gnu/packages/libftdi.scm (libftdi): Modified. Rather: "Move libusb from native-inputs to inputs." > -(inputs > +(propagated-inputs Please add a quick comment why t

Re: [PATCH] gnu: Add re2.

2016-08-17 Thread Marius Bakke
Marius Bakke writes: > Leo Famulari writes: > >> On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >>> >>> I wasn't sure where to put this, so went with its own file. It does not >>> fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could >>> be renamed to regex.scm

Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer.

2016-08-17 Thread Eric Bavier
On 2016-08-17 06:14, David Craven wrote: Is boost propagated due to header references? The include files reference these headers: #include #include #include #include what is the reason for disabling runpath validation? I'm getting a bunch of these errors. The problem seems to be that /

Re: [PATCH] gnu: Add dlib.

2016-08-17 Thread Marius Bakke
Ben Woodcroft writes: > On 17/08/16 09:45, Leo Famulari wrote: >> On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote: >>> >>> On 17/08/16 06:47, Leo Famulari wrote: On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: > I initially made this package on a foreign distr

Re: Hardening

2016-08-17 Thread Alex Vong
Hi, Wow, this was long time ago. I've forgot this completely. Ricardo Wurmus writes: > Leo Famulari writes: > >> On Wed, Dec 30, 2015 at 05:06:30PM +0100, Ludovic Courtès wrote: >>> Alex Vong skribis: >>> > Yes, I grep for `fstack-protector-strong' in the guix code base and no >>> > matches a

Re: Our git just broke [PATCH]: gnu: Add stagit, adjust version-control.scm.

2016-08-17 Thread ng0
Hi, can someone comment on this patch if there are changes I need to make? ng0 writes: > Leo Famulari writes: > >> On Sat, Aug 13, 2016 at 10:41:59PM +1000, Ben Woodcroft wrote: >>> Hi, >>> >>> I cannot currently build git on the master branch. I bisected and got to >>> this commit. I had a q

Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer.

2016-08-17 Thread David Craven
> Is boost propagated due to header references? The include files reference these headers: #include #include #include #include > what is the reason for disabling runpath validation? I'm getting a bunch of these errors. The problem seems to be that /gnu/store/2g5xcc8hp16nfnf37449f3p492m8i03h

Re: QtHaveModule

2016-08-17 Thread 宋文武
David Craven writes: > Hi > >>> Hi, I just sent a patch to add 'QMAKEPATH' as search-path, which should >>> fix this issue. > >> Thank you! Yes this fixes the issue and is a lot cleaner than what I >> came up with... > > I sent a couple of patches to the mailing list that will require the > qt an

Re: [PATCH] gnu: Add minced.

2016-08-17 Thread Ben Woodcroft
On 16/08/16 22:34, Marius Bakke wrote: Ben Woodcroft writes: Hi Marius, Excellent to see others interested in packaging microbial bioinformatics tools. You may want to look here before packaging other microbio tools: https://github.com/MRC-CLIMB/guix-climb I'm currently working on upstre

Re: [PATCH] gnu: Add re2.

2016-08-17 Thread Marius Bakke
Leo Famulari writes: > On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >> >> I wasn't sure where to put this, so went with its own file. It does not >> fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could >> be renamed to regex.scm or similar. > > The patch look

Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory.

2016-08-17 Thread David Craven
> In general, we should stick to upstream packaging unless it is clearly > broken or there is a compelling reason to deviate. In this case, if an > application can't find , then it would seem to have a > buggy build system, and we should fix the problem there. The qt-gstreamer package doesn't bui

Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.

2016-08-17 Thread David Craven
> Might (setenv "QT_QPA_PLATFORM" "offscreen") also be enough? Interesting, that also fixes the problem, but causes a new one... * Start testing of KDualActionTest * Config: Using QtTest library 5.7.0, Qt 5.7.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.

Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory.

2016-08-17 Thread Mark H Weaver
David Craven writes: >> What is the reason for this change? Would it be appropriate to submit a >> bug report upstream to add this to their "make install"? > > The reason is because applications may contain #include , > but gstconfig.h was moved to the lib directory because it contains "platform

Re: [PATCH] gnu: Add libunique.

2016-08-17 Thread ng0
Leo Famulari writes: > On Mon, Aug 15, 2016 at 11:33:26PM +, ng0 wrote: >> Leo Famulari writes: >> > Is this package required by something else that we are working on? What >> > is the use case? >> >> (gnunet-gtk): >> >> (arguments >> `(#:configure-flags >> (li

Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info.

2016-08-17 Thread Mark H Weaver
David Craven writes: > * gnu/packages/gnome.scm (mobile-broadband-provider-info): New variable. The summary line to should be "gnu: Add mobile-broadband-provider-info." without the "gnome: ". By our conventions, starting a summary line with "gnu: gnome: " indicates a change to the 'gnome' packa

[PATCH 1/1] Go: Update to 1.7

2016-08-17 Thread Petter
Hi, Made an attempt to update my first package. Hope it's good! --- gnu/packages/golang.scm | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 09d962d..6e15cf6 100644 --- a/gnu/packages/golang.scm +++

Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info.

2016-08-17 Thread David Craven
> This same issue applies to the other patches in this patch set as well. > When adding new packages, our convention is simply to write "gnu: Add > ." :thumbs up:

Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory.

2016-08-17 Thread David Craven
> What is the reason for this change? Would it be appropriate to submit a > bug report upstream to add this to their "make install"? The reason is because applications may contain #include , but gstconfig.h was moved to the lib directory because it contains "platform specific information". What

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

2016-08-17 Thread David Craven
> Also there should be a reason for propagating (probably written as a > comment). Ideally it should be avoided. I added comments: (propagated-inputs ; Headers contain #include and ;#include `(("network-manager" ,network-manager))) (propagated-inp

Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory.

2016-08-17 Thread Mark H Weaver
David Craven writes: > * gnu/packages/gstreamer.scm (gstreamer)[arguments]: Add symlink-gstconfig.h > phase. What is the reason for this change? Would it be appropriate to submit a bug report upstream to add this to their "make install"? Mark > --- > gnu/packages/gstreamer.scm

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread David Craven
> That would be a massive refactoring - but can be done eventually. I don't think it would be too hard, most work can be done through applying a regex to the entire project and running the testsuite to find the cases where it didn't work. I did this on the python.scm file... So then I'll leave th

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread Danny Milosavljevic
On Wed, 17 Aug 2016 10:53:23 +0200 David Craven wrote: > Ah, I was thinking more about lgpl2.1+ and the sorts... So is it a > good idea to prefix all licenses in guix licenses itself (as Eric > mentioned), and be done with it? That would be a massive refactoring - but can be done eventually. I

Re: [PATCH 5/5] gnu: Add arduino-makefile.

2016-08-17 Thread Danny Milosavljevic
> Should this not point to /gnu/store/...-python-3...? If not, it could > probably be left alone, since any package built with it will presumably > have its shebangs patched. It's just that Python 3 is incompatible with Python 2 but the source code has no marker in the file - so patch-shebang wo

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread David Craven
> Expat causes a name collision. > > Also nmap, boost, cecill-c, freetype, imlib2, openldap2.0, openssl, ruby, > tcl/tk, vim, x11, zlib. > > Should there be new licenses it's a good guess it will be named like the > package it originated in. > > I would not advise removing the prefix. If anything

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread Danny Milosavljevic
On Wed, 17 Aug 2016 10:02:26 +0200 David Craven wrote: > I wonder who started the #:prefix/#:select thing in the first place. I > don't think that anything from guix licenses is likely to cause a name > collision. Maybe it's best to remove the #:prefix entirely? Expat causes a name collision.

Re: [PATCH 09/24] gnu: freedesktop: Add wayland-protocols.

2016-08-17 Thread David Craven
Wayland protocols only contains xml definitions, so the description is accurate: find /gnu/store/fy5lg7x7ln92gnb0da5nvkz0zswrf5z4-wayland-protocols-1.4 /gnu/store/fy5lg7x7ln92gnb0da5nvkz0zswrf5z4-wayland-protocols-1.4 /gnu/store/fy5lg7x7ln92gnb0da5nvkz0zswrf5z4-wayland-protocols-1.4/share /gnu/sto

Re: [PATCH 08/24] gnu: xorg: Add lndir.

2016-08-17 Thread David Craven
> The patch looks good to me, except the indentation of this > > (string-append ...). I usually write 'source' fields like this: > >(source (origin > (method url-fetch) > (uri (string-append "mirror://xorg/individual/util/lndir-" > ver

Re: [PATCH 07/24] gnu: compression: Add snappy.

2016-08-17 Thread David Craven
> Also there is a real release that shouldn't require autoreconf phase: > > Did you try using it? Just did, and requires running autoreconf too...

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread David Craven
I wonder who started the #:prefix/#:select thing in the first place. I don't think that anything from guix licenses is likely to cause a name collision. Maybe it's best to remove the #:prefix entirely?

Re: [PATCH 0/1] Perl 5.24.0 update

2016-08-17 Thread Ricardo Wurmus
Leo Famulari writes: > On Tue, Aug 16, 2016 at 06:43:57PM -0400, Leo Famulari wrote: >> And the perl-no-build-time patch deactivated the code that embedded the >> compilation timestamp that is normally printed by `perl -V`. Perl 5.24.0 >> can take this value from the macro PERL_BUILD_DATE [2], s