Re: ‘core-updates’ merge is a squashed commit

2016-08-06 Thread Mike Gerwitz
On Thu, Aug 04, 2016 at 17:06:15 +0200, Andy Wingo wrote: > What's the rationale for requiring non-HEAD commits to be signed when > pushing? For me a signed HEAD implicitly signs all parent comments, in > my mental trust model anyway :) That could be a potentially daunting/impossible task for the

Re: [PATCH] gnu: bash-completion: Update to 2.3.

2016-08-06 Thread Leo Famulari
On Fri, Aug 05, 2016 at 08:53:46PM +0200, Andreas Enge wrote: > The autoreconf phase is strange. Why is it suddenly needed? If there is no > way around it, you should at least add a comment. I notice that when projects move to GitHub, they sometimes forget to cut a new release. GitHub automaticall

Re: [PATCH 06/10] gnu: mesa: Enable wayland support.

2016-08-06 Thread Leo Famulari
On Fri, Aug 05, 2016 at 04:31:25PM +0200, David Craven wrote: > So now that 0.11.0 was merged can the update to mesa 12.0.0 go into > core-updates? We need to make the new core-updates branch, but there is a hiccup: http://lists.gnu.org/archive/html/guix-devel/2016-08/msg00456.html Please hold :

Re: [PATCH v2] gnu: node: Update to 6.3.1.

2016-08-06 Thread Leo Famulari
On Fri, Aug 05, 2016 at 01:02:45PM +0200, Jelle Licht wrote: > ;; FIXME: These tests fail in the build container, but they > don't > ;; seem to be indicative of real problems in practice. > (for-each delete-file > - '("test/parallel/t

Re: [PATCH] Add python-pythondialog

2016-08-06 Thread Leo Famulari
On Thu, Aug 04, 2016 at 08:16:42AM +, ng0 wrote: > Leo Famulari writes: > > > On Thu, Jul 28, 2016 at 12:53:15PM +0200, Vincent Legoll wrote: > >> And actually the patch is wrong, I think it's missing a closing paren > >> for python2-pythondialog... > > > > I re-wrote it using the 'python2-va

Re: [PATCH] gnu: Add bs1770gain.

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 05:38:46PM -0500, Alex Griffin wrote: > This patch adds bs1770gain, a tool for adjusting and normalizing the > loudness of audio and video files. > > * gnu/packages/video.scm (bs1770gain): New variable. Thanks! The license headers say GPL version 2 or later, so I changed

Re: [PATCH] gnu: beets: Update to 1.3.19.

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 05:38:40PM -0500, Alex Griffin wrote: > The most important plugin that I'm missing is the replaygain plugin, and > I've got it working on my system now. There are multiple replaygain > backends, and I wanted the bs1770gain backend, so I created a package > for that. I starte

Re: [PATCH 2/5] gnu: Add libosinfo.

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 05:46:00PM +0200, Ricardo Wurmus wrote: > * gnu/packages/qemu.scm (libosinfo): New variable. > + ("usb.ids" > +,(origin > + (method url-fetch) > + ;; FIXME: there is no versioned URL > + (uri "http://www.linux-usb.org/usb.ids";)

Re: [PATCH 1/5] gnu: Add libvirt.

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 05:45:59PM +0200, Ricardo Wurmus wrote: > + (add-after 'unpack 'fix-tests > + (lambda _ > + (substitute* '("tests/commandtest.c" > +"gnulib/tests/test-posix_spawn1.c" > +"gnulib/tests/test-

Re: [PATCH 2/2] gnu: tcsh: Update to 6.19.00.

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 05:33:36AM +0200, Tobias Geerinckx-Rice wrote: > Only four tests fail now when building unpatched on my x86_64-linux > machine, down from six in the previous version. I've trimmed down > ‘tcsh-fix-autotest.patch’ to only disabled those 4 tests. > > This may be overly optimi

Re: [PATCH 1/2] gnu: zsh: Use 'modify-phases'.

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 05:33:35AM +0200, Tobias Geerinckx-Rice wrote: > * gnu/packages/shells.scm (zsh)[arguments]: Use ‘modify-phases’ > instead of ‘alist-delete’. LGTM

Re: [PATCH]Add ALSA support for recordmydesktop.

2016-08-06 Thread Leo Famulari
On Tue, Aug 02, 2016 at 11:13:43PM +0300, Pak Pang wrote: > Hello. I made a patch to add ALSA support for recordmydesktop. Great, thanks! > Dmitry Nikolaev What name do you want to use for the Git commit's Author field? As is, it looks like this: $ git log commit fa58352d7a630f352ff4e84d1b7b17

Re: [PATCH] gnu: Add stress-make.

2016-08-06 Thread Leo Famulari
On Tue, Aug 02, 2016 at 11:53:33AM -0500, Eric Bavier wrote: > Hello Guix, > > I'm mostly looking for a second-opinion on the license of this package. > Other comments welcome too, of course. > > * gnu/packages/debug.scm (stress-make): New variable. > + (version (string-append "1.0-" revisi

Re: [PACKAGE] sinit

2016-08-06 Thread Leo Famulari
On Sat, Jul 30, 2016 at 06:19:47PM +0200, Vincent Legoll wrote: > On Sat, Jul 30, 2016 at 3:46 PM, Vincent Legoll > wrote: > > Here is the accompanying patch for sinit to build properly under guix > > > > It will be submitted alongside the scm modifs. > > > > I may even try to make it upstream, as

Re: [Nix-dev] GNU Guix & GuixSD 0.11.0 released

2016-08-06 Thread Leo Famulari
On Fri, Aug 05, 2016 at 07:55:28PM +0200, Profpatsch wrote: > On 16-08-03 04:03pm, Ludovic Courtès wrote: > > We are pleased to announce the release of GNU Guix & GuixSD 0.11.0, > > representing 2,119 commits by 70 people over 4 months. > > Thumbs up for the effort. > Would love to see some cross-

Re: [PATCH 12/12] gnu: python: Add python-ipaddress.

2016-08-06 Thread Leo Famulari
On Sat, Aug 06, 2016 at 02:52:37PM +0200, David Craven wrote: > > I believe we already have python2-ipaddress, although an older version. > > Ups, I missed that. Thanks. > > Can you answer some questions on best practices for packaging python packages? > > 1. Are python-setuptools inputs or nati

Re: [GSoC] Continuous integration tool à la Hydra.

2016-08-06 Thread Mathieu Lirzin
Hello David, David Craven writes: > Are you already working on a package/service for guix? This would indeed be the goal, however I am not there yet. > I'd like to deploy it to my server to avoid silly mistakes > like in my last two pushes to master... > > Does it rebuild from commit individua

Re: [PATCH] gnunet-svn, gnunet-gtk-svn

2016-08-06 Thread ng0
The next 2.5 days will be unpleasant for me and probably difficult to focus, but I know how to fix the 3 failing tests for us. I'll have this fixed in thex next days. Appended is the failing tests output (for me as a backup) and the combined gnunet-svn + gnunet-gtk-svn patch. As we discussed this

Re: [GSoC] Continuous integration tool à la Hydra.

2016-08-06 Thread David Craven
> I understand that, but developers should have a simple way to check > their own work. Hopefully commits made to master are good commits > and hydra only has to rebuild from HEAD. It would also be nice if developers could easily hook up their servers to the guix build farm, if I do run my own con

Re: [GSoC] Continuous integration tool à la Hydra.

2016-08-06 Thread David Craven
> We don't have enough build farm capacity to make it practical to check > every commit. It might make sense to include an option for this, but > most of the time we'd need to disable it. I understand that, but developers should have a simple way to check their own work. Hopefully commits made to

Re: [GSoC] Continuous integration tool à la Hydra.

2016-08-06 Thread Mark H Weaver
David Craven writes: > Hi Mathieu, > > Are you already working on a package/service for guix? > > I'd like to deploy it to my server to avoid silly mistakes > like in my last two pushes to master... > > Does it rebuild from commit individually or only HEAD? > This would be nice to check for rebas

Re: [PATCH 3/5] gnu: qemu: Enable spice support.

2016-08-06 Thread Mark H Weaver
Hi David, David Craven writes: >> Unfortunately, 'spice' only builds successfully on x86_64, so with this >> patch, i686 and armhf lose 'qemu'. > > 'usbredir' is needed by 'spice-gtk' which is only needed to run the tests > for spice. This can be fixed by removing the automated tests configure-f

Re: [PATCH 12/12] gnu: python: Add python-ipaddress.

2016-08-06 Thread Danny Milosavljevic
> 1. Are python-setuptools inputs or native-inputs? It seems to be done > both ways but I guess it doesn't really matter since it's an interpreted > language. Usually native-inputs. The idea is you only need the native-inputs to compile and install the thing and then you can throw the native-inpu

Re: [PATCH] ui: 'package->recutils' serializes the source field.

2016-08-06 Thread Mathieu Lirzin
Alex Kost writes: > David Craven (2016-08-05 17:58 +0300) wrote: > >> * guix/ui.scm (package->recutils): Format origin. >> --- >> guix/ui.scm | 18 ++ >> 1 file changed, 18 insertions(+) >> >> >> diff --git a/guix/ui.scm b/guix/ui.scm >> index 4d1b65c..e232548 100644 >> --- a/gui

Re: core-updates merged!

2016-08-06 Thread Leo Famulari
On Wed, Aug 03, 2016 at 12:04:46AM -0400, Leo Famulari wrote: > On Tue, Aug 02, 2016 at 11:28:59PM +0200, Ludovic Courtès wrote: > > Leo Famulari skribis: > > Otherwise LGTM; could you push it to core-updates-next? > > I merged master into core-updates-next and made the change in a > subsequent c

Re: guix-0.11 help2man errors during compilation

2016-08-06 Thread Mathieu Lirzin
Alex Vong writes: > Mathieu Lirzin writes: > >> Hello, >> >> Jan Synáček writes: >> >>> I'm getting strange errors: >>> >>> ... >>> HELP2MAN doc/guix-daemon.1 >>> help2man: can't get `--help' info from guix-daemon >>> Try `--no-discard-stderr' if option outputs to stderr >>> WARNING: 'help2man'

[PATCH] python-kivy and Adobe source-code-pro font

2016-08-06 Thread Dylan Jeffers
Hi all, First patch to guix-devel; tried my best to conform to the guidelines. Couldn't fix some "abiguous package" issues with font-adobe-source-code-pro package. Let me know if someone finds a solution. More packages to come! Dylan>From db8338214f57249f7f513d9b27b6f31ae6cea345 Mon Sep 17 00:00:

Re: help with setenv of perl-curses

2016-08-06 Thread ng0
Hi, Efraim Flashner writes: > On Sat, Jul 23, 2016 at 01:18:10PM +, ng0 wrote: >> Possibly fixed with this patch. Things I have not addressed so >> far and require input on: How to do this >> "perl Makefile.PL PANELS MENUS FORMS" in the setup. >> Successfully built does not mean functional i

Re: help with setenv of perl-curses

2016-08-06 Thread ng0
Hi, Vincent Legoll writes: > Hello, > >> +(build-system perl-build-system) >> +(inputs `(("ncurses" ,ncurses))) >> +(arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-before >> + 'configure 'set-curses-ldflags >> + (lambd

Re: guix-0.11 help2man errors during compilation

2016-08-06 Thread Mathieu Lirzin
Jan Synáček writes: > On Fri, Aug 5, 2016 at 2:19 PM, Mathieu Lirzin wrote: >> Hello, >> >> Jan Synáček writes: >> >>> I'm getting strange errors: >>> >>> ... >>> HELP2MAN doc/guix-daemon.1 >>> help2man: can't get `--help' info from guix-daemon >>> Try `--no-discard-stderr' if option outputs to

Re: [PATCH] gnunet-svn, gnunet-gtk-svn

2016-08-06 Thread ng0
Andreas Enge writes: > Hello, > > On Wed, Aug 03, 2016 at 11:45:56AM +, ng0 wrote: >> I think the costs of maintaining a -svn of gnunet are too high at the >> moment. I'm using these two packages as a base for debugging gnunet in >> addition to gentoo to help work with upstream. >> >> A revi

Re: [PATCH 12/12] gnu: python: Add python-ipaddress.

2016-08-06 Thread David Craven
> I believe we already have python2-ipaddress, although an older version. Ups, I missed that. Thanks. Can you answer some questions on best practices for packaging python packages? 1. Are python-setuptools inputs or native-inputs? It seems to be done both ways but I guess it doesn't really matte

Re: [PATCH] ui: 'package->recutils' serializes the source field.

2016-08-06 Thread David Craven
Hi Alex, > I'm not sure if this is a desired formatting, WDYT? No that's not a desired formatting, it should be space separated like the systems list IMO.

Re: [PATCH] ui: 'package->recutils' serializes the source field.

2016-08-06 Thread Alex Kost
David Craven (2016-08-05 17:58 +0300) wrote: > * guix/ui.scm (package->recutils): Format origin. > --- > guix/ui.scm | 18 ++ > 1 file changed, 18 insertions(+) > > > diff --git a/guix/ui.scm b/guix/ui.scm > index 4d1b65c..e232548 100644 > --- a/guix/ui.scm > +++ b/guix/ui.scm > @

Re: [PACKAGE] musl libc

2016-08-06 Thread ng0
Ricardo Wurmus writes: > Vincent Legoll writes: > >> On Wed, Aug 3, 2016 at 1:24 PM, Ricardo Wurmus wrote: >>> I just built musl and found that it also installs “bin/musl-gcc”, a >>> wrapper of sorts, but it doesn’t work as it depends on a “gcc” >>> executable to be available. >> >> I did not s

Re: [PATCH] gnu: libextractor: Update inputs.

2016-08-06 Thread ng0
Andreas Enge writes: > On Fri, Aug 05, 2016 at 08:42:46PM +, ng0 wrote: >> This is weird. I ran this 2 days ago with no failing tests. >> I'll see if I had an update I did not post. > > This could also be a sign of non-determinism. As posted two days ago, > I had packages that failed on hydra

Re: Tor Browser

2016-08-06 Thread ng0
Hi, in the following reply I assume that you did not read all of the original thread[0]. If I am wrong, correct me. Alex Vong writes: > ng0 writes: > >> Ludovic Courtès writes: >> >>> n...@we.make.ritual.n0.is skribis: >>> Ludovic Courtès writes: >>> >>> [...] >>> > I suppose TB cont

Re: [PATCH 3/5] gnu: qemu: Enable spice support.

2016-08-06 Thread David Craven
> Trying to build with guix build --system=armhf-linux tells me that I'm > x86-64-linux and the same for --system=mipsel-linux. It would be > nice if guix build would spin up a qemu instance in this case. It will > take me a while to test. Before reinventing the wheel or deploying my own hydra bui

Re: [GSoC] Continuous integration tool à la Hydra.

2016-08-06 Thread David Craven
Hi Mathieu, Are you already working on a package/service for guix? I'd like to deploy it to my server to avoid silly mistakes like in my last two pushes to master... Does it rebuild from commit individually or only HEAD? This would be nice to check for rebase mistakes where HEAD builds but a com

[PATCH 5/5] gnu: gnome-themes-standard: Don't install 'icon-theme.cache'.

2016-08-06 Thread 宋文武
* gnu/packages/gnome.scm (gnome-themes-standard)[arguments]: New field. --- gnu/packages/gnome.scm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 78827eb..0258e28 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -1

[PATCH 4/5] gnu: gnome-icon-theme, adwaita-icon-theme: Don't install 'icon-theme.cache'.

2016-08-06 Thread 宋文武
* gnu/packages/gnome.scm (gnome-icon-theme)[native-inputs]: Remove 'gtk+'. [arguments]: Set 'GTK_UPDATE_ICON_CACHE' to the path of 'true'. (adwaita-icon-theme)[native-inputs]: Add 'gtk+:bin'. --- gnu/packages/gnome.scm | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --gi

[PATCH 3/5] gnu: evince: Don't install 'icon-theme.cache'.

2016-08-06 Thread 宋文武
* gnu/packages/gnome.scm (evince)[arguments]: Add 'skip-gtk-update-icon-cache' phase. --- gnu/packages/gnome.scm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 2038f8f..8be68ab 100644 --- a/gnu/packages/gnome.scm

[PATCH 2/5] profiles: gtk-icon-themes: Use 'gtk-update-icon-cache' from 'gtk+:bin'.

2016-08-06 Thread 宋文武
* guix/profiles.scm (gtk-icon-themes): Use 'gtk-update-icon-cacnhe' from the "bin" output of gtk+ package. --- guix/profiles.scm | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/guix/profiles.scm b/guix/profiles.scm index db807a8..9c2dbba 100644 --- a/guix

[PATCH 1/5] gnu: gtk+: Add "bin" output.

2016-08-06 Thread 宋文武
* gnu/packages/gtk.scm (gtk+)[outputs]: New field. --- gnu/packages/gtk.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index 21365b9..5c42053 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -624,6 +624,7 @@ application suites.")

Re: [PATCH 5/5] services: Add spice vdagent service.

2016-08-06 Thread David Craven
> Usually we ask for about one week to pass before merging without > comment. Otherwise there’s just not enough time for reviewers to look > over the patches. Thank you for the information! In case you are referring to the 'enable spice in qemu patch', it was first submitted 2016/07/29. But I sh

Re: [PATCH 3/5] gnu: qemu: Enable spice support.

2016-08-06 Thread David Craven
> Unfortunately, 'spice' only builds successfully on x86_64, so with this > patch, i686 and armhf lose 'qemu'. 'usbredir' is needed by 'spice-gtk' which is only needed to run the tests for spice. This can be fixed by removing the automated tests configure-flag and removing spice-gtk from the depen

Re: ‘core-updates’ merge is a squashed commit

2016-08-06 Thread Andreas Enge
On Fri, Aug 05, 2016 at 08:59:32PM -0400, Mark H Weaver wrote: > I haven't thought deeply on this, but it seems to me that Andy's > suggestion has a lot of merit. We could choose to decide, as a matter > of policy, that if you sign a commit with unsigned ancestor commit(s), > you are effectively v

Re: [PATCH 5/5] services: Add spice vdagent service.

2016-08-06 Thread Ricardo Wurmus
David Craven writes: > No comment means these patches are ok to merge? Usually we ask for about one week to pass before merging without comment. Otherwise there’s just not enough time for reviewers to look over the patches. ~~ Ricardo