Re: [PATCH] gnu: Add gst-plugins-ugly

2015-07-07 Thread David Hashe
> +(home-page "http://gstreamer.freedesktop.org/";;) There's an extraneous semicolon here, but once I removed that everything worked fine and I was able to play mp3s without issue. I've attached an updated rhythmbox patch adding gst-plugins-ugly as a dependency along with some useful configur

Re: [PATCH 10/15] gnu: system: Move file-system->spec to (gnu system file-systems).

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:51 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> * gnu/system/linux-initrd.scm (file-system->spec): Move this... >> * gnu/system/file-systems.scm: ... to here. > > OK Pushed.

Re: [PATCH 09/15] gnu: system: Move into (gnu system file-systems).

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:51 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> * gnu/system/vm.scm (, %store-mapping): Move from >> here... >> * gnu/system/file-systems.scm: ...to here. >> * guix/scripts/system.scm: Import (gnu system file-systems). > > OK Pushed.

Re: [PATCH 07/15] build: syscalls: Add pivot-root.

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:35 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> From: David Thompson >> >> * guix/build/syscalls.scm (pivot-root): New procedure. >> * tests/syscalls.scm: Test it. > > [...] > >> +(test-assert "pivot-root" >> + (match (pipe) >> +((in . out) >> + (ma

Re: [PATCH 06/15] build: syscalls: Add setns syscall wrapper.

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:28 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> From: David Thompson >> >> * guix/build/syscalls.scm (setns): New procedure. >> * tests/syscalls.scm: Test it. > > [...] > >> +(lambda (fdes nstype) >> + "Reassociate the current process with the names

Re: [PATCH 05/15] build: syscalls: Add clone syscall wrapper.

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:23 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> From: David Thompson >> >> * guix/build/syscalls.scm (clone): New procedure. >> (CLONE_NEWNS, CLONE_NEWUTS, CLONE_NEWIPC, CLONE_NEWUSER, CLONE_NEWPID, >> CLONE_NEWNET): New variables. >> * tests/syscalls.sc

Re: [PATCH 04/15] utils: Add call-with-temporary-directory.

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:15 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> * guix/utils.scm (call-with-temporary-directory): New procedure. > > OK. Pushed, thanks! - Dave

Re: [PATCH 03/15] build: syscalls: Add mkdtemp!

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:15 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> * guix/build/syscalls.scm (mkdtemp!): New procedure. >> * tests/syscalls.scm: Test it. > > Rather: > > * tests/syscalls.scm ("mkdtemp!"): New test. > > Otherwise OK. Fixed and pushed, thanks! - Dave

Re: [PATCH 02/15] build: syscalls: Add unmount flags.

2015-07-07 Thread Thompson, David
2015-07-07 10:50 GMT-04:00 Ludovic Courtès : > David Thompson skribis: > >> * guix/build/syscalls.scm (MNT_FORCE, MNT_DETACH, MNT_EXPIRE) >> (UMOUNT_NOFOLLOW): New variables. > > OK Pushed, thanks! - Dave

Re: [PATCH 01/15] build: syscalls: Add additional mount flags.

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 9:14 AM, Ludovic Courtès wrote: > David Thompson skribis: > >> From: David Thompson >> >> * guix/build/syscalls.scm (MS_NOSUID, MS_NODEV, MS_NOEXEC, MS_STRICTATIME): >> New variables. > > OK. Pushed, thanks! - Dave

Re: [PATCH 0/15] Add preliminary support for Linux containers

2015-07-07 Thread Thompson, David
On Tue, Jul 7, 2015 at 6:28 AM, Ludovic Courtès wrote: > Howdy! > > In short, this is awesome! > > Here are random notes I took as I was playing with all this. > > David Thompson skribis: > >> The main interface to this functionality is the 'call-with-container' >> procedure in the (gnu build lin

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Mark H Weaver
Alex Kost writes: > Mark H Weaver (2015-07-07 21:36 +0300) wrote: > >> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm >> index 82e8c88..6cdc846 100644 >> --- a/gnu/packages/pdf.scm >> +++ b/gnu/packages/pdf.scm >> @@ -172,8 +172,9 @@ >> (build-system gnu-build-system) >> (argu

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Alex Kost
Mark H Weaver (2015-07-07 21:36 +0300) wrote: > Alex Kost writes: > >> Mark H Weaver (2015-07-07 18:07 +0300) wrote: >> >> [...] (arguments `(#:make-flags `(,(string-append "DESTDIR=" (assoc-ref %outputs "out")) - "PLUGINDIR=/lib/zathura" "CC=gcc")

Re: [PATCH] gnu: Add gst-plugins-ugly

2015-07-07 Thread Mark H Weaver
Mark H Weaver writes: > David Hashe writes: > >> Thanks for clarifying. Besides patents, my other concern was >> licensing. Specifically, the page I linked about gst-plugins-ugly >> includes the following: >> >> The license on either the plug-ins or the supporting libraries might >> not be how w

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Mark H Weaver
Alex Kost writes: > Mark H Weaver (2015-07-07 18:07 +0300) wrote: > > [...] >>> (arguments >>> `(#:make-flags >>> `(,(string-append "DESTDIR=" (assoc-ref %outputs "out")) >>> - "PLUGINDIR=/lib/zathura" "CC=gcc") >>> + "PREFIX=" "PLUGINDIR=/lib/zathura" "CC=gcc

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Alex Kost
Paul van der Walt (2015-07-07 11:43 +0300) wrote: > Hey Alex, > > On 2015-07-07 at 10:33, quoth Alex Kost: >> I've noticed that the packages for zathura plugins install .desktop >> files into: >> >> /gnu/store/…/usr/share/applications/ instead of: >> /gnu/store/…/share/applications/ >> >> The atta

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Alex Kost
Mark H Weaver (2015-07-07 18:07 +0300) wrote: [...] >> (arguments >> `(#:make-flags >> `(,(string-append "DESTDIR=" (assoc-ref %outputs "out")) >> - "PLUGINDIR=/lib/zathura" "CC=gcc") >> + "PREFIX=" "PLUGINDIR=/lib/zathura" "CC=gcc") > > It would be better to l

Re: [PATCH 3/5] build: Add 'emacs-build-system'

2015-07-07 Thread Alex Kost
Federico Beffa (2015-07-07 10:21 +0300) wrote: > Alex Kost writes: > >> Wouldn't it be better to name it "elpa-build-system" as that's what it >> is in my opinion, since it does not retrieve the source directly from >> upstream but from ELPA/MELPA/... "repositories" instead. > > The build system

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Mark H Weaver
Alex Kost writes: > I've noticed that the packages for zathura plugins install .desktop > files into: > > /gnu/store/…/usr/share/applications/ instead of: > /gnu/store/…/share/applications/ > > The attached patch fixes it. Good catch, but see below: > From 74efced6076ef28b321cb2a6a69344f55b714b

[PATCH] gnu: Add gst-plugins-ugly

2015-07-07 Thread Mark H Weaver
David Hashe writes: > Thanks for clarifying. Besides patents, my other concern was > licensing. Specifically, the page I linked about gst-plugins-ugly > includes the following: > > The license on either the plug-ins or the supporting libraries might > not be how we'd like. Yes, we'll need to inv

Re: [PATCH 02/15] build: syscalls: Add unmount flags.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * guix/build/syscalls.scm (MNT_FORCE, MNT_DETACH, MNT_EXPIRE) > (UMOUNT_NOFOLLOW): New variables. OK

Re: [PATCH] gnu: make-bootstrap: Produce the correct %glibc-bootstrap-tarball for Hurd systems.

2015-07-07 Thread Ludovic Courtès
Manolis Ragkousis skribis: > * gnu/packages/make-bootstrap.scm (%glibc-bootstrap-tarball): Make it a > procedure. > (%glibc-stripped): Make it a procedure and move the kernel specific part > from > here to ... > * guix/build/make-bootstrap.scm (make-stripped-libc): ... here. New file. > > C

Re: [PATCH] scripts: substitute: Avoid infinite looping when updating the substitute list

2015-07-07 Thread Ludovic Courtès
Andy Patterson skribis: >> Did you observe the problem when connecting to hydra.gnu.org, or was it >> another server? Did you have a way to reproduce it? > > I was only connecting to hydra.gnu.org, and was using a default setup. > First I used the install image, and then on my current setup with

Re: [PATCH 15/15] scripts: Add 'container' subcommand.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * guix/scripts/container.scm: New file. > * guix/scripts/container/exec.scm: New file. > * doc/guix.texi (Invoking guix container): New section. > * Makefile.am (MODULES): Add them. [...] > +@node Invoking guix container > +@section Invoking @command{guix container} >

Re: [PATCH 14/15] scripts: environment: Add --container option.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * guix/scripts/enviroment.scm (show-help): Show help for new option. > (%options): Add --container option. > (launch-environment, launch-environment/container): New procedures. > (guix-environment): Spawn new process in a container when requested. > * doc/guix.texi

Re: [PATCH 07/15] build: syscalls: Add pivot-root.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > From: David Thompson > > * guix/build/syscalls.scm (pivot-root): New procedure. > * tests/syscalls.scm: Test it. [...] > +(test-assert "pivot-root" > + (match (pipe) > +((in . out) > + (match (clone (logior CLONE_NEWUSER CLONE_NEWNS)) > + (0 > +

Re: [PATCH 13/15] scripts: system: Add 'container' action.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > From: David Thompson > > * guix/scripts/system.scm (show-help): Display 'container' action. > (system-derivation-for-action, guix-system): Add 'container' case. > (perform-action): Skip GRUB config generation when building a container. > * doc/guix.texi (Invoking gu

Re: [PATCH 08/15] gnu: build: Add Linux container module.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * gnu/build/linux-container.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > * .dir-locals.el: Add Scheme indent rules for 'call-with-clone', 'with-clone', > 'call-with-container', and 'container-excursion'. > * tests/containers.scm: New file. > * Makef

Re: [PATCH 12/15] gnu: system: Add Linux container file systems.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * gnu/system/file-systems.scm (%container-file-systems): New variable. [...] > +(define %container-file-systems Could you add a comment explaining how they differ from %base-file-systems and why it must be done this way? Otherwise OK. Ludo’.

Re: [PATCH 11/15] gnu: system: Add Linux container module.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * gnu/system/linux-container.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > * gnu/system.scm: Export 'operating-system-etc-directory', > 'operating-system-boot-script', 'operating-system-locale-directory', and > 'file-union'. > (operating-system-b

Re: [PATCH 10/15] gnu: system: Move file-system->spec to (gnu system file-systems).

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * gnu/system/linux-initrd.scm (file-system->spec): Move this... > * gnu/system/file-systems.scm: ... to here. OK

Re: [PATCH 09/15] gnu: system: Move into (gnu system file-systems).

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * gnu/system/vm.scm (, %store-mapping): Move from here... > * gnu/system/file-systems.scm: ...to here. > * guix/scripts/system.scm: Import (gnu system file-systems). OK

Re: [PATCH 06/15] build: syscalls: Add setns syscall wrapper.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > From: David Thompson > > * guix/build/syscalls.scm (setns): New procedure. > * tests/syscalls.scm: Test it. [...] > +(lambda (fdes nstype) > + "Reassociate the current process with the namespace specified by FDES. “... by FDES, a file descriptor obtained by

Re: [PATCH 05/15] build: syscalls: Add clone syscall wrapper.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > From: David Thompson > > * guix/build/syscalls.scm (clone): New procedure. > (CLONE_NEWNS, CLONE_NEWUTS, CLONE_NEWIPC, CLONE_NEWUSER, CLONE_NEWPID, > CLONE_NEWNET): New variables. > * tests/syscalls.scm: Test it. [...] > +;; The libc interface to sys_clone is not

Re: [PATCH 04/15] utils: Add call-with-temporary-directory.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * guix/utils.scm (call-with-temporary-directory): New procedure. OK.

Re: [PATCH 03/15] build: syscalls: Add mkdtemp!

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > * guix/build/syscalls.scm (mkdtemp!): New procedure. > * tests/syscalls.scm: Test it. Rather: * tests/syscalls.scm ("mkdtemp!"): New test. Otherwise OK. Ludo’.

Re: [PATCH 01/15] build: syscalls: Add additional mount flags.

2015-07-07 Thread Ludovic Courtès
David Thompson skribis: > From: David Thompson > > * guix/build/syscalls.scm (MS_NOSUID, MS_NODEV, MS_NOEXEC, MS_STRICTATIME): > New variables. OK. Ludo’.

Re: [PATCH] Add preseq.

2015-07-07 Thread Ricardo Wurmus
>>> Why leave the headers? Isn’t it risky to leave headers that may be >>> different from the Samtools that we’re actually linking against? >> >> The problem is with our Samtools package(s). They don't install >> headers. I'd better update them to install the headers; then I could >> just delete

[PATCH] Add rpy2.

2015-07-07 Thread Ricardo Wurmus
>From 070b4f5553ae30c05b97a67692b54503c73ca42f Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Tue, 7 Jul 2015 13:56:49 +0200 Subject: [PATCH] gnu: Add python-rpy2. * gnu/packages/python.scm (python-rpy2, python2-rpy2): New variables. --- gnu/packages/python.scm | 38

Re: [PATCH 0/15] Add preliminary support for Linux containers

2015-07-07 Thread Ludovic Courtès
Howdy! In short, this is awesome! Here are random notes I took as I was playing with all this. David Thompson skribis: > The main interface to this functionality is the 'call-with-container' > procedure in the (gnu build linux-container) module: > > (call-with-container

Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Paul van der Walt
Hey Alex, On 2015-07-07 at 10:33, quoth Alex Kost: > I've noticed that the packages for zathura plugins install .desktop > files into: > > /gnu/store/…/usr/share/applications/ instead of: > /gnu/store/…/share/applications/ > > The attached patch fixes it. My bad! Thanks for catching that. I adm

[PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

2015-07-07 Thread Alex Kost
I've noticed that the packages for zathura plugins install .desktop files into: /gnu/store/…/usr/share/applications/ instead of: /gnu/store/…/share/applications/ The attached patch fixes it. >From 74efced6076ef28b321cb2a6a69344f55b714b59 Mon Sep 17 00:00:00 2001 From: Alex Kost Date: Tue, 7 Jul

Re: [PATCH 3/5] build: Add 'emacs-build-system'

2015-07-07 Thread Federico Beffa
Alex Kost writes: > Wouldn't it be better to name it "elpa-build-system" as that's what it > is in my opinion, since it does not retrieve the source directly from > upstream but from ELPA/MELPA/... "repositories" instead. The build system doesn't assume anything about the source location. > > I