Re: [PATCH] gnu: Add bedtools

2014-12-12 Thread Mark H Weaver
Ricardo Wurmus writes: > From c8d71da303ff6b82a30db542d382cab57a00699e Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Thu, 11 Dec 2014 17:37:16 +0100 > Subject: [PATCH] gnu: Add bedtools Ludovic mostly covered this, but I have two additional suggestions: > + (alist-rep

Re: [PATCH] gnu: Add samtools

2014-12-12 Thread Mark H Weaver
Ricardo Wurmus writes: > From c4cae6d77e00491cfd78fe03da8ab617bc1732f2 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Thu, 11 Dec 2014 15:48:22 +0100 > Subject: [PATCH] gnu: Add samtools This built successfully on x86_64, but on i686 its test suite shows 87 failures ("SAM files differ")

Re: [PATCH 03/15] gnu: Add xfconf.

2014-12-12 Thread 宋文武
Mark H Weaver writes: > 宋文武 writes: >> * gnu/packages/xfce.scm (xfconf): New variable. > > This failed to build on i686-linux. For details and build log, see: > > http://hydra.gnu.org/build/173095 > > Could you look into it? Disable parallel tests does the trick for me, pushed, thanks for not

Re: [PATCH] gnu: Add bedtools

2014-12-12 Thread Ludovic Courtès
Ricardo Wurmus skribis: > Since there is no install phase in the Makefile I had to write a > replacement to copy all tools from the build bin/ directory to the > output /bin/ directory. I don't know if it is better to explicitly list > the tools to copy or if this should rather be done with a gl

Re: [PATCH] gnu: Add samtools

2014-12-12 Thread Ludovic Courtès
Ricardo Wurmus skribis: > Attached is an updated patch. > >>> +(synopsis "Efficient utilities on manipulating alignments in the SAM >>> format") >> >> What about “Utilities to manipulate nucleotide sequence alignments”, to >> make it clearer that it’s bioinfo-related? > > I chose to reword i

Re: [PATCH 03/15] gnu: Add xfconf.

2014-12-12 Thread Mark H Weaver
宋文武 writes: > * gnu/packages/xfce.scm (xfconf): New variable. This failed to build on i686-linux. For details and build log, see: http://hydra.gnu.org/build/173095 Could you look into it? Mark

Re: [PATCH v3] gnu: Add bullet.

2014-12-12 Thread Mark H Weaver
Tomas Cech writes: > At Thu, 11 Dec 2014 22:09:22 -0500, > David Thompson wrote: >> >> Tomáš Čech writes: [...] >> > +(define-public bullet >> > + (package >> > +(name "bullet") >> > +(version "2.82") >> > +(source (origin >> > + (method url-fetch) >> > +

Re: [PATCH] gnu: Add nginx

2014-12-12 Thread Ludovic Courtès
Mark H Weaver skribis: > From 92e58c3b80d5c22969de9f242d42528f27191146 Mon Sep 17 00:00:00 2001 > From: Mark H Weaver > Date: Wed, 10 Dec 2014 17:39:48 -0500 > Subject: [PATCH] gnu: Add nginx. > > * gnu/packages/web.scm (nginx): New variable. LGTM, thanks! Ludo’.

Re: [PATCH] gnu: pcre: Update to 8.36 and enable JIT support

2014-12-12 Thread Ludovic Courtès
Mark H Weaver skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> Mark H Weaver skribis: >> >>> From 5796cf1178fbcf41ef1c3d6406adb992d7e71dd0 Mon Sep 17 00:00:00 2001 >>> From: Mark H Weaver >>> Date: Wed, 10 Dec 2014 15:56:00 -0500 >>> Subject: [PATCH] gnu: pcre: Update to 8.36 and enable J

Re: [PATCH 15/15] gnu: Add xfdesktop.

2014-12-12 Thread 宋文武
Ludovic Courtès writes: > 宋文武 skribis: > >> * gnu/packages/xfce.scm (xfdesktop): New variable. > > [...] > >> +(synopsis "XFCE Desktop Manager") > > “Xfce desktop manager”, otherwise OK. > > Thanks a lot for working on it! It will be useful to many, I guess. Pushed, thanks for review! > > L

Re: [PATCH 11/15] gnu: Add xfce4-settings.

2014-12-12 Thread 宋文武
Mark H Weaver writes: > 宋文武 writes: > >> * gnu/packages/xfce.scm (xfce4-settings): New variable. >> --- >> gnu/packages/xfce.scm | 30 ++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm >> index 5f15594..c601852 10

[PATCH] gnu: Add bedtools

2014-12-12 Thread Ricardo Wurmus
This is a patch to add bedtools to the bioinformatics module. It depends on samtools and is part of the bioinformatics module created with the samtools patch. Since there is no install phase in the Makefile I had to write a replacement to copy all tools from the build bin/ directory to the output

Re: [PATCH] gnu: Add samtools

2014-12-12 Thread Ricardo Wurmus
Attached is an updated patch. >> +(synopsis "Efficient utilities on manipulating alignments in the SAM >> format") > > What about “Utilities to manipulate nucleotide sequence alignments”, to > make it clearer that it’s bioinfo-related? I chose to reword it as "Utilities to efficiently manipu

Re: [PATCH v3] gnu: Add bullet.

2014-12-12 Thread Tomas Cech
Thanks again for your review. At Thu, 11 Dec 2014 22:09:22 -0500, David Thompson wrote: > > Hello again, > > Missed one thing during my previous review. > > Tomáš Čech writes: > > > * gnu/packages/game-development.scm: New file > > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > > --- > > gn