On 09/28/2014 06:11 PM, Ludovic Courtès wrote:
> Cyril Roelandt skribis:
>
>> * guix/scripts/lint.scm (check-start-article): use "string-ci=?" instead of
>> "string=?".
>> * tests/lint.scm: Add corresponding tests.
>
> Test names, lines wrapped please. :-)
>
>>(define (check-start-article
On 09/28/2014 06:09 PM, Ludovic Courtès wrote:
> Cyril Roelandt skribis:
>
>> * guix/scripts/lint.scm (check-description-style,
>> check-synopsis-start-upper-case): New methods
>> * tests/lint.scm: Test them.
>
> Please specify the test names, and wrap lines.
>
>> +(define (start-with-upper-ca
* guix/scripts/lint.scm (check-description-style,
check-synopsis-start-upper-case): New methods.
* tests/lint.scm ("description: does not start with an upper-case letter",
"synopsis: does not start with an upper-case letter"): New tests.
---
guix/scripts/lint.scm | 26 +
* guix/lint (check-patches): Test the output of origin-patches.
---
guix/scripts/lint.scm | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 83dde9a..b613737 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
Hello,
On 10/05/2014 08:29 AM, Ludovic Courtès wrote:
I haven’t tried agetty, but it seems to have a hard-coded default login
program of “/bin/login”, which doesn’t exist here. Could you try
invoking it with -l $(guix build shadow)/bin/login ?
Alternately you could try adding a mingetty servic
On 10/03/2014 12:45 PM, Alex Sassmannshausen wrote:
> You could use something like 'parcels' (maybe too close in meaning to
> package) or 'containers' (maybe too long). Both would build on the idea
> that you can have packages inside a parcel, or container — much like bag
> probably does as well (a
I’ve merged the ‘wip-bags’ branch (which means you’ll find yourself
downloading or rebuilding a number of things.)
Please report any test suite failure or other problem.
I would particularly welcome feedback from David wrt. the suitability
for ‘guix environment’. :-)
Ludo’.
Ludovic Courtès (2014-10-05 23:20 +0400) wrote:
> Alex Kost skribis:
>
>> Thanks for the comments, the updated patch is attached. I also fixed
>> another “i.e.” thing there and used ‘with-store’ in
>> ‘process-package-actions’ procedure as well. Is it OK to make these
>> changes in this commit
Andreas Enge skribis:
> So how about the following:
> --switch-generation=1
> goes to generation 1;
> --switch-generation=-1
> goes 1 generation back;
> --switch-generation=+1
> goes one generation forward.
Sounds like a good idea.
Ludo’.
Alex Kost skribis:
> Thanks for the comments, the updated patch is attached. I also fixed
> another “i.e.” thing there and used ‘with-store’ in
> ‘process-package-actions’ procedure as well. Is it OK to make these
> changes in this commit (the ‘with-store’ change is small but many lines
> were
Ludovic Courtès (2014-10-05 17:14 +0400) wrote:
> Alex Kost skribis:
>
>> Ludovic Courtès (2014-10-05 00:23 +0400) wrote:
>
> [...]
>
>>> To sum up, I would imagine two followups to this:
>>>
>>> 1. Move these procedures to (guix profiles).
>>> 2. Convert them to monadic style.
>>>
>>> WDYT?
* gnu/packages/feh.scm: New File
---
gnu-system.am| 1 +
gnu/packages/feh.scm | 60
2 files changed, 61 insertions(+)
create mode 100644 gnu/packages/feh.scm
diff --git a/gnu-system.am b/gnu-system.am
index 94d8624..302e88f 100644
---
I've incorporated Alex's comments.
Ian Denhardt (1):
gnu: add feh
gnu-system.am| 1 +
gnu/packages/feh.scm | 60
2 files changed, 61 insertions(+)
create mode 100644 gnu/packages/feh.scm
--
2.1.2
On Sat, Oct 04, 2014 at 09:59:06PM +0400, Alex Kost wrote:
> - (Not related to this patch, but still …) Currently with “roll-back”,
> we can only switch to the previous generation. What about adding a
> possibility to switch to any generation? So that we could use
> something like this:
>
Alex Kost skribis:
> Ludovic Courtès (2014-10-05 00:23 +0400) wrote:
[...]
>> To sum up, I would imagine two followups to this:
>>
>> 1. Move these procedures to (guix profiles).
>> 2. Convert them to monadic style.
>>
>> WDYT?
>
> I like the idea of using monads there, but as I said I'm to
I agree with Alex’s comments. Ian, could you post an updated patch?
Alex Kost skribis:
> Ian Denhardt (2014-10-05 07:32 +0400) wrote:
>> +(description (string-append
>> + "feh is an X11 image viewer aimed mostly at console
>> users. "
>> + "Unlike most
Assaf Gordon skribis:
> On 10/04/2014 04:42 PM, Ludovic Courtès wrote:
>
>>> Is there a way to fix this? force the kernel to load virto driver?
>>
>> Currently all the drivers needed to mount the root partition must be
>> explicitly loaded in the initrd. So yes, you would need to have the
>> vir
Ludovic Courtès (2014-10-05 00:23 +0400) wrote:
> Hi!
>
> Alex Kost skribis:
>
>> What about the attached patch? Some comments and questions:
>>
>> - I added 'store' argument to the exported procedures, however it is
>> used only in one particular case: when we need to create an empty
>> pro
Hello,
I confirm that the package is built successfully (at least for me).
Several comments:
There should be a header (a comment with author, license, …) in the
beginning of “feh.scm” – see any file in the "gnu/packages" dir.
Ian Denhardt (2014-10-05 07:32 +0400) wrote:
[...]
> +(define-publi
19 matches
Mail list logo
