Re: [PATCH] gnu: Add ffmpeg.

2013-11-30 Thread John Darrington
On Sat, Nov 30, 2013 at 09:44:26PM +0100, Andreas Enge wrote: On Wed, Nov 27, 2013 at 11:50:54PM +0100, Andreas Enge wrote: > I just submitted a bug report for the failure on i686: >https://trac.ffmpeg.org/ticket/3177#no1 Well, it looks as if "make check" is not the pr

Re: [PATCH] pspp

2013-11-30 Thread John Darrington
New patches attached. J' On Sat, Nov 30, 2013 at 11:15:31PM +0100, Ludovic Courtès wrote: Hi John, This looks great! I just have minor stylistic notes: John Darrington skribis: > From 69c6338775161fcba20f4ce9452b33fee90dc2d1 Mon Sep 17 00:00:00 2001 >

Re: [PATCH 4/6] gnu: Add iso-codes.

2013-11-30 Thread Cyril Roelandt
On 11/30/2013 11:05 PM, Ludovic Courtès wrote: Cyril Roelandt skribis: * gnu/packages/iso-codes.scm: New file. * gnu-system.am: Add it. OK! It would be best to shorten the ‘description’ to two paragraphs or so, though. I'd love to keep the first three paragraphs (up until "outdated info

Re: [PATCH 3/6] gnu: Add libpeas.

2013-11-30 Thread Cyril Roelandt
On 11/30/2013 11:03 PM, Ludovic Courtès wrote: Cyril Roelandt skribis: * gnu/packages/gnome.scm (libpeas): New variable. OK! + (lambda* (#:key inputs #:allow-other-keys #:rest args) + (let ((configure (assoc-ref %standard-phases 'configure)) +(gir-path (lam

Re: [PATCH 2/6] gnu: gtk+: enable introspection.

2013-11-30 Thread Cyril Roelandt
On 11/30/2013 11:01 PM, Ludovic Courtès wrote: Why is gobject-introspection always accompanied by libffi? Should libffi be a propagated input of gobject-introspection? I've just checked that. Atk, pango (and similar packages) do not require libffi. However, if they are compiled without libffi

Re: [PATCH 1/6] gnu: gobject-introspection: look for 'gcc' when no compiler seems available.

2013-11-30 Thread Cyril Roelandt
On 11/30/2013 10:59 PM, Ludovic Courtès wrote: Hello! Thanks for looking into this! Cyril Roelandt skribis: @@ -192,8 +193,8 @@ dynamic loading, and an object system.") 'configure (lambda* (#:key #:allow-other-keys #:rest args) (let ((configure (assoc-ref %s

Re: [PATCH] gnu: Add ffmpeg.

2013-11-30 Thread Ludovic Courtès
Andreas Enge skribis: > On Wed, Nov 27, 2013 at 11:50:54PM +0100, Andreas Enge wrote: >> I just submitted a bug report for the failure on i686: >>https://trac.ffmpeg.org/ticket/3177#no1 > > Well, it looks as if "make check" is not the preferred way of testing ffmpeg. > Rather, one should down

Re: [PATCH] pspp

2013-11-30 Thread Ludovic Courtès
Hi John, This looks great! I just have minor stylistic notes: John Darrington skribis: > From 69c6338775161fcba20f4ce9452b33fee90dc2d1 Mon Sep 17 00:00:00 2001 > From: John Darrington > Date: Sat, 30 Nov 2013 11:11:54 +0100 > Subject: [PATCH 1/2] gnu: Added gtksourceview > > * gnu/packages/gt

Re: [PATCH 5/6] gnu: Add gnome-desktop.

2013-11-30 Thread Ludovic Courtès
Cyril Roelandt skribis: > * gnu/packages/gnome.scm (gnome-desktop): New variable. OK, but: > +(synopsis > + "The libgnome-desktop library, the gnome-about program and some > +desktop-wide documents.") should be a short phrase, not a sentence, and one that does not repeat the package na

Re: [PATCH 4/6] gnu: Add iso-codes.

2013-11-30 Thread Ludovic Courtès
Cyril Roelandt skribis: > * gnu/packages/iso-codes.scm: New file. > * gnu-system.am: Add it. OK! It would be best to shorten the ‘description’ to two paragraphs or so, though. Ludo’.

Re: [PATCH 6/6] gnu: Add eog.

2013-11-30 Thread Ludovic Courtès
Cyril Roelandt skribis: > * gnu/packages/gnome.scm (eog): New variable. OK! Ludo'.

Re: [PATCH 3/6] gnu: Add libpeas.

2013-11-30 Thread Ludovic Courtès
Cyril Roelandt skribis: > * gnu/packages/gnome.scm (libpeas): New variable. OK! > + (lambda* (#:key inputs #:allow-other-keys #:rest args) > + (let ((configure (assoc-ref %standard-phases 'configure)) > +(gir-path (lambda (pkg-name) > +

Re: [PATCH 2/6] gnu: gtk+: enable introspection.

2013-11-30 Thread Ludovic Courtès
Cyril Roelandt skribis: > * gnu/packages/gtk.scm (atk, gdk-pixbuf, gtk+, pango): enable introspection Looks good. One question though: [...] > (inputs `(("glib" ,glib) > + ("gobject-introspection" ,gobject-introspection) > + ("libffi" ,libffi) [...] > +`(("go

Re: [PATCH 1/6] gnu: gobject-introspection: look for 'gcc' when no compiler seems available.

2013-11-30 Thread Ludovic Courtès
Hello! Thanks for looking into this! Cyril Roelandt skribis: > @@ -192,8 +193,8 @@ dynamic loading, and an object system.") > 'configure > (lambda* (#:key #:allow-other-keys #:rest args) >(let ((configure (assoc-ref %standard-phases 'configure))) > - ;;

Re: [PATCH] gnu: Add ffmpeg.

2013-11-30 Thread Andreas Enge
On Wed, Nov 27, 2013 at 11:50:54PM +0100, Andreas Enge wrote: > I just submitted a bug report for the failure on i686: >https://trac.ffmpeg.org/ticket/3177#no1 Well, it looks as if "make check" is not the preferred way of testing ffmpeg. Rather, one should download about 750 MB of video sample

[PATCH] pspp

2013-11-30 Thread John Darrington
Two patches attached. The first adds the package gtksourceview. Thanks to Mark Weaver, Andraes Enge et al for their help jumping through the hoops that the upstream maintainers placed for me. The other removes the --without-gui flag from pspp J' -- PGP Public key ID: 1024D/2DE827B3 finger