Re: Socket API improvement, patch #6

2005-10-29 Thread Marius Vollmer
Kevin Ryde <[EMAIL PROTECTED]> writes: > Beaut, I gave it a bit of a tweak and applied it. Thanks! -- GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405 ___ Guile-user mailing list Guile-user@gnu.org http://lists.gnu.org/mailman/list

Re: Socket API improvement, patch #6

2005-10-28 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > I'd just suggest the following patch. Beaut, I gave it a bit of a tweak and applied it. (Incidentally, I'm sure this whole thread belongs on guile-devel, not guile-user.) ___ Guile-user mailing list Guil

Re: Socket API improvement, patch #6

2005-10-27 Thread Ludovic Courtès
Hi, Kevin Ryde <[EMAIL PROTECTED]> writes: > Ok, we got there eventually. I checked it in, and I updated the docs > (have a read to see it they look right). Great, thanks! The doc looks good to me. I'd just suggest the following patch. It documents the wrapping/unwrapping C functions (since

Re: Socket API improvement, patch #6

2005-10-26 Thread Kevin Ryde
Ok, we got there eventually. I checked it in, and I updated the docs (have a read to see it they look right). I want to give the docs a bit more polish, on the various constants and the address endianness for a start, so don't worry if they're not yet tip-top. __

Re: Socket API improvement, patch #6

2005-10-25 Thread Marius Vollmer
Kevin Ryde <[EMAIL PROTECTED]> writes: > He liked it before, I'll install it shortly, now your paperwork is on > file. Thanks! (Sorry for being s slw) -- GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405 ___ Guile-user

Re: Socket API improvement, patch #6

2005-10-24 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > Did you have a chance to look at that patch? :-) He liked it before, I'll install it shortly, now your paperwork is on file. ___ Guile-user mailing list Guile-user@gnu.org http://lists.gnu.org/mailman/li

Re: Socket API improvement, patch #6

2005-10-24 Thread Ludovic Courtès
Hi Marius, Marius Vollmer <[EMAIL PROTECTED]> writes: > Yeah, I had accidentally disconnected myself from the guile-devel > mailing list and way too busy with other things to really > notice... sorry for that. I will take a look at the patch > immediately... Did you have a chance to look at tha

Re: Socket API improvement, patch #6

2005-10-19 Thread Marius Vollmer
[EMAIL PROTECTED] (Ludovic Courtès) writes: > Kevin Ryde <[EMAIL PROTECTED]> writes: > >> Then you're just waiting for the nod from Marius. :) > > Oh, but it looks like he's been away for a couple of months or so. > Anyway, we'll see. I'm back! :-) Yeah, I had accidentally disconnected myself fr

Re: Socket API improvement, patch #6

2005-10-18 Thread Ludovic Courtès
Kevin Ryde <[EMAIL PROTECTED]> writes: > Then you're just waiting for the nod from Marius. :) Oh, but it looks like he's been away for a couple of months or so. Anyway, we'll see. Thanks, Ludovic. ___ Guile-user mailing list Guile-user@gnu.org http:/

Re: Socket API improvement, patch #6

2005-10-17 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > I got my copyright assignment form signed and approved so if this > change looks reasonable to you, it can probably go in. Kevin? Then you're just waiting for the nod from Marius. :) ___ Guile-user maili

Re: Socket API improvement, patch #6

2005-10-17 Thread Ludovic Courtès
Hi, Just a reminder about this socket patch, <[EMAIL PROTECTED]>. I got my copyright assignment form signed and approved so if this change looks reasonable to you, it can probably go in. Kevin? Thanks, Ludovic. ___ Guile-user mailing list Guile-user

Socket API improvement, patch #6

2005-10-04 Thread Ludovic Courtès
Hi Kevin, Kevin Ryde <[EMAIL PROTECTED]> writes: > Looks like a memory leak here if scm_to_ulong throws an error. > Obviously it won't normally, but a vector with any garbage could reach > here. Maybe build the addr on the stack then memdup. Ditto the other > cases. Right, I fixed this one. >