RE: The Guile junk drawer and a C plea

Sent from Mail for Windows From: Dr. Arne Babenhauserheide Sent: Sunday, 30 June 2024 16:34 To: Maxime Devos Cc: Philip McGrath; mik...@djurfeldt.com; Thompson, David; Richard Sent; guile-devel Subject: Re: The Guile junk drawer and a C plea >Maxime Devos writes: >> No it doesn’t, because of

RE: [BUG] Eval sets incorrect runtime metainformation

>I hadn't realized that other languages in Guile might compile to Tree-IL directly instead of generating syntax objects. Is that common and/or encouraged? I haven’t really checked, but probably? For anything that’s not Schemy in its macros, it strips a pointless layer of abstraction, and Tree-I

Re: The Guile junk drawer and a C plea

Maxime Devos writes: >> But when the culture shifts so people say “hey, we have versioned APIs >> now, let’s change everything around to fit this new style; it won’t >> break existing clients (until we remove the old version)” (can you say >> that you never saw people do that? I did see it), then

[PATCH 5/6] scm_i_utf8_string_hash: don't overrun when len is zero

When the length is zero, the previous code would include the byte after the end of the string in the hash. Fix that (the wide an narrow hashers also guard against it via "case 0"), and while we're there, switch to u8_mbtouc since the unsafe variant is now the same (see the info pages), and don't b

[PATCH 3/6] Add guile-procedures.txt to BUILT_SOURCES

Add guile-procedures.txt to BUILT_SOURCES to ensure it's available to tests. Without this, a "make check" from a clean checkout the "bit-extract documented?" test in bit-operations.test will fail. * Makefile.am (BUILT_SOURCES): add guile-procedures.txt Signed-off-by: Rob Browning --- Makefile.

[PATCH 4/6] test-hashing: support 32-bit

Signed-off-by: Rob Browning --- test-suite/standalone/test-hashing.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test-suite/standalone/test-hashing.c b/test-suite/standalone/test-hashing.c index 5982a0fdb..50e132989 100644 --- a/test-suite/standalone/test-hashing.c

[PATCH 1/6] define-meta-command: mention effects of a missing category

module/system/repl/command.scm: add comment. Signed-off-by: Rob Browning --- module/system/repl/command.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/module/system/repl/command.scm b/module/system/repl/command.scm index ca7450610..8b0422dbd 100644 --- a/module/system/repl/command.scm

[PATCH 2/6] Ensure GUILE-VERSION changes propagate to .version and Makefiles

Have .version depend on the Makefile, and move our CONFIG_STATUS_DEPENDENCIES setting to an AC_SUBST, as recommended by the automake info pages "Rebuilding Makefiles" section, so that changes to GUILE-VERSION will update the VERSION, etc. in the generated Makefiles. * Makefile.am (CONFIG_STATUS_DE

[PATCH 6/6] scm_i_utf8_string_hash: optimize ASCII

Since we already compute the char length, use that to detect all ASCII strings and handle those the same way we handle latin-1. Signed-off-by: Rob Browning --- libguile/hash.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/libguile/hash.c b/lib

[PATCH 0/6] A handful of post 3.0.10 fixups

I generated this set of patches while trying to track down the Debian buildd failures. Four of them are bug fixes, the other two are an optimization and a doc fix. Proposed for main, and if they're deemed plausible, I'll add relevant changelog entries and NEWS updates. Thanks Rob Browning (6):

Re: [PATCH 3/6] Add guile-procedures.txt to BUILT_SOURCES

Rob Browning writes: > Add guile-procedures.txt to BUILT_SOURCES to ensure it's available to > tests. Without this, a "make check" from a clean checkout the > "bit-extract documented?" test in bit-operations.test will fail. > > * Makefile.am (BUILT_SOURCES): add guile-procedures.txt Hmm, I just