[PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7.

2022-08-01 Thread Ludovic Courtès
The custom input/output port wrapping the TLS session record port would introduce overhead, and it would also prevent its uses in a non-blocking context--e.g., with Fibers. The port close mechanism added in GnuTLS 3.7.7 allows us to get rid of that wrapper. * guix/build/download.scm (wrap-record-

Re: bug#56867: [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7.

2022-08-01 Thread Ludovic Courtès
Ludovic Courtès skribis: > The custom input/output port wrapping the TLS session record port would > introduce overhead, and it would also prevent its uses in a non-blocking > context--e.g., with Fibers. The port close mechanism added in GnuTLS > 3.7.7 allows us to get rid of that wrapper. And

Re: [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7.

2022-08-01 Thread Maxime Devos
Some objections on error handling (I don't know much about the wrapping) On 01-08-2022 11:07, Ludovic Courtès wrote: [...] Hello! I'll land a similar change in Guile's (web client) module afterwards if there are no objections. Ludo'. diff --git a/guix/build/download.scm b/guix/build/download.