Re: Proposal of a better hash table implementation based on SRFI 125

2019-01-20 Thread Amirouche Boubekki
Thanks! I have done mostly a cosmetic review of your code. Here is the summary: - There is two big procedures that I think should be split ` get-hash-functions` and `hash-table` to help readability - I am not very fond of generic-hash-table macros, I would rather use apply / call-with-values, if

Re: Proposal of a better hash table implementation based on SRFI 125

2019-01-20 Thread Jéssica Milaré
Em dom, 20 de jan de 2019 às 10:58, Amirouche Boubekki < amirouche.boube...@gmail.com> escreveu: > Thanks! > > I have done mostly a cosmetic review of your code. Here is the summary: > Your comments are very good, I'll do most of the suggested changes. > - There is two big procedures that I thi

Re: Proposal of a better hash table implementation based on SRFI 125

2019-01-20 Thread Amirouche Boubekki
Thanks for the feedback! Also, if you are interested in r7rs in guile you might be interested in `r7rs-wip` branch of guile Le dim. 20 janv. 2019 à 14:50, Jéssica Milaré a écrit : > > > Em dom, 20 de jan de 2019 às 10:58, Amirouche Boubekki < > amirouche.boube...@gmail.com> escreveu: > >> Than