Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

2017-03-14 Thread Freja Nordsiek
OK, got it on the commit log. Took some work to figure out how to do a multiline one, but got it now. Fixed the long lines. Removed the --print-errors option. Didn't catch that. Thank you for all the help. Yeah, this sort of nitpicking makes it a lot easier for people in the future to work on th

Re: guile 2.1.7 skips while condition

2017-03-14 Thread Arne Babenhauserheide
Andy Wingo writes: > On Mon 13 Mar 2017 18:09, Arne Babenhauserheide writes: > >> ERROR: In procedure string: >> ERROR: In procedure string: Wrong type (expecting character): # > > Fixed, I think. Thanks for the report. That’s awesome! Thank you! Best wishes, Arne PS: I did not test the fix,

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

2017-03-14 Thread Freja Nordsiek
I missed adding an entry for meta/guile-2.2.pc.in in the commit log. Fixed now. Freja Nordsiek On Tue, Mar 14, 2017 at 5:10 PM, Freja Nordsiek wrote: > OK, got it on the commit log. Took some work to figure out how to do a > multiline one, but got it now. > > Fixed the long lines. > > Removed t

Re: 2.2.0 release plan

2017-03-14 Thread Matt Wette
> On Mar 14, 2017, at 8:50 AM, Andy Wingo wrote: > > On Tue 14 Mar 2017 16:25, Greg Troxel writes: > >> Andy Wingo writes: >> >>> However! Even though the code says 2.2.0 and the tag says 2.2.0, the >>> release is not until Thursday. I will not upload the tag yet. >> >> I have just barely

Re: 2.2.0 release plan

2017-03-14 Thread Matt Wette
> On Mar 14, 2017, at 5:35 PM, Matt Wette wrote: > >> >> On Mar 14, 2017, at 8:50 AM, Andy Wingo wrote: >> >> On Tue 14 Mar 2017 16:25, Greg Troxel writes: >> >>> Andy Wingo writes: >>> However! Even though the code says 2.2.0 and the tag says 2.2.0, the release is not until Th

Re: Guile-2.2 - goops setters should be inherited, no matter what :)

2017-03-14 Thread Andy Wingo
Hi, On Sun 26 Feb 2017 23:57, David Pirotte writes: > 1-setters, as in (define-method ((setter ...) (self <...>) ...) ...) > should (also :)) be inherited, As you mention this is https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19770. I think we have an understanding about why things ar

Re: Guile-2.2 - goops slot redefinition at subclass level

2017-03-14 Thread Andy Wingo
On Mon 27 Feb 2017 01:09, David Pirotte writes: > 2-slot redefinition at subclass level > > See bug#20423 for a full description. I think the correct solution here is to implement the slot combination protocol; see http://mop.lisp.se/dictionary.html#compute-slots. This can be done in 2.2.

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

2017-03-14 Thread Freja Nordsiek
I coalesced the new macros into the existing GUILE_SITE_DIR macro, though I had to change a few things as will be explained. It works on Guile 2.1.x, 2.0.x, and 1.8.x. I changed it so that if the directories for go files and compiled C extensions are not found, a warning is raised and those variabl

2.2.0 release plan

2017-03-14 Thread Andy Wingo
Hi, I think we are ready to go for 2.2.0. I am going to make a provisional 2.2.0 tag today and update the version. I will dist a tarball and upload to somewhere provisional. However! Even though the code says 2.2.0 and the tag says 2.2.0, the release is not until Thursday. I will not upload t

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

2017-03-14 Thread Andy Wingo
Hi :) Great patch, some comments. On Tue 14 Mar 2017 15:08, Freja Nordsiek writes: > From 90daf796c829f8e422a281d501f711138f21a334 Mon Sep 17 00:00:00 2001 > From: Freja Nordsiek > Date: Tue, 14 Mar 2017 15:04:38 +0100 > Subject: [PATCH] Made GUILE_SITE_DIR Autoconf macro look for directories

Re: 2.2.0 release plan

2017-03-14 Thread Greg Troxel
Andy Wingo writes: > However! Even though the code says 2.2.0 and the tag says 2.2.0, the > release is not until Thursday. I will not upload the tag yet. I have just barely caught up with 2.0.x in pkgsrc, and haven't gotten to testing 2.1.x yet. I wonder how many platforms 2.1.x has been tes

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

2017-03-14 Thread Freja Nordsiek
I improved the commit log and the comments to make them better formatted and more terse. Does the commit log look better? I also made it so that pkgconfig is tried first for finding site-ccache and only if that fails will the interpreter be used (the messages say specifically which method they are

Re: Guile-2.2 - goops slot redefinition at subclass level

2017-03-14 Thread Christopher Allan Webber
Andy Wingo writes: > On Mon 27 Feb 2017 01:09, David Pirotte writes: > >> 2- slot redefinition at subclass level >> >> See bug#20423 for a full description. > > I think the correct solution here is to implement the slot combination > protocol; see http://mop.lisp.se/dictionary.html#compute-slot

Re: 2.2.0 release plan

2017-03-14 Thread Andy Wingo
On Tue 14 Mar 2017 16:25, Greg Troxel writes: > Andy Wingo writes: > >> However! Even though the code says 2.2.0 and the tag says 2.2.0, the >> release is not until Thursday. I will not upload the tag yet. > > I have just barely caught up with 2.0.x in pkgsrc, and haven't gotten to > testing 2

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

2017-03-14 Thread Andy Wingo
Heya :) On Tue 14 Mar 2017 16:31, Freja Nordsiek writes: > From 41498549ac22ea50e497887b3a1e002985bb6f8f Mon Sep 17 00:00:00 2001 > From: Freja Nordsiek > Date: Tue, 14 Mar 2017 16:28:45 +0100 > Subject: [PATCH] GUILE_SITE_DIR: Find site directories for compiled files. > Here in the commit log