Re: Avoid warnings in threads.c when building without threads

2016-07-24 Thread Andy Wingo
On Sun 24 Jul 2016 04:38, Eli Zaretskii writes: >> > --- libguile/null-threads.h~0 2016-01-02 13:32:40.0 +0200 >> > +++ libguile/null-threads.h2016-07-15 17:47:37.101375000 +0300 >> > @@ -43,7 +43,7 @@ >> > #define scm_i_pthread_create(t,a,f,d) (*(t)=0, (void)(f), ENOS

Re: Avoid warning about alloca in read.c

2016-07-24 Thread Andy Wingo
On Sun 24 Jul 2016 04:39, Eli Zaretskii writes: >> From: Andy Wingo >> Cc: guile-devel@gnu.org >> Date: Sat, 23 Jul 2016 22:57:02 +0200 >> >> > +#ifdef __MINGW32__ >> > +#include >> > +#endif >> > + >> >> OK to commit but please remove the ifdef -- just include in all >> cases. > > Is that h

Re: Guile test-ffi uses an unportable assumption

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 23:17:58 +0200 > > > It assumes that libltdl can only produce a handle for a symbol in the > > the program itself, as opposed to those loaded from shared libraries. > > It tries 'strerror'. This cannot work on MS-Windows, unle

Re: c-api.test fails on MS-Windows due to non-portable quoting

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 23:11:08 +0200 > > > It fails like this: > > > > Running c-api.test > > 'CUR' is not recognized as an internal or external command, > > operable program or batch file. > > egrep: Unmatched ( or \('CUR' is no

Re: Update 'uname' emulation on MS-Windows

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: andrewjmore...@gmail.com, guile-devel@gnu.org > Date: Sat, 23 Jul 2016 23:03:46 +0200 > > >> > Does the Mingw toolchain supply a suitable manifest automatically ? > >> > >> No. The manifest should be provided with Guile. > > > > Of course, singe Guile is mainly a libra

Re: Avoid warnings in sockets.c when HAVE_SIN6_SCOPE_ID is unavailable

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 22:55:50 +0200 > > > CC libguile_2.0_la-socket.lo > > socket.c: In function 'scm_fill_sockaddr': > > socket.c:747:16: warning: variable 'scope_id' set but not used > > [-Wunused-but-set-variable] > > unsigned

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 22:36:17 +0200 > > >> > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the > >> > trick of appending "0" to the time-zone string, Windows runtime > >> > doesn't support that. > >> > +#ifndef __MINGW32__ > >> > +

Re: Avoid warning about alloca in read.c

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sun, 24 Jul 2016 15:35:08 +0200 > > >> > +#ifdef __MINGW32__ > >> > +#include > >> > +#endif > >> > + > >> > >> OK to commit but please remove the ifdef -- just include in all > >> cases. > > > > Is that header available on all supported pla

Re: Update 'uname' emulation on MS-Windows

2016-07-24 Thread Andy Wingo
On Sun 24 Jul 2016 16:32, Eli Zaretskii writes: >> Does the uname MinGW patch introduce a regression in any case that we >> care about? > > No. On the contrary: where before Guile would only report correct OS > version up to and including XP, it now reports correct values also for > Vista, Windo

Re: guile-lib - devel branch - patch 4 of 11

2016-07-24 Thread David Pirotte
Hello Eli, > > Don't you understand? How could I possibly answer that quiz, since it's > > been 4 > > years I use 2.69? You can't tell for sure just because there has been no > > complain: you can only tell for sure if someone you 'trust' check with what > > ever > > version you'd like to use.