Deadlock with GC 7.2alpha6 on master

2013-05-22 Thread Ludovic Courtès
Hello! On a fresh build of ‘master’ (.go not built yet), ../meta/guile -c 1 hangs like this: --8<---cut here---start->8--- (gdb) bt #0 0x775d922c in __lll_lock_wait () from /home/ludo/.guix-profile/lib/libpthread.so.0 #1 0x775d503c in _L_lock

Re: Deadlock with GC 7.2alpha6 on master

2013-05-22 Thread Ludovic Courtès
There’s no such problem with GC 7.2d. Sorry for the noise! Ludo’.

Re: [PATCH 1/6] split linker out of elf module

2013-05-22 Thread Ludovic Courtès
Hello! Note: I’m just familiarizing with the new code, so I may miss things, and may make mostly superficial comments. Andy Wingo skribis: > * module/Makefile.am: > * module/system/vm/linker.scm: New file, split out of (system vm elf). > > * module/system/vm/elf.scm: Remove linking capabilities

Re: [PATCH 2/6] ELF refactor and consequent linker simplifications

2013-05-22 Thread Ludovic Courtès
Andy Wingo skribis: > * module/system/vm/elf.scm: Add commentary. > (make-elf): Add a constructor similar to make-elf-segment and > make-elf-section. > (write-elf32-header, write-elf64-header, write-elf-header): Take an >instead of all the fields separately. > (, ): Add "index" proper

Re: [PATCH 3/6] elf: add accessors for header members that might need relocation

2013-05-22 Thread Ludovic Courtès
Andy Wingo skribis: > * module/system/vm/elf.scm (elf-header-shoff-offset) > (elf-section-header-addr-offset, elf-section-header-offset-offset): > New accessors. > --- > module/system/vm/elf.scm | 24 ++-- > 1 file changed, 22 insertions(+), 2 deletions(-) OK. Ludo'.

Re: [PATCH 4/6] refactor linker to lay out ELF files and memory in the same way

2013-05-22 Thread Ludovic Courtès
This goes beyond my ELF capabilities, so can’t really comment on this. Style comments: Andy Wingo skribis: > * module/system/vm/linker.scm (make-linker-object): > (linker-object-section-symbol): > (linker-object-symbols*): Create a symbol to the start of a linker > object. Hide it from t

Re: [PATCH 5/6] refactor and simplify ELF loader in objcodes.c

2013-05-22 Thread Ludovic Courtès
Andy Wingo skribis: > * libguile/objcodes.c (sniff_elf_alignment, alloc_aligned) > (copy_and_align_elf_data): New helpers for portably re-aligning ELF > data from read(2) or from a bytevector. > (load_thunk_from_memory): Simplify! Now there is only one procedure > that loads ELF, and it

Re: [PATCH 6/6] add (find-mapped-elf-image) procedure to (system vm objcode) module

2013-05-22 Thread Ludovic Courtès
Andy Wingo skribis: > * libguile/objcodes.c (register_elf, scm_find_mapped_elf_image): New > interfaces that keep a list of all ELF mappings. Exported from the > (system vm objcode) module. > > * module/system/vm/objcode.scm: Export find-mapped-elf-image. OK. > +static SCM > +scm_find_mapp

Re: wip-linker: Refactor ELF linker and loader

2013-05-22 Thread Ludovic Courtès
Andy Wingo skribis: > This is the first time I've tried git-send-email, so perhaps something > goes wrong. In any case, the intention is to allow folks to comment > easily on the code; we'll see how that goes. Thanks for doing this! Again, at this stage I don’t have anything clever to say abou

Re: CPS thoughts

2013-05-22 Thread Noah Lavine
An update: I just rebased wip-rtl-cps on top of wip-rtl-may-2013 and pushed. The most interesting thing was how trivial it was: all I had to do was make a one-line change in how I called `begin-program'. Best, Noah On Wed, May 22, 2013 at 12:33 AM, Noah Lavine wrote: > Hello, > > On Tue, May 21