Re: [PATCH] Colorized REPL

On 11 January 2013 14:29, Nala Ginrut wrote: > On Thu, 2013-01-10 at 16:19 +0800, Daniel Hartwig wrote: > I changed these: > string-in-color => colorize-string > display-string-in-color => colorized-display > > What do you think? Nicer anway. >> Also, the “/” in “1/2” appears as a different colo

Re: [PATCH] Colorized REPL

On Fri, 2013-01-11 at 16:13 +0800, Daniel Hartwig wrote: > On 11 January 2013 14:29, Nala Ginrut wrote: > > On Thu, 2013-01-10 at 16:19 +0800, Daniel Hartwig wrote: > > I changed these: > > string-in-color => colorize-string > > display-string-in-color => colorized-display > > > > What do you thin

Re: [PATCH] Colorized REPL

Hi Nala, Thanks for the update. Nala Ginrut skribis: > On Fri, 2013-01-04 at 15:06 +0100, Ludovic Courtès wrote: [...] >> Nala Ginrut skribis: >> >> > 1. colorized-REPL feature: >> > Add two lines to your ~/.guile, to enable colorized-REPL feature: >> > (use-modules (ice-9 colorized)) >> >

‘http-get*’ and all that

Hello! "Andy Wingo" skribis: > (http-get): Redefine in terms of http-get. Deprecate the > #:extra-headers argument in favor of #:headers. Allow a body. Add a > #:streaming? argument, subsuming the functionality of http-get*. > (http-get*): Deprecate. ‘http-get*’ was a

Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-25-g990b11c

"Andy Wingo" skribis: > commit f05bb8494c9636cd7a44aaf7d4e08f4b66004b6e > Author: Andy Wingo > Date: Thu Jan 10 22:50:27 2013 +0100 > > add bytevector->string and string->bytevector in new (ice-9 iconv) module > > * module/Makefile.am: > * module/ice-9/iconv.scm: New module im

Re: [PATCH] Colorized REPL

Hello, On Fri, Jan 11, 2013 at 9:33 AM, Ludovic Courtès wrote: > >> Nala Ginrut skribis: > > record-type in r6rs is more convenient I think. > > That’s not the question. ;-) It doesn’t justify pulling in all of R6RS. > This is just a small part of a much larger review, but it should be possi

Re: ‘http-get*’ and all that

Hi :) On Fri 11 Jan 2013 17:53, l...@gnu.org (Ludovic Courtès) writes: > "Andy Wingo" skribis: > >> (http-get): Redefine in terms of http-get. Deprecate the >> #:extra-headers argument in favor of #:headers. Allow a body. Add a >> #:streaming? argument, subsuming the functio

Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-25-g990b11c

Hi! On Fri 11 Jan 2013 18:15, l...@gnu.org (Ludovic Courtès) writes: > "Andy Wingo" skribis: > >> +@deffn string->bytevector string encoding [#:conversion-strategy='error] > > An optional instead of keyword argument would look nicer, IMO. Nicer in the docs or nicer to use? I'll change it anywa

Re: [PATCH] Colorized REPL

Hello, Noah Lavine skribis: > On Fri, Jan 11, 2013 at 9:33 AM, Ludovic Courtès wrote: > >> >> Nala Ginrut skribis: >> > record-type in r6rs is more convenient I think. >> >> That’s not the question. ;-) It doesn’t justify pulling in all of R6RS. >> > > This is just a small part of a much larg

Re: ‘http-get*’ and all that

Howdy! Andy Wingo skribis: > On Fri 11 Jan 2013 17:53, l...@gnu.org (Ludovic Courtès) writes: > >> "Andy Wingo" skribis: >> >>> (http-get): Redefine in terms of http-get. Deprecate the >>> #:extra-headers argument in favor of #:headers. Allow a body. Add a >>> #:streaming?

Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-25-g990b11c

Hi! Andy Wingo skribis: > On Fri 11 Jan 2013 18:15, l...@gnu.org (Ludovic Courtès) writes: > >> "Andy Wingo" skribis: >> >>> +@deffn string->bytevector string encoding [#:conversion-strategy='error] >> >> An optional instead of keyword argument would look nicer, IMO. > > Nicer in the docs or ni

Re: [PATCH] Colorized REPL

On 11 January 2013 22:33, Ludovic Courtès wrote: >>> > +(define *color-list* >>> > + `((CLEAR . "0") >>> > +(RESET . "0") >>> > +(BOLD. "1") >>> > +(DARK. "2") >>> Would it make sense to define a new type for colors? Like: >>> >>> (define-record

Re: [PATCH] Colorized REPL

On 11 January 2013 18:40, Nala Ginrut wrote: > Yes, that's a good point, and the test case could move out of the module > itself. It should. >> I suppose the original comments were not so clear. It is not only the >> string but other members such as “data” that do not fit the concept of >> “col

Re: ‘http-get*’ and all that

On 12 January 2013 02:49, Andy Wingo wrote: >> ‘http-get*’ was added in 2.0.7, so it doesn’t seem wise to deprecate it >> just a couple of months later, no? > > In many ways it's better to deprecate early while there are few users, > and the change was recent. It's not like the interfaces are act

[PATCH] md5: fix errors when input size modulo 64 is > 55 bytes

Originally reported as . Triggered when input has size modulo 64 is 56–63 bytes. scheme@(guile-user)> (use-modules (md5)) scheme@(guile-user)> (md5 (open-input-string (make-string 60 #\0))) ERROR: In procedure string-set!: ERROR: In procedure string-set!: Wrong typ

Re: [PATCH] md5: fix errors when input size modulo 64 is > 55 bytes

On 12 January 2013 14:43, Daniel Hartwig wrote: > > Originally reported as . > > Triggered when input has size modulo 64 is 56–63 bytes. > > scheme@(guile-user)> (use-modules (md5)) … from guile-lib, of course!