Re: [PATCH 3/5] [mingw]: Do not export opendir, readdir etc., as dirents differ.

2011-05-01 Thread Andy Wingo
Hi Jan, On Tue 15 Feb 2011 16:35, Jan Nieuwenhuizen writes: > From: Jan Nieuwenhuizen > > Without this patch, libguile exports symbols such as opendir, readdir, > which expect and use guile's struct dirent that differs from mingw's > dirent. Linking to libguile when using mingw's dirent gives

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Andy Wingo
On Fri 29 Apr 2011 19:30, Noah Lavine writes: >> Is anyone interested in implementing a path library? > > I might be able to work on it. Super! > However, I don't know much about how Windows paths work. Are there any > special considerations beyond the directory separator? Yep! Check that rac

Re: PEG CHanges

2011-05-01 Thread Andy Wingo
On Sat 16 Apr 2011 00:04, Noah Lavine writes: > I just pushed some changes to the wip-peg branch. They eliminate the > last remaining circularity in the module imports and then add > everything to the Makefile. It passes all tests on my machine. > > This is my first time pushing something, so I h

Re: [PATCH 4/5] [mingw]: Delete existing target file before attempting rename.

2011-05-01 Thread Andy Wingo
On Tue 15 Feb 2011 16:35, Jan Nieuwenhuizen writes: > From: Jan Nieuwenhuizen > > 2011-02-15 Jan Nieuwenhuizen > > * libguile/filesys.c [MINGW32] (my_rename): Add implementation > that deletes target if it exists. Fixes rename behaviour. This patch has the obvious race condition

Re: [PATCH 5/5] [mingw]: Use $LOCALAPPDATA as a possible root for cachedir.

2011-05-01 Thread Andy Wingo
On Tue 15 Feb 2011 16:35, Jan Nieuwenhuizen writes: > 2011-02-15 Jan Nieuwenhuizen > > * libguile/load.c (scm_init_load_path) [MINGW32]: Use $LOCALAPPDATA > to avoid having a NULL cachedir, while still allowing override by > using $XDG_CACHE_HOME. What sets LOCALAPPDATA? If

Re: PEG CHanges

2011-05-01 Thread Noah Lavine
Yes, I think I could do that. However, I don't think it's quite ready to merge. The last time we talked about it, I think you wanted to change the s-expression representation of some of the forms before we made it a public interface. Should that be done before or after the rebase? Noah On Sun, M

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Noah Lavine
> Yep!  Check that racket web page I linked to.  You don't have to > implement all of it, but it should be possible to implement, given the > path abstraction. Okay, I've read it. It doesn't seem very complicated. Should we strive for API compatibility? I don't see any programs needing it right no

goops proposal: proper struct classes

2011-05-01 Thread Andy Wingo
Hello all, If you know GOOPS, then you know that we have classes, rooted at . And indeed shows up a lot in documentation and in code. But that's not how it is in CLOS: our corresponds to their `standard-class'. They have a superclass, called `class', which is the real root, and from which e.g

heads up: goops class export

2011-05-01 Thread Andy Wingo
Hello again, Currently when you define a SMOB type or set a name on a vtable, a corresponding class is automatically exported from (oop goops). This breaks modularity, and I think we should stop doing it in 2.2. I will make this change at some point, if there are no objections. Andy -- http://

Re: PEG CHanges

2011-05-01 Thread Andy Wingo
Hi, On Sun 01 May 2011 20:13, Noah Lavine writes: > Yes, I think I could do that. Great. > However, I don't think it's quite ready to merge. The last time we > talked about it, I think you wanted to change the s-expression > representation of some of the forms before we made it a public > inte

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Andy Wingo
Hi, On Sun 01 May 2011 21:23, Noah Lavine writes: >> Yep!  Check that racket web page I linked to.  You don't have to >> implement all of it, but it should be possible to implement, given the >> path abstraction. > > Okay, I've read it. It doesn't seem very complicated. Should we strive > for AP

Re: ‘set-cdr!’ and weak-cdr pairs

2011-05-01 Thread Andy Wingo
Hi :) On Sun 27 Mar 2011 15:29, l...@gnu.org (Ludovic Courtès) writes: > Andy Wingo writes: > >> On Sun 13 Mar 2011 16:25, l...@gnu.org (Ludovic Courtès) writes: >> >>> The problem is that ‘hash-create-handle!’ above created a weak-cdr >>> pair—i.e., a pair whose cdr is /not/ scanned for pointer

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Mark H Weaver
Andy Wingo writes: > On Fri 29 Apr 2011 19:30, Noah Lavine writes: >> Also, are there any characters that are valid in filenames on some >> systems but invalid on other systems? > > Ah, I see you are under the delusion that paths are composed of > characters :) This is not the case. To the OS,

[PATCH] Fix several POSIX functions to use the locale encoding

2011-05-01 Thread Mark H Weaver
Hello all, GoKhlaYeh on #guile reported that although (system "echo hé") works properly, (system* "/bin/sh" "-c" "echo hé") fails. Upon investigation, I found that although Guile uses the locale encoding almost everywhere when interfacing with C, several POSIX functions use Latin-1 in a few place