Re: Build problem & unrelated patch

2010-06-08 Thread Ludovic Courtès
Hi, No Itisnt writes: >>> +/lib/c++defs.h >>> +/lib/iconv.h >>> +/lib/netdb.h >> >> I don't see these in my tree > > So where would they come from? Gnulib (Guile commit ca4353f4). Ludo’.

Re: Portability fixes for win32 cross compiling

2010-06-08 Thread Ludovic Courtès
Hi, Volker Grabsch writes: > Ludovic Courtès schrieb: >> Volker Grabsch writes: >> > >> > --- a/libguile/objcodes.c >> > +++ b/libguile/objcodes.c >> > @@ -23,7 +23,6 @@ >> > #include >> > #include >> > #include >> > -#include >> > #include >> > #include >> > #include >> >> This

Re: Portability fixes for win32 cross compiling

2010-06-08 Thread No Itisnt
>> This one is wrong: the file uses mmap(3), which is declared in >> according to >> . >> >> This function is missing on MinGW, though, but there’s currently no >> replacement in Guile.  Would you like to work on it? > > Sorry, I

`mike-port-encodings' branch (bug #29643)

2010-06-08 Thread Ludovic Courtès
Hello Mike, Thanks for working on this! Here’s a review of the ‘mike-port-encodings’ branch. "Michael Gran" writes: > commit 26e8fd7459581f098578ddf1c366d2caea87 > Author: Michael Gran > Date: Sat Jun 5 13:40:32 2010 -0700 > > Simplify scm_i_scan_for_encoding > > Note espec