Han-Wen,
This patch:
82ae1b8eb3413e6be6bd2aa032986fc7782e85ac
Garbage collection cleanup.
Makefile.am|8
gc-card.c | 109 ++
gc-freelist.c | 150 +++---
gc-malloc.c| 24 +-
gc-mark.c |8
gc-segment-table.c | 293 +++
Hi,
[EMAIL PROTECTED] (Ludovic Courtès) writes:
> First of all, thanks for your work (I know it's not so much fun to hack
> the GC), but I feel unhappy with your commit to both `master' and
> `branch_release-1-8'.
Ooops, I thought I had seen these changes on `branch_release-1-8'
through Gitweb b
() [EMAIL PROTECTED] (Ludovic Courtès)
() Sun, 17 Aug 2008 23:47:26 +0200
The "current Autoconf way" is to use `AC_USE_SYSTEM_EXTENSIONS'
Note that you should also reposition:
#include "libguile/_scm.h"
as the first #include (before et al) in, for example,
libguile/stime.c, so that the syst
Ludovic Courtès escreveu:
> * 01621bf62ec16cb62260f0b7c9e926793718fd6d
> Include min-yields in gc-stats output.
>
> Good idea.
No, bad idea, and removed in subsequent commit.
>
> * 51ef99f7fa9fb766fbb48619fc5863ab9914591d
> Fix memory corruption issue with hell[] array: realloc/
Ludovic Courtès escreveu:
> Han-Wen,
>
> This patch:
>
> 82ae1b8eb3413e6be6bd2aa032986fc7782e85ac
> Garbage collection cleanup.
>
> Makefile.am|8
> gc-card.c | 109 ++
> gc-freelist.c | 150 +++---
> gc-malloc.c| 24 +-
> gc-mark.
Han-Wen Nienhuys escreveu:
> I had a look at pulling this change apart, but it is tricky since
> many of the changes are interrelated.
>
> If you think you need to roll back this change, please revoke my
> commit privilege and sort things out yourself. The garbage collector
> isn't that complic
Hi Han-Wen,
Han-Wen Nienhuys <[EMAIL PROTECTED]> writes:
> Ludovic Courtès escreveu:
>> is kind of hard to review in a glimpse. Does it just randomly "clean
>> things up" (whatever that means---it does not follow the GCS, for
>
> GCS?
"GNU Coding Standards", the thing we're supposed to adhere
Han-Wen Nienhuys <[EMAIL PROTECTED]> writes:
> Ludovic Courtès escreveu:
>> * 51ef99f7fa9fb766fbb48619fc5863ab9914591d
>> Fix memory corruption issue with hell[] array: realloc/calloc need to
>> factor in sizeof(scm_t_bits)
>>
>> - hell = scm_malloc (hell_size);
>> + hell = s
Han-Wen Nienhuys <[EMAIL PROTECTED]> writes:
> Running the test suite through valgrind, I get some fishy errors.
So was that fixed by this commit?
commit 51ef99f7fa9fb766fbb48619fc5863ab9914591d
Author: Han-Wen Nienhuys <[EMAIL PROTECTED]>
Date: Sat Aug 16 02:18:51 2008 -0300
Fix
Han-Wen Nienhuys <[EMAIL PROTECTED]> writes:
> Ludovic Courtès escreveu:
>>
>> * 51ef99f7fa9fb766fbb48619fc5863ab9914591d
>> Fix memory corruption issue with hell[] array: realloc/calloc need to
>> factor in sizeof(scm_t_bits)
>>
>> - hell = scm_malloc (hell_size);
>> + hell
10 matches
Mail list logo
