Re: Unicode strings and symbols

2009-08-10 Thread Ludovic Courtès
Hey, Mike Gran writes: [...] >> > +SCM_API void scm_charprint (scm_t_uint32 c, SCM port); >> >> This ought to be internal, no? > > Could be. A couple of the types are given their own print functions: > scm_intprint and an scm_uintprint. Most types don't have their own > print functions. Are

Re: Unicode strings and symbols

2009-08-09 Thread Mike Gran
On Sun, 2009-08-09 at 20:22 +0200, Ludovic Courtès wrote: > Hi Mike! > I would feel more confident if the number of lines of tests added was > proportional to the number of new C lines of code. Do you think some > more tests could be added? Or maybe this will come at a later stage? I should pr

Unicode strings and symbols

2009-08-09 Thread Ludovic Courtès
Hi Mike! Glad to see Unicode has landed! :-) Here's a quick review of the big patch. "Michael Gran" writes: > Add Unicode strings and symbols > > This adds full Unicode strings as a datatype, and it adds some > minimal functionality. The te

Re: [PATCH] Add Unicode strings and symbols

2009-08-08 Thread Mike Gran
On Sat, 2009-08-08 at 02:44 -0700, Mike Gran wrote: > On Sun, 2009-08-02 at 16:40 -0700, Mike Gran wrote: > > Hi- > > > > I think I scared Ludo when I committed something, so let me try this > > instead. Attached please find the next patch toward Unicode strings. It > > is a big patch, but, it is

Re: [PATCH] Add Unicode strings and symbols

2009-08-08 Thread Mike Gran
On Sun, 2009-08-02 at 16:40 -0700, Mike Gran wrote: > Hi- > > I think I scared Ludo when I committed something, so let me try this > instead. Attached please find the next patch toward Unicode strings. It > is a big patch, but, it is the smallest patch I could make that added > the next quantum o