Re: Support open-process and friends on MS-Windows

2016-07-11 Thread Eli Zaretskii
> From: l...@gnu.org (Ludovic Courtès) > Cc: m...@netris.org, wi...@pobox.com, guile-devel@gnu.org > Date: Mon, 11 Jul 2016 10:09:47 +0200 > > >> >>> Eli Zaretskii writes: > >> >>> > +# define getuid() (500) /* Local Administrator */ > >> >>> > +# define getgid() (513)

Re: Support open-process and friends on MS-Windows

2016-07-11 Thread Ludovic Courtès
Eli Zaretskii skribis: >> From: l...@gnu.org (Ludovic Courtès) >> Cc: Eli Zaretskii , wi...@pobox.com, guile-devel@gnu.org >> Date: Tue, 05 Jul 2016 10:04:23 +0200 >> >> Mark H Weaver skribis: >> >> > Eli Zaretskii writes: >> > >> >>> From: Mark H Weaver >> >>> Cc: l...@gnu.org (Ludovic Co

Re: Support open-process and friends on MS-Windows

2016-07-05 Thread Eli Zaretskii
> From: l...@gnu.org (Ludovic Courtès) > Cc: Eli Zaretskii , wi...@pobox.com, guile-devel@gnu.org > Date: Tue, 05 Jul 2016 10:04:23 +0200 > > Mark H Weaver skribis: > > > Eli Zaretskii writes: > > > >>> From: Mark H Weaver > >>> Cc: l...@gnu.org (Ludovic Courtès), wi...@pobox.com, > >>> g

Re: Support open-process and friends on MS-Windows

2016-07-05 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: wi...@pobox.com, l...@gnu.org, guile-devel@gnu.org > Date: Tue, 05 Jul 2016 03:44:15 -0400 > > Most applications do not expose get*id/set*id to other programs as part > of their public API. Emacs exposes getuid, getgid, geteuid, and getegid, has been doing that for

Re: Support open-process and friends on MS-Windows

2016-07-05 Thread Ludovic Courtès
Mark H Weaver skribis: > Eli Zaretskii writes: > >>> From: Mark H Weaver >>> Cc: l...@gnu.org (Ludovic Courtès), wi...@pobox.com, >>> guile-devel@gnu.org >>> Date: Sat, 02 Jul 2016 19:02:08 -0400 >>> >>> Eli Zaretskii writes: >>> > +# define getuid() (500) /* Local Administrat

Re: Support open-process and friends on MS-Windows

2016-07-05 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org (Ludovic Courtès), wi...@pobox.com, >> guile-devel@gnu.org >> Date: Sat, 02 Jul 2016 19:02:08 -0400 >> >> Eli Zaretskii writes: >> > +# define getuid() (500) /* Local Administrator */ >> > +# define getgid()

Re: Support open-process and friends on MS-Windows

2016-07-03 Thread Eli Zaretskii
> Date: Sun, 03 Jul 2016 06:47:37 +0300 > From: Eli Zaretskii > Cc: wi...@pobox.com, l...@gnu.org, guile-devel@gnu.org > > As I've said before, these operations either have no meaning on > MS-Windows, or cannot be easily mapped to the equivalent Windows > notions. All other applications ported f

Re: Support open-process and friends on MS-Windows

2016-07-02 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org (Ludovic Courtès), wi...@pobox.com, > guile-devel@gnu.org > Date: Sat, 02 Jul 2016 19:02:08 -0400 > > Eli Zaretskii writes: > > +# define getuid() (500) /* Local Administrator */ > > +# define getgid() (513) /* None */ > > +#

Re: Support open-process and friends on MS-Windows

2016-07-02 Thread Mark H Weaver
Eli Zaretskii writes: > +# define getuid() (500) /* Local Administrator */ > +# define getgid() (513) /* None */ > +# define setuid(u) (0) > +# define setgid(g) (0) As I've said before, I'm not comfortable with these definitions. These are not op

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Eli Zaretskii
> From: Andy Wingo > Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org > Date: Sat, 25 Jun 2016 16:43:34 +0200 > > > @@ -659,7 +663,7 @@ SCM_DEFINE (scm_kill, "kill", 2, 0, 0, > > #else > >/* Mingw has raise(), but not kill(). (Other raw DOS environments might > > be similar.)

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Andy Wingo
On Sat 25 Jun 2016 15:31, Eli Zaretskii writes: > [Please disregard the previous patch and use this one instead.] Thanks for the updates. I have a couple of additional nits, having applied and built the patch. > @@ -659,7 +663,7 @@ SCM_DEFINE (scm_kill, "kill", 2, 0, 0, > #else >/* Mingw

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Eli Zaretskii
[Please disregard the previous patch and use this one instead.] > From: l...@gnu.org (Ludovic Courtès) > Cc: Andy Wingo , guile-devel@gnu.org > Date: Sat, 25 Jun 2016 15:02:42 +0200 > > >> Great! I have two nits. One, if it is possible for you, please attach > >> the patch in the format that "

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Eli Zaretskii
> From: l...@gnu.org (Ludovic Courtès) > Cc: Andy Wingo , guile-devel@gnu.org > Date: Sat, 25 Jun 2016 15:02:42 +0200 > > >> Great! I have two nits. One, if it is possible for you, please attach > >> the patch in the format that "git format-patch" makes. That makes it > >> easy to apply, other

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Ludovic Courtès
Eli Zaretskii skribis: >> From: Andy Wingo >> Cc: l...@gnu.org, guile-devel@gnu.org >> Date: Sat, 25 Jun 2016 11:51:53 +0200 >> >> On Sat 25 Jun 2016 11:11, Eli Zaretskii writes: >> >> > Here's the modified patch with the couple of changes requested in >> > response to the previous version:

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Eli Zaretskii
> From: Andy Wingo > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Sat, 25 Jun 2016 11:51:53 +0200 > > On Sat 25 Jun 2016 11:11, Eli Zaretskii writes: > > > Here's the modified patch with the couple of changes requested in > > response to the previous version: > > Great! I have two nits. On

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Andy Wingo
On Sat 25 Jun 2016 11:11, Eli Zaretskii writes: > Here's the modified patch with the couple of changes requested in > response to the previous version: Great! I have two nits. One, if it is possible for you, please attach the patch in the format that "git format-patch" makes. That makes it ea

Re: Support open-process and friends on MS-Windows

2016-06-25 Thread Eli Zaretskii
Here's the modified patch with the couple of changes requested in response to the previous version: Author: Eli Zaretskii Date: Fri Jun 25 12:10:34 2016 +0300 Provide support for open-process and related functions on MS-Windows * libguile/w32-proc.c: New file, with MinGW support code

Re: Support open-process and friends on MS-Windows

2016-06-24 Thread Eli Zaretskii
> From: l...@gnu.org (Ludovic Courtès) > Cc: Andy Wingo , guile-devel@gnu.org > Date: Fri, 24 Jun 2016 13:49:17 +0200 > > > diff --git a/libguile/posix.c b/libguile/posix.c > > index 2654716..35b920f 100644 > > --- a/libguile/posix.c > > +++ b/libguile/posix.c > > @@ -84,6 +84,10 @@ > > #if HAVE

Re: Support open-process and friends on MS-Windows

2016-06-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Fri, 24 Jun 2016 12:45:36 +0200 > > Thanks! > > I think it looks pretty good. I wouldn't mind committing as-is. I > would like to hear what Ludovic or Mark thinks before doing do; WDYT? It's obviously your call how to proceed

Re: Support open-process and friends on MS-Windows

2016-06-24 Thread Ludovic Courtès
Eli Zaretskii skribis: > commit 44f8eebf9850431790b23b031f5b6e90fb3de777 > Author: Eli Zaretskii > Date: Fri Jun 24 12:45:02 2016 +0300 > > Provide support for open-process and related functions on MS-Windows > > * libguile/w32-proc.c: New file, with MinGW support code for > s

Re: Support open-process and friends on MS-Windows

2016-06-24 Thread Andy Wingo
On Fri 24 Jun 2016 11:51, Eli Zaretskii writes: > This is a re-spin of the patches last posted here: > > https://lists.gnu.org/archive/html/guile-devel/2014-08/msg00015.html > > At Andy's suggestion, I've removed most of the Windows-specific code > to the new Windows-specific file w32-proc.c, l

Support open-process and friends on MS-Windows

2016-06-24 Thread Eli Zaretskii
This is a re-spin of the patches last posted here: https://lists.gnu.org/archive/html/guile-devel/2014-08/msg00015.html At Andy's suggestion, I've removed most of the Windows-specific code to the new Windows-specific file w32-proc.c, leaving just the minimum changes in posix.c itself. The patc