Re: make check fails if no en_US.iso88591 locale

2009-09-10 Thread Mike Gran
On Thu, 2009-09-10 at 17:33 +0200, Ludovic Courtès wrote: > Do you think it would work to just leave `regexp.test' as it is in 1.8? It would probably work, but, it offends my sense of aesthetics that the names of the tests would be displayed in the wrong locale for the terminal. I'm uploading ye

Re: make check fails if no en_US.iso88591 locale

2009-09-10 Thread Mike Gran
> From: Neil Jerram > Mike Gran writes: > > Here's one that doesn't work as expected. > > > > guile> (string-match "[:lower:]" "Hi, mom") > > ==> #("Hi, mom" (5 . 6)) > > guile> (string-match "[:lower:]" "Hí, móm") > > ==> #f > > > > Once you add accents on the vowels, nothing matches. Doh!  Thi

Re: make check fails if no en_US.iso88591 locale

2009-09-10 Thread Neil Jerram
Mike Gran writes: > I'm not much of a regex guy, but, here's a couple of examples. First > one that sort of works as expected. > > guile> (string-match "sé" "José") > ==> #("José" (2 . 5)) > > Regex properly matches the word, but, the match struct (2 . 5) is > referring to the bytes of the stri

Re: make check fails if no en_US.iso88591 locale

2009-09-10 Thread Ludovic Courtès
Mike Gran writes: > I could fix the test by testing only characters 0 to 127 in a C locale > if a Latin-1 locale can't be found. Yes, that'd be nice. > I can also fix the test by using the 'setbinary' function --8<---cut here---start->8--- scheme@(guile-user

Re: make check fails if no en_US.iso88591 locale

2009-09-10 Thread Mike Gran
On Thu, 2009-09-10 at 12:27 +0200, Ludovic Courtès wrote: > Hello! > > I built today’s ‘master’ on a ppc64 box and there are many > regexp-related errors and a surprisingly high number of unresolved > regexp-related tests: > > http://autobuild.josefsson.org/guile/log-200909100539539848000.txt >

Re: make check fails if no en_US.iso88591 locale

2009-09-10 Thread Ludovic Courtès
Hello! I built today’s ‘master’ on a ppc64 box and there are many regexp-related errors and a surprisingly high number of unresolved regexp-related tests: http://autobuild.josefsson.org/guile/log-200909100539539848000.txt This machine only has the following locales: C en_US.utf8 POSIX

Re: make check fails if no en_US.iso88591 locale

2009-09-09 Thread Mike Gran
On Wed, 2009-09-09 at 22:53 +0100, Neil Jerram wrote: > > It is important. This is one of the problems with the whole Unicode > > effort. There is no Unicode-capable regex library. The regexp.test > > tries matching all bytes from 0 to 255, and it uses scm_to_locale_string > > to prep the string

Re: make check fails if no en_US.iso88591 locale

2009-09-09 Thread Neil Jerram
Mike Gran writes: > My bad.  Actually, I should have enclosed the 'with-locale' in the > context of a 'pass-if', which would have caught the exception. Yes, but at the cost of not running the tests... >> I can allow make check to complete by changing that line to >> >>   (false-if-exception (w

Re: make check fails if no en_US.iso88591 locale

2009-09-09 Thread Ludovic Courtès
Hi, Neil Jerram writes: > because I don't have an en_US.iso88591 locale installed, and so > > (with-locale "en_US.iso88591" ...) > > throws an 'unresolved exception. I’d suggest using ‘with-latin1-locale’ as in ‘bytevectors.test’ to mitigate this problem. (Something akin to Gnulib’s ‘locale-

Re: make check fails if no en_US.iso88591 locale

2009-09-08 Thread Mike Gran
> From: Neil Jerram > > make check fails for me in regexp.test: > >   ... >   Running regexp.test >   guile: uncaught throw to unresolved: () > > because I don't have an en_US.iso88591 locale installed, and so > >   (with-locale "en_US.iso88591" ...) > > throws an 'unresolved exception. > M