Re: Portability fixes for win32 cross compiling

No Itisnt schrieb: > Volker Grabsch writes: > > Ludovic Courtès schrieb: > >> > >> This one is wrong: the file uses mmap(3), which is declared in > >> according to > >> . > >> > >> This function is missing on MinGW, though, but

Re: Portability fixes for win32 cross compiling

On Wed 09 Jun 2010 00:12, No Itisnt writes: >>> This one is wrong: the file uses mmap(3), which is declared in >>> according to >>> . >>> >>> This function is missing on MinGW, though, but there’s currently no >>> replacement in

Re: Portability fixes for win32 cross compiling

>> This one is wrong: the file uses mmap(3), which is declared in >> according to >> . >> >> This function is missing on MinGW, though, but there’s currently no >> replacement in Guile.  Would you like to work on it? > > Sorry, I

Re: Portability fixes for win32 cross compiling

Hi, Volker Grabsch writes: > Ludovic Courtès schrieb: >> Volker Grabsch writes: >> > >> > --- a/libguile/objcodes.c >> > +++ b/libguile/objcodes.c >> > @@ -23,7 +23,6 @@ >> > #include >> > #include >> > #include >> > -#include >> > #include >> > #include >> > #include >> >> This

Re: Portability fixes for win32 cross compiling

Ludovic Courtès schrieb: > Volker Grabsch writes: > > > > --- a/libguile/objcodes.c > > +++ b/libguile/objcodes.c > > @@ -23,7 +23,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > This one is wrong: the file uses mmap(3), which is

Re: Portability fixes for win32 cross compiling

Ludovic Courtès schrieb: > Volker Grabsch writes: > > > The "gen-scmconfig" script includes a mix of native and > > cross headers, which goes horribly wrong when performing > > win32 cross compiling. > > What happens exactly? I don't think that the exact error messages are relevant here (some

Re: Portability fixes for win32 cross compiling

Hi! Volker Grabsch writes: > The "gen-scmconfig" script includes a mix of native and > cross headers, which goes horribly wrong when performing > win32 cross compiling. What happens exactly? > Is it really necessary to #include > the "uniconv.h" from the cross system and to provide correspondi

Re: Portability fixes for win32 cross compiling

Hi Volker, I’m finally in the process of reviewing and applying your patches. Volker Grabsch writes: > From 6f2b554eb5cf6a5f580689b6418fbb28d7d42c7c Mon Sep 17 00:00:00 2001 > From: Volker Grabsch > Date: Wed, 21 Apr 2010 18:45:49 +0200 > Subject: [PATCH] remove an unused and dangling #include

Re: Portability fixes for win32 cross compiling

Andy Wingo schrieb: > Your patches look good, except for one. > > On Wed 21 Apr 2010 22:22, Volker Grabsch writes: > > > --- a/libguile/bdw-gc.h > > +++ b/libguile/bdw-gc.h > > @@ -34,6 +34,8 @@ > > > > #endif > > > > +#define GC_NO_THREAD_REDIRECTS > > + > > #include > > Why did you d

Re: Portability fixes for win32 cross compiling

Hey! Andy Wingo writes: > In the future it will make it easier for me to apply these if they > follow our changelogging standards :) See any of the commits in Guile > for examples of the format. Or rather see info "(standards) Change Logs". :-) Ludo’.

Re: Portability fixes for win32 cross compiling

Hi Volker, I had your messages starred as needing attention, and was silently hoping Ludovic would deal with them. I'm sure he did the same, but in reverse ;-) Your patches look good, except for one. On Wed 21 Apr 2010 22:22, Volker Grabsch writes: > --- a/libguile/bdw-gc.h > +++ b/libguile/b

Re: Portability fixes for win32 cross compiling

Volker Grabsch writes: > Volker Grabsch schrieb: >> Okay, I just implemented that approach and it seems to work fine. >> There were several other issues I had to fix. Please have a look >> at the attached patches (6 in total). All of them seem to be needed >> to cross-compile guile for mingw32.

Re: Portability fixes for win32 cross compiling

Volker Grabsch schrieb: > Okay, I just implemented that approach and it seems to work fine. > There were several other issues I had to fix. Please have a look > at the attached patches (6 in total). All of them seem to be needed > to cross-compile guile for mingw32. Although I wan't able to fully

Re: Portability fixes for win32 cross compiling

Volker Grabsch schrieb: > Or, what about changing the generated code? Why does the generator > have to determine a number to be written into the generated code? > Instead, the generated "scmconfig.h" could contain code like this: > > #include > > ... > > #define SCM_ICONVEH_ERROR i

Re: Portability fixes for win32 cross compiling

Mike Gran schrieb: > From: Volker Grabsch v...@notjusthosting.com > > Is it really necessary to #include the > > "uniconv.h" from the cross system and to provide corresponding > > SCM_ICONVEH_* constants? > > Probably not.  I doubt that the libunistring constants are going > to change upstream,

Re: Portability fixes for win32 cross compiling

> From: Volker Grabsch v...@notjusthosting.com > Is it really necessary to #include the > "uniconv.h" from the cross system and to provide corresponding > SCM_ICONVEH_* > constants? Probably not.  I doubt that the libunistring constants are going to change upstream, so you could hack around it