Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-24 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 22:36:17 +0200 > > >> > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the > >> > trick of appending "0" to the time-zone string, Windows runtime > >> > doesn't support that. > >> > +#ifndef __MINGW32__ > >> > +

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Sat 23 Jul 2016 15:07, Eli Zaretskii writes: >> From: Andy Wingo >> Cc: guile-devel@gnu.org >> Date: Sat, 23 Jul 2016 14:15:06 +0200 >> >> > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the >> > trick of appending "0" to the time-zone string, Windows runtime >> > doesn't suppor

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 14:15:06 +0200 > > > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the > > trick of appending "0" to the time-zone string, Windows runtime > > doesn't support that. > > +#ifndef __MINGW32__ > > +/* Don't do thi

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 13:24, Eli Zaretskii writes: > From f55f1e8de40b38cc745a930bf5a374c73d3c67ce Mon Sep 17 00:00:00 2001 > From: Eli Zaretskii > Date: Sat, 16 Jul 2016 14:22:06 +0300 > Subject: [PATCH] Fix 'strftime' for MS-Windows > > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use t

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Fri 22 Jul 2016 12:21, Eli Zaretskii writes: > Ping! Two out of 3 patches sent here: > > https://lists.gnu.org/archive/html/guile-devel/2016-07/msg00085.html > > are still waiting to be accepted. I pushed the basename/dirname patch, using dirname-lgpl from gnulib as Ludo had suggested many

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 17:37, Eli Zaretskii writes: >> From: Andy Wingo >> Cc: guile-devel@gnu.org >> Date: Sat, 16 Jul 2016 15:39:23 +0200 >> >> I think the right thing here is to use the mkostemp gnulib module >> instead and pass O_BINARY in the flags. I have made this change in >> git; please l

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Fri 15 Jul 2016 21:04, Eli Zaretskii writes: > The issues with dirname and basename, for which I posted a patch here: > > https://lists.gnu.org/archive/html/guile-devel/2014-07/msg00012.html > > were subsequently discussed, but the code was not changed, AFAICT. I think we want to go with Gn

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-22 Thread Eli Zaretskii
Ping! Two out of 3 patches sent here: https://lists.gnu.org/archive/html/guile-devel/2016-07/msg00085.html are still waiting to be accepted. Thanks.

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 15:39:23 +0200 > > I think the right thing here is to use the mkostemp gnulib module > instead and pass O_BINARY in the flags. I have made this change in > git; please let me know if it causes problems for you. I'm sure it wi

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Andy Wingo
On Sat 16 Jul 2016 13:24, Eli Zaretskii writes: > diff --git a/libguile/filesys.c b/libguile/filesys.c > index 48232e8..c47c2f4 100644 > --- a/libguile/filesys.c > +++ b/libguile/filesys.c > @@ -1472,6 +1472,14 @@ SCM_DEFINE (scm_mkstemp, "mkstemp!", 1, 0, 0, >SCM_SYSCALL (rv = mkstemp (c_tmp

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 10:33:56 +0200 > > > Can these please be applied? > > Sure let's work on it. Would you mind submitting these again, making > sure they apply cleanly to stable-2.0? 3 patches against the current stable-2.0 are attached. >Fro

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Andy Wingo
Hi, On Fri 15 Jul 2016 21:04, Eli Zaretskii writes: > I built Guile 2.0.12 today with MinGW, and to my chagrin found that > some of the patches I sent long ago are still not in the repository. > > Below please find the list of those patches. > > The stime.c patch in this message was not applied,