Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp

2021-01-12 Thread Rob Browning
Mike Gran writes: > OK, fair enough. I'll push a patch on mkdtemp! in a day or two if > you're good with the idea. (I asked on IRC.) But, one thing I'd like > to change, if you don't mind, is the split into scm_i_mkdtemp and > scm_mkdtemp because there is no internal client of scm_i_mkdtemp. Oh

Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp

2021-01-04 Thread Rob Browning
Rob Browning writes: > Mike Gran writes: > >> Since mkdtemp already returns a string of the new directory name, >> it might be more scheme-like to not modify the input string, and instead >> just return the new directory name. > > Perhaps, though I was just matching the existing semantics of gui

Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp

2020-12-30 Thread Rob Browning
Mike Gran writes: > Since mkdtemp already returns a string of the new directory name, > it might be more scheme-like to not modify the input string, and instead > just return the new directory name. Perhaps, though I was just matching the existing semantics of guile mkstemp, i.e. figured maybe t

Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp

2020-12-30 Thread Mike Gran
On Tue, Dec 29, 2020 at 07:50:05PM -0600, Rob Browning wrote: > * doc/ref/posix.texi: Document mkdtemp! and scm_mkdtemp. > * libguile/filesys.c: (mkdtemp!, scm_mkdtemp): New functions. > > Signed-off-by: Rob Browning Hi Rob, Since mkdtemp already returns a string of the new directory name, it m