RE: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions.

2024-12-20 Thread Maxime Devos
> [...] > Maybe there's a misunderstanding here: What Adams test does is to compile a > list of results. What he refers to is the #t returned by the test checking > that the compiled results are correct. I changed that wording. Otherwise, I > think the test is fine (on a Unix system). Sounds re

Re: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions.

2024-12-20 Thread Nala Ginrut
> > If so, the entire (ice-9 rdelim) module needs to be revised as well as > libguile/rdelim.c since the current implementation assumes that the line > delimiter is a single character, which was not true under Windows last time > I checked. > As I know, Windows seems the only mainstream and livin

Re: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions.

2024-12-20 Thread Mikael Djurfeldt
Hi Maxime, On Fri, Dec 20, 2024 at 4:15 PM Maxime Devos wrote: > > Thanks for your patches! Applied now. > > > > Regardless of the question whether to generalise, there was also the thing > about the test testing for returning #true even though this behaviour isn’t > documented anywhere. > Mayb

RE: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions.

2024-12-20 Thread Maxime Devos
> Thanks for your patches! Applied now. Regardless of the question whether to generalise, there was also the thing about the test testing for returning #true even though this behaviour isn’t documented anywhere. Also, there was the thing about needing to verify whether (ice-9 rdelim) always rec