Re: [PATCH] Improve reporting of exception locations

2022-09-22 Thread Andrew Whatson
Maxime Devos wrote: > > Do you have some test cases, to > >(1) avoid breaking things again with future changes >(2) and show that this patch is correct? > > There recent-ish was a bug report about exception handling (on IRC), it > would be a unfortunate if whatever the fix for that turned

Re: [PATCH] Improve reporting of exception locations

2022-09-21 Thread Maxime Devos
On 21-09-2022 12:42, Maxime Devos wrote: There recent-ish was a bug report about exception handling (on IRC), it would be a unfortunate if whatever the fix for that turned out to be, causes the reporting to be wrong again -- a few test cases for this patch could prevent that. Correction: tu

Re: [PATCH] Improve reporting of exception locations

2022-09-21 Thread Maxime Devos
On 20-09-2022 04:00, Andrew Whatson wrote: Most errors were reported as coming from boot-9.scm due to incorrect hard-coded stack-narrowing offsets. This patch fixes the offsets and adds an argument to specify additional frames to skip when calling raise-exception. Do you have some test cases