Re: [PATCH] Fix thread-unsafe lazy initializations

2014-01-24 Thread Mark H Weaver
Mark H Weaver writes: > This patch fixes all of the thread-unsafe lazy initializations I could > find in stable-2.0, using 'scm_i_pthread_once'. I went ahead and pushed this, since I'm confident it's correct. Mark

Re: [PATCH] Fix thread-unsafe lazy initializations

2014-01-23 Thread Mark H Weaver
Panicz Maciej Godek writes: >>> According to Ludovic, Chris' example corresponds to >>> test-pthread-create-secondary.c -- yet they differ in that guile's >>> test doesn't use scm_c_eval_string, which helped to reveal the >>> problem. >>> Shouldn't it be added to the test suite along with the pat

Re: [PATCH] Fix thread-unsafe lazy initializations

2014-01-23 Thread Panicz Maciej Godek
2014/1/23 Mark H Weaver : >> Does this fix the error that Chris Vine found some time ago? > > Probably not, but who knows? Would you like to try? Sure, but it will take some time, because I have to set up the build environment first. I think I'll have it by tomorrow, if that's ok. > There are de

Re: [PATCH] Fix thread-unsafe lazy initializations

2014-01-23 Thread Mark H Weaver
Panicz Maciej Godek writes: > 2014/1/23 Mark H Weaver : >> This patch fixes all of the thread-unsafe lazy initializations I could >> find in stable-2.0, using 'scm_i_pthread_once'. >> >> Any comments and/or objections? > > Does this fix the error that Chris Vine found some time ago? Probably not

Re: [PATCH] Fix thread-unsafe lazy initializations

2014-01-23 Thread Panicz Maciej Godek
2014/1/23 Mark H Weaver : > This patch fixes all of the thread-unsafe lazy initializations I could > find in stable-2.0, using 'scm_i_pthread_once'. > > Any comments and/or objections? Does this fix the error that Chris Vine found some time ago? If so, is there any test in the test suite that fail

Re: [PATCH] Fix thread-unsafe lazy initializations

2013-03-05 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > Agreed. Perhaps just something like: “Note that the program should > ensure that ‘my_init’ is called only once, and in a thread-safe way.” Okay, I went ahead and pushed it to stable-2.0, with the code comment: "It is important that the call to 'my_init' ha

Re: [PATCH] Fix thread-unsafe lazy initializations

2013-03-05 Thread Ludovic Courtès
Mark H Weaver skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> Mark H Weaver skribis: >> >>> --- a/doc/ref/api-modules.texi >>> +++ b/doc/ref/api-modules.texi >>> @@ -942,14 +942,15 @@ the @var{name} is not bound in the module, signals an >>> error. Returns a >>> variable, always. >>>

Re: [PATCH] Fix thread-unsafe lazy initializations

2013-03-05 Thread Mark H Weaver
Hi Ludovic, l...@gnu.org (Ludovic Courtès) writes: > Mark H Weaver skribis: > >> --- a/doc/ref/api-modules.texi >> +++ b/doc/ref/api-modules.texi >> @@ -942,14 +942,15 @@ the @var{name} is not bound in the module, signals an >> error. Returns a >> variable, always. >> >> @example >> -SCM m

Re: [PATCH] Fix thread-unsafe lazy initializations

2013-03-01 Thread Ludovic Courtès
Mark H Weaver skribis: > From dadcb1512569c1be039fc75f0a2967e370939e42 Mon Sep 17 00:00:00 2001 > From: Mark H Weaver > Date: Thu, 28 Feb 2013 17:56:58 -0500 > Subject: [PATCH] Fix thread-unsafe lazy initializations. > > * libguile/debug.c (scm_local_eval): > libguile/ports.c (scm_current_warn