Hello,
I've made all the suggested edits. Sorry about the delay, universities
get quite busy in the middle of the semester.
> Please use the ChangeLog style for commit messages (see ‘git log’ for
> examples); as a welcome gift, we can do it for you though. :-)
I've tried to do this, please veri
The following message is a courtesy copy of an article
that has been posted to gmane.lisp.guile.devel as well.
Hi Vijay,
Sorry for the looong delay!
Overall the patches look great to me. Below are comments and
suggestions, mostly cosmetic.
Vijay Marupudi skribis:
> From 42206dec4d5e9ae51665c
Hello guile-devel,
Looking for a review and merge of this patch if possible!
~ Vijay
Vijay Marupudi schreef op do 20-01-2022 om 12:57 [-0500]:
> > Here are two examples in the wild (slib):
>
> Thanks, the patch, which is attached, now attributes credit
> appropriately.
>
> Thank you very much for your help Maxime. I believe there is nothing
> else pending and that the patch is re
> I haven't really looked closely at the documentation or code,
> but the structure of the patch seems fine now
That's good to hear, awaiting code review then!
> , except perhaps:
>
>> "Software"), to deal in the Software without restriction, including
>
> Unicode has been a thing now since quite
Vijay Marupudi schreef op do 20-01-2022 om 10:34 [-0500]:
> My latest patch now has documentation, mostly derived from the SRFI-
> 214
> documentation. Who would have figured that conversion to texinfo
> would be the
> most time consuming part of this patch?
>
> I would like advice on how to attri
> Guile's README cannot override the law, so the expat license text
> would need to remain. I think test-suite/README is primarily
> concerned license compatibility and consistency, so I guess
> for code from external sources, the ‘let GPL be the license’
> requirement can be relaxed somewhat.
>
>
> Here are two examples in the wild (slib):
Thanks, the patch, which is attached, now attributes credit
appropriately.
Thank you very much for your help Maxime. I believe there is nothing
else pending and that the patch is ready?
~ Vijay
>From 42206dec4d5e9ae51665c6e98ef07715b89b12fe Mon Sep 17
> If no copyright assignment has happend, then the copyright still
> belongs to the author
> -- from the Git repository's LICENSE: Copyright © Adam Nelson (2020)).
> While possibly you might have made some small changes to flexvectors,
> it seems that most code is preserved, so at most a ‘© FSF’ l
Vijay Marupudi schreef op wo 19-01-2022 om 10:44 [-0500]:
> > If no copyright assignment has happend, then the copyright still
> > belongs to the author
> > -- from the Git repository's LICENSE: Copyright © Adam Nelson
> > (2020)).
> > While possibly you might have made some small changes to
> > f
Vijay Marupudi schreef op wo 19-01-2022 om 08:51 [-0500]:
> > however, the README says ‘by Adam Nelson’. Did you reach some kind
> > of
> > agreement with Adam Nelson about copyright assignment? And since
> > SRFIs
> > are licensed under Expat (not 100% sure), wouldn't this need to be
> > the
> >
Thank you for taking a look Maxime. I have accidentally replied to just
you and not the whole list, so there might be a duplicate email.
> How about including the tests
> (https://github.com/scheme-requests-for-implementation/srfi-214/blob/master/implementation/tests.scm)
> as well?
>
> Guile does
Vijay Marupudi schreef op di 18-01-2022 om 21:34 [-0500]:
> Hello,
>
> I have attached to this email a patch to add support for srfi-214,
> flexvectors.
>
> I have made as few changes to the code from the sample implementation.
>
> If this is accepted, I can work on adding to the documentation.
13 matches
Mail list logo
