Re: Improved (and faster) reader

2007-09-03 Thread Ludovic Courtès
Hi, I just came across another reader regression (corner case with SCSH comments). I applied the attached patch. Thanks, Ludovic. --- orig/libguile/ChangeLog +++ mod/libguile/ChangeLog @@ -1,5 +1,9 @@ 2007-09-03 Ludovic Courtès <[EMAIL PROTECTED]> + * read.c (flush_ws): Handle SCSH block

Re: Improved (and faster) reader

2007-08-26 Thread Ludovic Courtès
¡Hola Andy! Andy Wingo <[EMAIL PROTECTED]> writes: > On Sat 25 Aug 2007 10:23, [EMAIL PROTECTED] (Ludovic Courtès) writes: > >>> By the way, what does that option actually do. The manual just says >>> "Copy source code expressions", which doesn't leave me any the wiser. >> >> This has to do with

Re: Improved (and faster) reader

2007-08-25 Thread Andy Wingo
Hi Ludovic, On Sat 25 Aug 2007 10:23, [EMAIL PROTECTED] (Ludovic Courtès) writes: >> By the way, what does that option actually do. The manual just says >> "Copy source code expressions", which doesn't leave me any the wiser. > > This has to do with unmemoization when debugging: a copy of the >

Re: Improved (and faster) reader

2007-08-25 Thread Ludovic Courtès
Hi, Kevin Ryde <[EMAIL PROTECTED]> writes: > By the way, what does that option actually do. The manual just says > "Copy source code expressions", which doesn't leave me any the wiser. This has to do with unmemoization when debugging: a copy of the unmemoized expression is attached to the sourc

Re: Improved (and faster) reader

2007-08-24 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > Did you actually trigger it Yes, it broke the self-tests of my lint program. :) (My program assumed any pair returned by the reader would have source properties. I've loosened that, since at least in principle it might not be true of stuff generate

Re: Improved (and faster) reader

2007-08-23 Thread Ludovic Courtès
Hi, Kevin Ryde <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Ludovic Courtès) writes: >> >> +scm_read_quote (int chr, SCM port) > > I think you may have lost source properties from quote and quasi-quote > forms, > > (read-enable 'positions) > (source-properties (read (open-input-st

Re: Improved (and faster) reader

2007-08-22 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > +scm_read_quote (int chr, SCM port) I think you may have lost source properties from quote and quasi-quote forms, (read-enable 'positions) (source-properties (read (open-input-string "'x"))) => () There wasn't a case in read

Re: Improved (and faster) reader

2007-08-11 Thread Ludovic Courtès
Hi, [EMAIL PROTECTED] (Ludovic Courtès) writes: > The patch removes internal functions that were exported, namely: > > scm_grow_tok_buf, scm_flush_ws, scm_casei_streq, scm_lreadr, > scm_lreadrecparen > > I think these are safe to remove, even for the next 1.8 release. > Google's codesearch (h

Improved (and faster) reader

2007-07-22 Thread Ludovic Courtès
Hi! Andy Wingo <[EMAIL PROTECTED]> writes: > At this point, to improve performance, we have two choices: (1) make > string-set! cheaper, or (2) avoid string-set!. I do not know how to do > (1) in the presence of threads[2]. (2) seems feasible, if we look at what > functions are actually calling s