Re: Cleanup mark-during-GC debug checks.

2008-09-10 Thread Andy Wingo
On Wed 10 Sep 2008 03:13, Han-Wen Nienhuys <[EMAIL PROTECTED]> writes: > My experience is that a web interface (which tracks different versions of > the same patch) is a lot easier when it is a major change with lots of > revisions. I can definitely see the value in this. But to take discussion

Re: Cleanup mark-during-GC debug checks.

2008-09-10 Thread Ludovic Courtès
Hi, Han-Wen Nienhuys <[EMAIL PROTECTED]> writes: > Ludovic Courtès escreveu: >> 1. I don't want to use a web interface to review code. Most free >> software projects use email in one form or another, which I find >> convenient. Having patches in-lined is optimal IMO. > > My experie

Re: Cleanup mark-during-GC debug checks.

2008-09-09 Thread Han-Wen Nienhuys
Ludovic Courtès escreveu: > Hello! > > [EMAIL PROTECTED] writes: > >> Reviewers: hanwenn, >> >> Message: >> Hello guile devel, >> >> please go to >> >> http://codereview.appspot.com/4847 >> >> to review this patch. >> >> >> I hope you like it; thanks! > > A couple of notes: > > 1. I don't wan

Re: Cleanup mark-during-GC debug checks.

2008-09-09 Thread Andy Wingo
On Tue 09 Sep 2008 19:34, [EMAIL PROTECTED] (Ludovic Courtès) writes: > 1. I don't want to use a web interface to review code. Most free > software projects use email in one form or another, which I find > convenient. Having patches in-lined is optimal IMO. Me neither. OTOH a web fr

Re: Cleanup mark-during-GC debug checks.

2008-09-09 Thread Ludovic Courtès
Hello! [EMAIL PROTECTED] writes: > Reviewers: hanwenn, > > Message: > Hello guile devel, > > please go to > > http://codereview.appspot.com/4847 > > to review this patch. > > > I hope you like it; thanks! A couple of notes: 1. I don't want to use a web interface to review code. Most free

Cleanup mark-during-GC debug checks.

2008-09-09 Thread hanwenn
Reviewers: hanwenn, Message: Hello guile devel, please go to http://codereview.appspot.com/4847 to review this patch. I hope you like it; thanks! Please review this at http://codereview.appspot.com/4847 Affected files: M libguile/__scm.h M libguile/gc-mark.c M libguile/gc.c M lib