Mark H Weaver skribis:
> l...@gnu.org (Ludovic Courtès) writes:
>
>> Looks good.
>>
>> Minor comments:
[...]
>>> +Unless binary mode is requested, the character encoding of the new port
>>> +is determined as follows: First, if @var{guess-encoding} is true,
>>> +heuristics will be used to guess
Hi Ludovic,
Thanks for the quick reviews. I pushed the first two patches, after
incorporating your suggestions.
l...@gnu.org (Ludovic Courtès) writes:
> Looks good.
>
> Minor comments:
>
>> +@deffn {Scheme Procedure} open-file filename mode @
>> + [#:guess-encoding=#f]
Mark H Weaver skribis:
> From 951b9d224d84bfec271b51615bc095013d153694 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver
> Date: Sat, 6 Apr 2013 23:19:55 -0400
> Subject: [PATCH 3/3] Add keyword arguments to file opening procedures.
>
> * libguile/fports.c (scm_open_file_with_encoding): New API fun
Mark H Weaver skribis:
> From 2b4fa986ac43b5a8705f2d24e5fc908e07a89b94 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver
> Date: Fri, 5 Apr 2013 17:33:03 -0400
> Subject: [PATCH 2/3] Remove byte-order mark check from
> 'scm_i_scan_for_encoding'.
>
> * libguile/read.c (scm_i_scan_for_encoding): Rem
Mark H Weaver skribis:
> From bb621dbbc0df691bcad541267a08c86c36d9062b Mon Sep 17 00:00:00 2001
> From: Mark H Weaver
> Date: Wed, 30 Jan 2013 14:45:28 -0500
> Subject: [PATCH 1/3] Do not scan for coding declarations in open-file.
>
> * libguile/fports.c (scm_open_file): Do not scan for coding
>
Hello all,
Here's the last major patch set that I very much hope to get into 2.0.8.
The first patch disables the coding declaration scan in 'open-file' by
default. I feel quite strongly that this is important for robustness
and security reasons, and I'm pleased to report that Ludovic recently
gav
