Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-03 Thread Blake Shaw
Josselin Poiret writes: > Hi Blake and David, > > We were talking about this very node of the documentation yesterday with > Ludovic and zimoun, so here are my two cents. Rewriting this > introduction is a very good idea, the current one is pretty hard to get > into for novices. > > David Pirot

Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-03 Thread Josselin Poiret
Hi Blake and David, We were talking about this very node of the documentation yesterday with Ludovic and zimoun, so here are my two cents. Rewriting this introduction is a very good idea, the current one is pretty hard to get into for novices. David Pirotte writes: > Not at all - and quite anno

Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-03 Thread Blake Shaw
Arun Isaac writes: > Hi Blake, > >> Well, these conventions can be found throughout the gamut of scheme >> literature going back to the 80s, and some of the largest scheme >> projects, such as Chez, Racket, etc. employ them. So if you're >> getting into Scheme, you'll necessarily encounter them

Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-03 Thread Arun Isaac
Hi Blake, > Well, these conventions can be found throughout the gamut of scheme > literature going back to the 80s, and some of the largest scheme > projects, such as Chez, Racket, etc. employ them. So if you're > getting into Scheme, you'll necessarily encounter them, and if you > haven't been

Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-03 Thread Blake Shaw
David Pirotte writes: > Not at all - and quite annoying. imo. > So i'd 'vote' not to use them anywhere in the guile reference manual take the following functions in both styles: (let unwrap ((peel '(unnest arbitrary nestings))) (match-let* (((core ...)) peel) ((wrappe

Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-02 Thread David Pirotte
> > - > > style: switch to "Indiana style", bracketing lets and clauses > > -- > > After spending much time looking at the examples in black & white > > to edit the texinfo document, it occurred to me just how much the > > brackets improve legibility. Not at all - and quite annoying. imo. So i'd

Re: [PATCH v3] docs/match: pattern matcher example makeover

2023-02-01 Thread Maxime Devos
On 01-02-2023 14:09, Blake Shaw wrote: [...] - style: clean-up newlines -- It appears that while the PDF needs additional newlines to be presentable, these appear to have a negative effect on the presentation of the texinfo doc. I don't know how to fix this, but from looking at the PDF, it ap

[PATCH v3] docs/match: pattern matcher example makeover

2023-02-01 Thread Blake Shaw
[V3 update] @xref{sxml-match} had been commented out because it was interfering with emacs makeinfo. This ammends that change. Also adding `--` to breakup changelog into a more digestible format. Reviewing everything all else, everything appears fine. [V2 update] All changes have been squashed i